All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Conor Dooley <conor@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
	<jirislaby@kernel.org>, <khilman@baylibre.com>,
	<martin.blumenstingl@googlemail.com>, <kelvin.zhang@amlogic.com>,
	<xianwei.zhao@amlogic.com>, <kernel@sberdevices.ru>,
	<rockosov@gmail.com>, <linux-amlogic@lists.infradead.org>,
	<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string
Date: Tue, 4 Jul 2023 20:19:00 +0300	[thread overview]
Message-ID: <20230704171900.ulnnpkuzvtbbqa3d@CAB-WSD-L081021> (raw)
In-Reply-To: <20230704-staff-smilingly-401b99e28edd@spud>

On Tue, Jul 04, 2023 at 06:10:46PM +0100, Conor Dooley wrote:
> On Tue, Jul 04, 2023 at 08:08:43PM +0300, Dmitry Rokosov wrote:
> > On Tue, Jul 04, 2023 at 06:02:58PM +0100, Conor Dooley wrote:
> > > On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> > > > In the current implementation, the meson-a1 configuration incorporates a
> > > > unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> > > > driver due to its usage of the new console device name "ttyS".
> > > > Consequently, the previous compatibility tag designated for the
> > > > 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> > > > longer relevant to the current setup.
> > > 
> > > I don't really see why you would remove the gx-uart to be honest, and
> > > not use it as a fallback. Neil's platform though, so his call :)
> > > 
> > 
> > Because of amlogic,meson-gx-uart has legacy devname, we do not want to
> > use it in the A1.
> 
> Which I did read in your commit message, fallback being the operative
> word here.

Although it is difficult for me to envision a situation where we would
require this fallback, but gx-uart fallback will function from a kernel
perspective (without taking into account bootloader setup or userspace
daemon script). I don't have any objections to stay gx-uart as a
fallback, will do it in the v2.

-- 
Thank you,
Dmitry

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Conor Dooley <conor@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
	<jirislaby@kernel.org>, <khilman@baylibre.com>,
	<martin.blumenstingl@googlemail.com>, <kelvin.zhang@amlogic.com>,
	<xianwei.zhao@amlogic.com>, <kernel@sberdevices.ru>,
	<rockosov@gmail.com>, <linux-amlogic@lists.infradead.org>,
	<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string
Date: Tue, 4 Jul 2023 20:19:00 +0300	[thread overview]
Message-ID: <20230704171900.ulnnpkuzvtbbqa3d@CAB-WSD-L081021> (raw)
In-Reply-To: <20230704-staff-smilingly-401b99e28edd@spud>

On Tue, Jul 04, 2023 at 06:10:46PM +0100, Conor Dooley wrote:
> On Tue, Jul 04, 2023 at 08:08:43PM +0300, Dmitry Rokosov wrote:
> > On Tue, Jul 04, 2023 at 06:02:58PM +0100, Conor Dooley wrote:
> > > On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> > > > In the current implementation, the meson-a1 configuration incorporates a
> > > > unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> > > > driver due to its usage of the new console device name "ttyS".
> > > > Consequently, the previous compatibility tag designated for the
> > > > 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> > > > longer relevant to the current setup.
> > > 
> > > I don't really see why you would remove the gx-uart to be honest, and
> > > not use it as a fallback. Neil's platform though, so his call :)
> > > 
> > 
> > Because of amlogic,meson-gx-uart has legacy devname, we do not want to
> > use it in the A1.
> 
> Which I did read in your commit message, fallback being the operative
> word here.

Although it is difficult for me to envision a situation where we would
require this fallback, but gx-uart fallback will function from a kernel
perspective (without taking into account bootloader setup or userspace
daemon script). I don't have any objections to stay gx-uart as a
fallback, will do it in the v2.

-- 
Thank you,
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: Conor Dooley <conor@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
	<jirislaby@kernel.org>, <khilman@baylibre.com>,
	<martin.blumenstingl@googlemail.com>, <kelvin.zhang@amlogic.com>,
	<xianwei.zhao@amlogic.com>, <kernel@sberdevices.ru>,
	<rockosov@gmail.com>, <linux-amlogic@lists.infradead.org>,
	<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string
Date: Tue, 4 Jul 2023 20:19:00 +0300	[thread overview]
Message-ID: <20230704171900.ulnnpkuzvtbbqa3d@CAB-WSD-L081021> (raw)
In-Reply-To: <20230704-staff-smilingly-401b99e28edd@spud>

On Tue, Jul 04, 2023 at 06:10:46PM +0100, Conor Dooley wrote:
> On Tue, Jul 04, 2023 at 08:08:43PM +0300, Dmitry Rokosov wrote:
> > On Tue, Jul 04, 2023 at 06:02:58PM +0100, Conor Dooley wrote:
> > > On Tue, Jul 04, 2023 at 04:59:36PM +0300, Dmitry Rokosov wrote:
> > > > In the current implementation, the meson-a1 configuration incorporates a
> > > > unique compatibility tag "amlogic,meson-a1-uart' within the meson-uart
> > > > driver due to its usage of the new console device name "ttyS".
> > > > Consequently, the previous compatibility tag designated for the
> > > > 'amlogic,meson-gx-uart' configuration has become obsolete and is no
> > > > longer relevant to the current setup.
> > > 
> > > I don't really see why you would remove the gx-uart to be honest, and
> > > not use it as a fallback. Neil's platform though, so his call :)
> > > 
> > 
> > Because of amlogic,meson-gx-uart has legacy devname, we do not want to
> > use it in the A1.
> 
> Which I did read in your commit message, fallback being the operative
> word here.

Although it is difficult for me to envision a situation where we would
require this fallback, but gx-uart fallback will function from a kernel
perspective (without taking into account bootloader setup or userspace
daemon script). I don't have any objections to stay gx-uart as a
fallback, will do it in the v2.

-- 
Thank you,
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-04 17:19 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 13:59 [PATCH v1 0/5] tty: serial: meson: support ttyS devname Dmitry Rokosov
2023-07-04 13:59 ` Dmitry Rokosov
2023-07-04 13:59 ` Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 1/5] tty: serial: meson: use dev_err_probe Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 2/5] tty: serial: meson: redesign the module to platform_driver Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 14:46   ` neil.armstrong
2023-07-04 14:46     ` neil.armstrong
2023-07-04 14:46     ` neil.armstrong
2023-07-04 15:19     ` Dmitry Rokosov
2023-07-04 15:19       ` Dmitry Rokosov
2023-07-04 15:19       ` Dmitry Rokosov
2023-07-04 17:06       ` Dmitry Rokosov
2023-07-04 17:06         ` Dmitry Rokosov
2023-07-04 17:06         ` Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 3/5] tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 14:42   ` neil.armstrong
2023-07-04 14:42     ` neil.armstrong
2023-07-04 14:42     ` neil.armstrong
2023-07-04 14:59     ` Dmitry Rokosov
2023-07-04 14:59       ` Dmitry Rokosov
2023-07-04 14:59       ` Dmitry Rokosov
2023-07-04 15:29       ` neil.armstrong
2023-07-04 15:29         ` neil.armstrong
2023-07-04 15:29         ` neil.armstrong
2023-07-04 16:00         ` Dmitry Rokosov
2023-07-04 16:00           ` Dmitry Rokosov
2023-07-04 16:00           ` Dmitry Rokosov
2023-07-04 16:57   ` Conor Dooley
2023-07-04 16:57     ` Conor Dooley
2023-07-04 16:57     ` Conor Dooley
2023-07-04 17:13     ` Dmitry Rokosov
2023-07-04 17:13       ` Dmitry Rokosov
2023-07-04 17:13       ` Dmitry Rokosov
2023-07-04 19:14       ` Conor Dooley
2023-07-04 19:14         ` Conor Dooley
2023-07-04 19:14         ` Conor Dooley
2023-07-04 13:59 ` [PATCH v1 4/5] dt-bindings: serial: amlogic,meson-uart: support Amlogic A1 Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-05 19:00   ` Rob Herring
2023-07-05 19:00     ` Rob Herring
2023-07-05 19:00     ` Rob Herring
2023-07-04 13:59 ` [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 13:59   ` Dmitry Rokosov
2023-07-04 17:02   ` Conor Dooley
2023-07-04 17:02     ` Conor Dooley
2023-07-04 17:02     ` Conor Dooley
2023-07-04 17:08     ` Dmitry Rokosov
2023-07-04 17:08       ` Dmitry Rokosov
2023-07-04 17:08       ` Dmitry Rokosov
2023-07-04 17:10       ` Conor Dooley
2023-07-04 17:10         ` Conor Dooley
2023-07-04 17:10         ` Conor Dooley
2023-07-04 17:19         ` Dmitry Rokosov [this message]
2023-07-04 17:19           ` Dmitry Rokosov
2023-07-04 17:19           ` Dmitry Rokosov
2023-07-05  9:46           ` Dmitry Rokosov
2023-07-05  9:46             ` Dmitry Rokosov
2023-07-05  9:46             ` Dmitry Rokosov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230704171900.ulnnpkuzvtbbqa3d@CAB-WSD-L081021 \
    --to=ddrokosov@sberdevices.ru \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=jirislaby@kernel.org \
    --cc=kelvin.zhang@amlogic.com \
    --cc=kernel@sberdevices.ru \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    --cc=xianwei.zhao@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.