From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: hsiangkao@linux.alibaba.com, chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org
Cc: alexl@redhat.com
Subject: [PATCH v2 0/3] erofs-utils: introduce xattr name bloom filter
Date: Wed, 5 Jul 2023 15:10:14 +0800 [thread overview]
Message-ID: <20230705071017.104130-1-jefflexu@linux.alibaba.com> (raw)
changes since RFC:
- the number of hash functions is 1, and now it's implemented as:
xxh32(name, strlen(name), EROFS_XATTR_FILTER_SEED + index),
where the constant magic number EROFS_XATTR_FILTER_SEED [*] is used to
give a better spread for the mapping. (Alexander Larsson)
- fix the value of EROFS_FEATURE_COMPAT_XATTR_FILTER; rename
EROFS_XATTR_BLOOM_* to EROFS_XATTR_FILTER_* (Gao Xiang)
RFC: https://lore.kernel.org/all/20230621083939.128961-1-jefflexu@linux.alibaba.com/
The xattr bloom filter feature is used to boost the negative xattr
lookup.
Refer to the kernel patch set [*] for more details.
[*] https://lore.kernel.org/all/20230705070427.92579-1-jefflexu@linux.alibaba.com/
Jingbo Xu (3):
erofs-utils: add xxh32 library
erofs-utils: update on-disk format for xattr name filter
erofs-utils: mkfs: enable xattr name filter
include/erofs/config.h | 1 +
include/erofs/internal.h | 1 +
include/erofs/xxhash.h | 35 +++++++++++++++++
include/erofs_fs.h | 10 ++++-
lib/Makefile.am | 3 +-
lib/xattr.c | 74 ++++++++++++++++++++++++++--------
lib/xxhash.c | 85 ++++++++++++++++++++++++++++++++++++++++
mkfs/main.c | 6 +++
8 files changed, 197 insertions(+), 18 deletions(-)
create mode 100644 include/erofs/xxhash.h
create mode 100644 lib/xxhash.c
--
2.19.1.6.gb485710b
next reply other threads:[~2023-07-05 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:10 Jingbo Xu [this message]
2023-07-05 7:10 ` [PATCH v2 1/3] erofs-utils: add xxh32 library Jingbo Xu
2023-07-05 7:29 ` Gao Xiang
2023-07-12 11:58 ` Jingbo Xu
2023-07-05 7:10 ` [PATCH v2 2/3] erofs-utils: update on-disk format for xattr name filter Jingbo Xu
2023-07-05 7:10 ` [PATCH v2 3/3] erofs-utils: mkfs: enable " Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705071017.104130-1-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.