From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
chao@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org
Cc: alexl@redhat.com
Subject: Re: [PATCH v2 1/3] erofs-utils: add xxh32 library
Date: Wed, 12 Jul 2023 19:58:00 +0800 [thread overview]
Message-ID: <a57cb804-0d78-255c-0bba-dab69686b196@linux.alibaba.com> (raw)
In-Reply-To: <b2f87329-8d2c-5106-e61c-4dffd8be7e8c@linux.alibaba.com>
On 7/5/23 3:29 PM, Gao Xiang wrote:
>
>
> On 2023/7/5 15:10, Jingbo Xu wrote:
>> Add xxh32 library which could be used by following xattr bloom filter
>> feature.
>>
>> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
>
> I'd suggest using the original xxhash library instead of copying an
> simplified implementation here since we don't touch the implementation.
>
> https://rpmfind.net/linux/rpm2html/search.php?query=xxhash
Yeah. I think xxhash-devel is available in most distributions. XXH32()
could be used directly here and configure.ac needs to be updated to
reflect the package dependency.
As I'm not quite familiar with autoconf/automake, later in v3 I will
still attach the self-implemented xxh32() in erofs-utils. Maybe later
we could change to use libxxhash directly.
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-07-12 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:10 [PATCH v2 0/3] erofs-utils: introduce xattr name bloom filter Jingbo Xu
2023-07-05 7:10 ` [PATCH v2 1/3] erofs-utils: add xxh32 library Jingbo Xu
2023-07-05 7:29 ` Gao Xiang
2023-07-12 11:58 ` Jingbo Xu [this message]
2023-07-05 7:10 ` [PATCH v2 2/3] erofs-utils: update on-disk format for xattr name filter Jingbo Xu
2023-07-05 7:10 ` [PATCH v2 3/3] erofs-utils: mkfs: enable " Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a57cb804-0d78-255c-0bba-dab69686b196@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=alexl@redhat.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.