From: Eric Biggers <ebiggers@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [dm-devel] [PATCH] blk-crypto: use dynamic lock class for blk_crypto_profile::lock
Date: Wed, 5 Jul 2023 14:33:26 -0700 [thread overview]
Message-ID: <20230705213326.GC866@sol.localdomain> (raw)
In-Reply-To: <20230610061139.212085-1-ebiggers@kernel.org>
On Fri, Jun 09, 2023 at 11:11:39PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When a device-mapper device is passing through the inline encryption
> support of an underlying device, calls to blk_crypto_evict_key() take
> the blk_crypto_profile::lock of the device-mapper device, then take the
> blk_crypto_profile::lock of the underlying device (nested). This isn't
> a real deadlock, but it causes a lockdep report because there is only
> one lock class for all instances of this lock.
>
> Lockdep subclasses don't really work here because the hierarchy of block
> devices is dynamic and could have more than 2 levels.
>
> Instead, register a dynamic lock class for each blk_crypto_profile, and
> associate that with the lock.
Jens, can you apply this?
- Eric
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] blk-crypto: use dynamic lock class for blk_crypto_profile::lock
Date: Wed, 5 Jul 2023 14:33:26 -0700 [thread overview]
Message-ID: <20230705213326.GC866@sol.localdomain> (raw)
In-Reply-To: <20230610061139.212085-1-ebiggers@kernel.org>
On Fri, Jun 09, 2023 at 11:11:39PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> When a device-mapper device is passing through the inline encryption
> support of an underlying device, calls to blk_crypto_evict_key() take
> the blk_crypto_profile::lock of the device-mapper device, then take the
> blk_crypto_profile::lock of the underlying device (nested). This isn't
> a real deadlock, but it causes a lockdep report because there is only
> one lock class for all instances of this lock.
>
> Lockdep subclasses don't really work here because the hierarchy of block
> devices is dynamic and could have more than 2 levels.
>
> Instead, register a dynamic lock class for each blk_crypto_profile, and
> associate that with the lock.
Jens, can you apply this?
- Eric
next prev parent reply other threads:[~2023-07-05 21:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 6:11 [dm-devel] [PATCH] blk-crypto: use dynamic lock class for blk_crypto_profile::lock Eric Biggers
2023-06-10 6:11 ` Eric Biggers
2023-06-12 17:45 ` [dm-devel] " Bart Van Assche
2023-06-12 17:45 ` Bart Van Assche
2023-07-05 21:33 ` Eric Biggers [this message]
2023-07-05 21:33 ` Eric Biggers
2023-07-05 21:48 ` [dm-devel] " Jens Axboe
2023-07-05 21:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705213326.GC866@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.