From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"david.edmondson@oracle.com" <david.edmondson@oracle.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"sburla@marvell.com" <sburla@marvell.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands
Date: Thu, 6 Jul 2023 02:10:10 -0400 [thread overview]
Message-ID: <20230706020803-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481D2368A718164DE18DCDCDC2CA@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Jul 06, 2023 at 04:20:03AM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, July 5, 2023 7:09 AM
>
> > OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go in
> > depth over the last patch, but I feel it should be squashed into the generic
> > legacy command sections avoiding need for indirection, so rewriting it now
> > wouldn't be efficient.
>
> I address all your comments and of Cornelia.
> PCI part I still prefer to be separate so kept it.
>
> Thanks a lot.
I clarified some questions you asked about. Maybe v11 is justified
in view of my answers. Let me know before I review again.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"david.edmondson@oracle.com" <david.edmondson@oracle.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"sburla@marvell.com" <sburla@marvell.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] Re: [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands
Date: Thu, 6 Jul 2023 02:10:10 -0400 [thread overview]
Message-ID: <20230706020803-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481D2368A718164DE18DCDCDC2CA@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Jul 06, 2023 at 04:20:03AM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, July 5, 2023 7:09 AM
>
> > OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go in
> > depth over the last patch, but I feel it should be squashed into the generic
> > legacy command sections avoiding need for indirection, so rewriting it now
> > wouldn't be efficient.
>
> I address all your comments and of Cornelia.
> PCI part I still prefer to be separate so kept it.
>
> Thanks a lot.
I clarified some questions you asked about. Maybe v11 is justified
in view of my answers. Let me know before I review again.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-07-06 6:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 23:37 [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands Parav Pandit
2023-07-04 23:37 ` [virtio-dev] " Parav Pandit
2023-07-04 23:37 ` [virtio-comment] [PATCH v9 1/4] admin: Split opcode table rows with a line Parav Pandit
2023-07-04 23:37 ` [virtio-dev] " Parav Pandit
2023-07-05 10:05 ` [virtio-comment] " Cornelia Huck
2023-07-05 10:05 ` [virtio-dev] " Cornelia Huck
2023-07-04 23:37 ` [virtio-comment] [PATCH v9 2/4] admin: Fix section numbering Parav Pandit
2023-07-04 23:37 ` [virtio-dev] " Parav Pandit
2023-07-05 10:09 ` [virtio-comment] " Cornelia Huck
2023-07-05 10:09 ` [virtio-dev] " Cornelia Huck
2023-07-05 16:29 ` [virtio-comment] " Parav Pandit
2023-07-05 16:29 ` Parav Pandit
2023-07-04 23:37 ` [virtio-comment] [PATCH v9 3/4] admin: Add group member legacy register access commands Parav Pandit
2023-07-04 23:37 ` [virtio-dev] " Parav Pandit
2023-07-05 10:24 ` [virtio-comment] " Cornelia Huck
2023-07-05 10:24 ` [virtio-dev] " Cornelia Huck
2023-07-05 16:34 ` [virtio-comment] " Parav Pandit
2023-07-05 16:34 ` [virtio-dev] " Parav Pandit
2023-07-06 5:43 ` [virtio-comment] " Michael S. Tsirkin
2023-07-06 5:43 ` [virtio-dev] " Michael S. Tsirkin
2023-07-05 11:04 ` [virtio-comment] " Michael S. Tsirkin
2023-07-05 11:04 ` [virtio-dev] " Michael S. Tsirkin
2023-07-05 18:26 ` Parav Pandit
2023-07-05 18:26 ` [virtio-dev] " Parav Pandit
2023-07-06 6:01 ` Michael S. Tsirkin
2023-07-06 6:01 ` [virtio-dev] " Michael S. Tsirkin
2023-07-05 22:01 ` Parav Pandit
2023-07-05 22:01 ` [virtio-dev] " Parav Pandit
2023-07-04 23:37 ` [virtio-comment] [PATCH v9 4/4] transport-pci: Introduce group legacy group member config region access Parav Pandit
2023-07-04 23:37 ` [virtio-dev] " Parav Pandit
2023-07-05 10:29 ` [virtio-comment] " Cornelia Huck
2023-07-05 10:29 ` [virtio-dev] " Cornelia Huck
2023-07-05 16:36 ` [virtio-comment] " Parav Pandit
2023-07-05 16:36 ` [virtio-dev] " Parav Pandit
2023-07-05 10:56 ` [virtio-comment] " Michael S. Tsirkin
2023-07-05 10:56 ` [virtio-dev] " Michael S. Tsirkin
2023-07-05 11:09 ` [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands Michael S. Tsirkin
2023-07-05 11:09 ` [virtio-dev] " Michael S. Tsirkin
2023-07-05 13:01 ` Parav Pandit
2023-07-05 13:01 ` [virtio-dev] " Parav Pandit
2023-07-05 13:42 ` Cornelia Huck
2023-07-05 13:42 ` [virtio-dev] " Cornelia Huck
2023-07-05 14:37 ` Parav Pandit
2023-07-05 14:37 ` [virtio-dev] " Parav Pandit
2023-07-06 4:20 ` Parav Pandit
2023-07-06 4:20 ` [virtio-dev] " Parav Pandit
2023-07-06 6:10 ` Michael S. Tsirkin [this message]
2023-07-06 6:10 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706020803-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=jasowang@redhat.com \
--cc=maorg@nvidia.com \
--cc=parav@nvidia.com \
--cc=sburla@marvell.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.