From: Manivannan Sadhasivam <mani@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Mrinmay Sarkar" <quic_msarkar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
konrad.dybcio@linaro.org, quic_shazhuss@quicinc.com,
quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com,
quic_nayiluri@quicinc.com,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v1 0/6] arm64: qcom: sa8775p: add support for PCIe
Date: Thu, 6 Jul 2023 16:42:18 +0530 [thread overview]
Message-ID: <20230706111218.GA4808@thinkpad> (raw)
In-Reply-To: <a450e2e8-307d-49e9-d76d-de397b801a96@linaro.org>
On Thu, Jul 06, 2023 at 08:39:54AM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2023 10:46, Manivannan Sadhasivam wrote:
> > On Wed, Jul 05, 2023 at 01:47:05PM +0530, Mrinmay Sarkar wrote:
> >> Update the relavent DT bindings for PCIe, add new config to the phy
> >> driver add pcie and phy nodes to the .dtsi file and enable then in
> >> board .dts file for the sa8775p-ride platform.
> >>
> >> Mrinmay Sarkar (6):
> >> dt-bindings: PCI: qcom: Add sa8775p compatible
> >> dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY
> >> PCI: qcom: Add support for sa8775p SoC
> >> phy: qcom-qmp-pcie: add support for sa8775p
> >> arm64: dts: qcom: sa8775p: Add pcie0 and pcie1 nodes
> >> arm64: dts: qcom: sa8775p-ride: enable pcie nodes
> >
> > Please note that the dts patches should come before driver patches.
> >
>
> Why? DTS is always independent thus usually put at the end of patchset
> or better separate. It is the first time I hear that DTS should be
> before driver.
>
This is what I was suggested by Rob during my initial days and I've been
following this pattern since then. If that's not the case, I have no issues.
- Mani
> Best regards,
> Krzysztof
>
--
மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Mrinmay Sarkar" <quic_msarkar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
konrad.dybcio@linaro.org, quic_shazhuss@quicinc.com,
quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com,
quic_nayiluri@quicinc.com,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH v1 0/6] arm64: qcom: sa8775p: add support for PCIe
Date: Thu, 6 Jul 2023 16:42:18 +0530 [thread overview]
Message-ID: <20230706111218.GA4808@thinkpad> (raw)
In-Reply-To: <a450e2e8-307d-49e9-d76d-de397b801a96@linaro.org>
On Thu, Jul 06, 2023 at 08:39:54AM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2023 10:46, Manivannan Sadhasivam wrote:
> > On Wed, Jul 05, 2023 at 01:47:05PM +0530, Mrinmay Sarkar wrote:
> >> Update the relavent DT bindings for PCIe, add new config to the phy
> >> driver add pcie and phy nodes to the .dtsi file and enable then in
> >> board .dts file for the sa8775p-ride platform.
> >>
> >> Mrinmay Sarkar (6):
> >> dt-bindings: PCI: qcom: Add sa8775p compatible
> >> dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY
> >> PCI: qcom: Add support for sa8775p SoC
> >> phy: qcom-qmp-pcie: add support for sa8775p
> >> arm64: dts: qcom: sa8775p: Add pcie0 and pcie1 nodes
> >> arm64: dts: qcom: sa8775p-ride: enable pcie nodes
> >
> > Please note that the dts patches should come before driver patches.
> >
>
> Why? DTS is always independent thus usually put at the end of patchset
> or better separate. It is the first time I hear that DTS should be
> before driver.
>
This is what I was suggested by Rob during my initial days and I've been
following this pattern since then. If that's not the case, I have no issues.
- Mani
> Best regards,
> Krzysztof
>
--
மணிவண்ணன் சதாசிவம்
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-07-06 11:12 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 8:17 [PATCH v1 0/6] arm64: qcom: sa8775p: add support for PCIe Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-05 8:17 ` [PATCH v1 1/6] dt-bindings: PCI: qcom: Add sa8775p compatible Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-05 8:25 ` Manivannan Sadhasivam
2023-07-05 8:25 ` Manivannan Sadhasivam
2023-07-05 9:16 ` Rob Herring
2023-07-05 9:16 ` Rob Herring
2023-07-05 8:17 ` [PATCH v1 2/6] dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-05 8:26 ` Manivannan Sadhasivam
2023-07-05 8:26 ` Manivannan Sadhasivam
2023-07-05 9:16 ` Rob Herring
2023-07-05 9:16 ` Rob Herring
2023-07-06 6:35 ` Krzysztof Kozlowski
2023-07-06 6:35 ` Krzysztof Kozlowski
2023-07-05 8:17 ` [PATCH v1 3/6] PCI: qcom: Add support for sa8775p SoC Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-05 8:28 ` Manivannan Sadhasivam
2023-07-05 8:28 ` Manivannan Sadhasivam
2023-07-05 8:17 ` [PATCH v1 4/6] phy: qcom-qmp-pcie: add support for sa8775p Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-06 14:53 ` Dmitry Baryshkov
2023-07-06 14:53 ` Dmitry Baryshkov
2023-07-13 6:59 ` Mrinmay Sarkar
2023-07-13 6:59 ` Mrinmay Sarkar
2023-07-13 9:11 ` Dmitry Baryshkov
2023-07-13 9:11 ` Dmitry Baryshkov
2023-07-05 8:17 ` [PATCH v1 5/6] arm64: dts: qcom: sa8775p: Add pcie0 and pcie1 nodes Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-05 8:36 ` Manivannan Sadhasivam
2023-07-05 8:36 ` Manivannan Sadhasivam
2023-07-06 6:38 ` Krzysztof Kozlowski
2023-07-06 6:38 ` Krzysztof Kozlowski
2023-07-06 10:01 ` Konrad Dybcio
2023-07-06 10:01 ` Konrad Dybcio
2023-07-06 11:15 ` Manivannan Sadhasivam
2023-07-06 11:15 ` Manivannan Sadhasivam
2023-07-05 8:17 ` [PATCH v1 6/6] arm64: dts: qcom: sa8775p-ride: enable pcie nodes Mrinmay Sarkar
2023-07-05 8:17 ` Mrinmay Sarkar
2023-07-06 6:38 ` Krzysztof Kozlowski
2023-07-06 6:38 ` Krzysztof Kozlowski
2023-07-06 11:18 ` Konrad Dybcio
2023-07-06 11:18 ` Konrad Dybcio
2023-07-05 8:46 ` [PATCH v1 0/6] arm64: qcom: sa8775p: add support for PCIe Manivannan Sadhasivam
2023-07-05 8:46 ` Manivannan Sadhasivam
2023-07-06 6:39 ` Krzysztof Kozlowski
2023-07-06 6:39 ` Krzysztof Kozlowski
2023-07-06 11:12 ` Manivannan Sadhasivam [this message]
2023-07-06 11:12 ` Manivannan Sadhasivam
2023-07-06 12:09 ` Krzysztof Kozlowski
2023-07-06 12:09 ` Krzysztof Kozlowski
2023-07-06 12:12 ` Konrad Dybcio
2023-07-06 12:12 ` Konrad Dybcio
2023-07-13 7:22 ` Manivannan Sadhasivam
2023-07-13 7:22 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706111218.GA4808@thinkpad \
--to=mani@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nayiluri@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.