All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-fbdev@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 11/11] fbdev: Harmonize some comments in <linux/fb.h>
Date: Thu,  6 Jul 2023 14:46:49 +0200	[thread overview]
Message-ID: <20230706124905.15134-12-tzimmermann@suse.de> (raw)
In-Reply-To: <20230706124905.15134-1-tzimmermann@suse.de>

Make the comments for I/O, system and DMA memory say the same.
Makes the header file's structure more obvious.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
---
 include/linux/fb.h | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index d370f84fbca9..c8ca9c265fda 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -529,7 +529,7 @@ extern int fb_pan_display(struct fb_info *info, struct fb_var_screeninfo *var);
 extern int fb_blank(struct fb_info *info, int blank);
 
 /*
- * Drawing operations where framebuffer is in I/O memory
+ * Helpers for framebuffers in I/O memory
  */
 
 extern void cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -540,10 +540,6 @@ extern ssize_t fb_io_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 			   size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in I/O memory.
- */
-
 #define __FB_DEFAULT_IO_OPS_RDWR \
 	.fb_read	= fb_io_read, \
 	.fb_write	= fb_io_write
@@ -562,7 +558,7 @@ extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 	__FB_DEFAULT_IO_OPS_MMAP
 
 /*
- * Drawing operations where framebuffer is in system RAM
+ * Helpers for framebuffers in system memory
  */
 
 extern void sys_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -573,10 +569,6 @@ extern ssize_t fb_sys_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
 			    size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in system memory.
- */
-
 #define __FB_DEFAULT_SYS_OPS_RDWR \
 	.fb_read	= fb_sys_read, \
 	.fb_write	= fb_sys_write
-- 
2.41.0


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-fbdev@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 11/11] fbdev: Harmonize some comments in <linux/fb.h>
Date: Thu,  6 Jul 2023 14:46:49 +0200	[thread overview]
Message-ID: <20230706124905.15134-12-tzimmermann@suse.de> (raw)
In-Reply-To: <20230706124905.15134-1-tzimmermann@suse.de>

Make the comments for I/O, system and DMA memory say the same.
Makes the header file's structure more obvious.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
---
 include/linux/fb.h | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index d370f84fbca9..c8ca9c265fda 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -529,7 +529,7 @@ extern int fb_pan_display(struct fb_info *info, struct fb_var_screeninfo *var);
 extern int fb_blank(struct fb_info *info, int blank);
 
 /*
- * Drawing operations where framebuffer is in I/O memory
+ * Helpers for framebuffers in I/O memory
  */
 
 extern void cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -540,10 +540,6 @@ extern ssize_t fb_io_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 			   size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in I/O memory.
- */
-
 #define __FB_DEFAULT_IO_OPS_RDWR \
 	.fb_read	= fb_io_read, \
 	.fb_write	= fb_io_write
@@ -562,7 +558,7 @@ extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 	__FB_DEFAULT_IO_OPS_MMAP
 
 /*
- * Drawing operations where framebuffer is in system RAM
+ * Helpers for framebuffers in system memory
  */
 
 extern void sys_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -573,10 +569,6 @@ extern ssize_t fb_sys_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
 			    size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in system memory.
- */
-
 #define __FB_DEFAULT_SYS_OPS_RDWR \
 	.fb_read	= fb_sys_read, \
 	.fb_write	= fb_sys_write
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 11/11] fbdev: Harmonize some comments in <linux/fb.h>
Date: Thu,  6 Jul 2023 14:46:49 +0200	[thread overview]
Message-ID: <20230706124905.15134-12-tzimmermann@suse.de> (raw)
In-Reply-To: <20230706124905.15134-1-tzimmermann@suse.de>

Make the comments for I/O, system and DMA memory say the same.
Makes the header file's structure more obvious.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Suggested-by: Javier Martinez Canillas <javierm@redhat.com>
---
 include/linux/fb.h | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index d370f84fbca9..c8ca9c265fda 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -529,7 +529,7 @@ extern int fb_pan_display(struct fb_info *info, struct fb_var_screeninfo *var);
 extern int fb_blank(struct fb_info *info, int blank);
 
 /*
- * Drawing operations where framebuffer is in I/O memory
+ * Helpers for framebuffers in I/O memory
  */
 
 extern void cfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -540,10 +540,6 @@ extern ssize_t fb_io_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 			   size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in I/O memory.
- */
-
 #define __FB_DEFAULT_IO_OPS_RDWR \
 	.fb_read	= fb_io_read, \
 	.fb_write	= fb_io_write
@@ -562,7 +558,7 @@ extern ssize_t fb_io_write(struct fb_info *info, const char __user *buf,
 	__FB_DEFAULT_IO_OPS_MMAP
 
 /*
- * Drawing operations where framebuffer is in system RAM
+ * Helpers for framebuffers in system memory
  */
 
 extern void sys_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
@@ -573,10 +569,6 @@ extern ssize_t fb_sys_read(struct fb_info *info, char __user *buf,
 extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
 			    size_t count, loff_t *ppos);
 
-/*
- * Initializes struct fb_ops for framebuffers in system memory.
- */
-
 #define __FB_DEFAULT_SYS_OPS_RDWR \
 	.fb_read	= fb_sys_read, \
 	.fb_write	= fb_sys_write
-- 
2.41.0


  parent reply	other threads:[~2023-07-06 12:50 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 12:46 [PATCH v2 00/11] drm: Improve fbdev emulation for DMA-able framebuffers Thomas Zimmermann
2023-07-06 12:46 ` Thomas Zimmermann
2023-07-06 12:46 ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 01/11] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 02/11] drm/fbdev-dma: Use fbdev DMA helpers Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 03/11] drm/tegra: " Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 04/11] drm/tegra: Set fbdev FBINFO_VIRTFB flag Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 14:31   ` Thierry Reding
2023-07-06 14:31     ` Thierry Reding
2023-07-06 14:31     ` Thierry Reding
2023-07-06 14:47     ` Thomas Zimmermann
2023-07-06 14:47       ` Thomas Zimmermann
2023-07-06 14:47       ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 05/11] drm/exynos: Use fbdev DMA helpers Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 06/11] drm/exynos: Set fbdev FBINFO_VIRTFB flag Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-07  2:01   ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-07  2:01     ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-07  2:01     ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-06 12:46 ` [PATCH v2 07/11] drm/omapdrm: Set VM flags in GEM-object mmap function Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 08/11] drm/omapdrm: Use GEM mmap for fbdev emulation Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 09/11] drm/omapdrm: Set fbdev FBINFO_VIRTFB flag Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` [PATCH v2 10/11] fbdev: Remove FB_DEFAULT_SYS_OPS Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 12:46 ` Thomas Zimmermann [this message]
2023-07-06 12:46   ` [PATCH v2 11/11] fbdev: Harmonize some comments in <linux/fb.h> Thomas Zimmermann
2023-07-06 12:46   ` Thomas Zimmermann
2023-07-06 13:07   ` Javier Martinez Canillas
2023-07-06 13:07     ` Javier Martinez Canillas
2023-07-06 13:07     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706124905.15134-12-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.