From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>, u-boot@lists.denx.de
Subject: Re: [PATCH v3 u-boot] mmc: spl: Make partition choice in default_spl_mmc_emmc_boot_partition() more explicit
Date: Fri, 7 Jul 2023 19:43:34 -0400 [thread overview]
Message-ID: <20230707234334.GL148062@bill-the-cat> (raw)
In-Reply-To: <20230707225438.32334-1-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Sat, Jul 08, 2023 at 12:54:38AM +0200, Pali Rohár wrote:
> To make eMMC partition choosing in default_spl_mmc_emmc_boot_partition()
> function better understandable, rewrite it via explicit switch-case code
> pattern.
>
> Also indicate an error when eMMC EXT_CSD[179] register is configured by
> user to value which is not suitable for eMMC booting and SPL do not know
> how to interpret it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
I did some quick local testing to check on the size impact and this is
indeed quite manageable, thanks for reworking things!
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-07-07 23:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230703121637epcas1p38475ee827947796e877335866979abcb@epcas1p3.samsung.com>
2023-04-13 21:10 ` [PATCH u-boot 0/4] mmc: Explain and cleanup partition selection Pali Rohár
2023-04-13 21:10 ` [PATCH u-boot 1/4] mmc: spl: Make partition choice in default_spl_mmc_emmc_boot_partition() more explicit Pali Rohár
2023-07-06 17:35 ` [PATCH v2 u-boot] " Pali Rohár
2023-07-06 17:42 ` Tom Rini
2023-07-06 17:49 ` Pali Rohár
2023-07-06 17:52 ` Tom Rini
2023-07-07 16:46 ` Pali Rohár
2023-07-07 16:54 ` Tom Rini
2023-07-07 17:05 ` Pali Rohár
2023-07-07 17:10 ` Tom Rini
2023-07-07 17:56 ` Pali Rohár
2023-07-07 18:17 ` Tom Rini
2023-07-07 22:54 ` [PATCH v3 " Pali Rohár
2023-07-07 23:43 ` Tom Rini [this message]
2023-07-08 8:30 ` Pali Rohár
2023-07-08 15:28 ` Tom Rini
2023-07-09 13:08 ` Pali Rohár
2023-04-13 21:10 ` [PATCH u-boot 2/4] cmd: mvebu/bubt: Validate EXT_CSD[179] eMMC register in mmc_burn_image() Pali Rohár
2023-04-17 6:10 ` Stefan Roese
2023-04-17 7:05 ` Pali Rohár
2023-04-13 21:10 ` [PATCH u-boot 3/4] sunxi: eMMC: Add comments explaining mapping between bootpart and mmc_switch_part() Pali Rohár
2023-04-14 10:48 ` Andre Przywara
2023-04-13 21:10 ` [PATCH u-boot 4/4] board: purism: Use U-Boot mmc function for converting boot part to part access Pali Rohár
2023-04-16 15:00 ` Angus Ainslie
2023-07-03 12:16 ` [PATCH u-boot 0/4] mmc: Explain and cleanup partition selection Jaehoon Chung
2023-07-06 10:50 ` Pali Rohár
2023-07-06 17:39 ` Pali Rohár
2023-07-06 22:53 ` Jaehoon Chung
2023-07-06 22:57 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707234334.GL148062@bill-the-cat \
--to=trini@konsulko.com \
--cc=jh80.chung@samsung.com \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.