From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Wen Xiong <wenxiong@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues
Date: Mon, 10 Jul 2023 08:41:09 +0200 [thread overview]
Message-ID: <20230710064109.GB24519@lst.de> (raw)
In-Reply-To: <20230708020259.1343736-3-ming.lei@redhat.com>
On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote:
> Take blk-mq's knowledge into account for calculating io queues.
>
> Fix wrong queue mapping in case of kdump kernel.
>
> On arm and ppc64, 'maxcpus=1' is passed to kdump command line, see
> `Documentation/admin-guide/kdump/kdump.rst`, so num_possible_cpus()
> still returns all CPUs.
That's simply broken. Please fix the arch code to make sure
it does not return a bogus num_possible_cpus value for these
setups, otherwise you'll have to paper over it in all kind of
drivers.
next prev parent reply other threads:[~2023-07-10 6:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 2:02 [PATCH 0/2] blk-mq & nvme-pci: fix io failure in kdump kernel Ming Lei
2023-07-08 2:02 ` [PATCH 1/2] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-07-08 2:02 ` [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues Ming Lei
2023-07-10 6:41 ` Christoph Hellwig [this message]
2023-07-10 9:14 ` Ming Lei
2023-07-10 9:14 ` Ming Lei
2023-07-10 9:14 ` Ming Lei
2023-07-10 9:14 ` Ming Lei
2023-07-10 16:51 ` Keith Busch
2023-07-10 16:51 ` Keith Busch
2023-07-10 16:51 ` Keith Busch
2023-07-10 16:51 ` Keith Busch
2023-07-11 1:33 ` Ming Lei
2023-07-11 1:33 ` Ming Lei
2023-07-11 1:33 ` Ming Lei
2023-07-11 1:33 ` Ming Lei
2023-07-11 3:35 ` Baoquan He
2023-07-11 3:35 ` Baoquan He
2023-07-11 3:35 ` Baoquan He
2023-07-11 3:35 ` Baoquan He
2023-07-11 3:53 ` Ming Lei
2023-07-11 3:53 ` Ming Lei
2023-07-11 3:53 ` Ming Lei
2023-07-11 3:53 ` Ming Lei
2023-07-11 6:59 ` Baoquan He
2023-07-11 6:59 ` Baoquan He
2023-07-11 6:59 ` Baoquan He
2023-07-11 6:59 ` Baoquan He
2023-07-11 3:55 ` Pingfan Liu
2023-07-11 3:55 ` Pingfan Liu
2023-07-11 3:55 ` Pingfan Liu
2023-07-11 3:55 ` Pingfan Liu
2023-07-11 4:05 ` Pingfan Liu
2023-07-11 4:05 ` Pingfan Liu
2023-07-11 4:05 ` Pingfan Liu
2023-07-11 4:05 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710064109.GB24519@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.