From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com
Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-sh@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, linux-geode@lists.infradead.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-input@vger.kernel.org, linux-nvidia@lists.surfsouth.com,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH 12/17] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Date: Mon, 10 Jul 2023 14:50:16 +0200 [thread overview]
Message-ID: <20230710130113.14563-13-tzimmermann@suse.de> (raw)
In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de>
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
Flags should signal differences from the default values. After cleaning
up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
drivers/staging/sm750fb/sm750.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3a4abf3bae40..eac1d570f437 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
info->var.transp.offset = 0;
info->var.transp.length = 0;
- info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
+ info->flags = FBINFO_VIRTFB;
par = info->par;
par->info = info;
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c260f73cf570..79bcd5bd4938 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
info->screen_base = crtc->v_screen;
pr_debug("screen_base vaddr = %p\n", info->screen_base);
info->screen_size = line_length * var->yres_virtual;
- info->flags = FBINFO_FLAG_DEFAULT | 0;
/* set info->fix */
fix->type = FB_TYPE_PACKED_PIXELS;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org,
linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: [PATCH 12/17] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Date: Mon, 10 Jul 2023 14:50:16 +0200 [thread overview]
Message-ID: <20230710130113.14563-13-tzimmermann@suse.de> (raw)
In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de>
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
Flags should signal differences from the default values. After cleaning
up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
drivers/staging/sm750fb/sm750.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3a4abf3bae40..eac1d570f437 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
info->var.transp.offset = 0;
info->var.transp.length = 0;
- info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
+ info->flags = FBINFO_VIRTFB;
par = info->par;
par->info = info;
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c260f73cf570..79bcd5bd4938 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
info->screen_base = crtc->v_screen;
pr_debug("screen_base vaddr = %p\n", info->screen_base);
info->screen_size = line_length * var->yres_virtual;
- info->flags = FBINFO_FLAG_DEFAULT | 0;
/* set info->fix */
fix->type = FB_TYPE_PACKED_PIXELS;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org,
linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: [PATCH 12/17] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Date: Mon, 10 Jul 2023 14:50:16 +0200 [thread overview]
Message-ID: <20230710130113.14563-13-tzimmermann@suse.de> (raw)
In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de>
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
Flags should signal differences from the default values. After cleaning
up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
drivers/staging/sm750fb/sm750.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3a4abf3bae40..eac1d570f437 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -684,7 +684,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
info->var.transp.offset = 0;
info->var.transp.length = 0;
- info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;
+ info->flags = FBINFO_VIRTFB;
par = info->par;
par->info = info;
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c260f73cf570..79bcd5bd4938 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -807,7 +807,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
info->screen_base = crtc->v_screen;
pr_debug("screen_base vaddr = %p\n", info->screen_base);
info->screen_size = line_length * var->yres_virtual;
- info->flags = FBINFO_FLAG_DEFAULT | 0;
/* set info->fix */
fix->type = FB_TYPE_PACKED_PIXELS;
--
2.41.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-10 13:01 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 12:50 [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 01/17] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 02/17] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 03/17] " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 04/17] " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 05/17] " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 06/17] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 07/17] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 13:42 ` John Paul Adrian Glaubitz
2023-07-10 13:42 ` John Paul Adrian Glaubitz
2023-07-10 13:42 ` John Paul Adrian Glaubitz
2023-07-10 13:52 ` Thomas Zimmermann
2023-07-10 13:52 ` Thomas Zimmermann
2023-07-10 13:52 ` Thomas Zimmermann
2023-07-10 13:59 ` John Paul Adrian Glaubitz
2023-07-10 13:59 ` John Paul Adrian Glaubitz
2023-07-10 13:59 ` John Paul Adrian Glaubitz
2023-07-10 14:04 ` Thomas Zimmermann
2023-07-10 14:04 ` Thomas Zimmermann
2023-07-10 14:04 ` Thomas Zimmermann
2023-07-10 14:08 ` John Paul Adrian Glaubitz
2023-07-10 14:08 ` John Paul Adrian Glaubitz
2023-07-10 14:08 ` John Paul Adrian Glaubitz
2023-07-10 12:50 ` [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 14:24 ` Miguel Ojeda
2023-07-10 14:24 ` Miguel Ojeda
2023-07-10 14:24 ` Miguel Ojeda
2023-07-10 15:22 ` Thomas Zimmermann
2023-07-10 15:22 ` Thomas Zimmermann
2023-07-10 15:22 ` Thomas Zimmermann
2023-07-10 16:25 ` Miguel Ojeda
2023-07-10 16:25 ` Miguel Ojeda
2023-07-10 16:25 ` Miguel Ojeda
2023-07-11 6:10 ` Thomas Zimmermann
2023-07-11 6:10 ` Thomas Zimmermann
2023-07-11 6:10 ` Thomas Zimmermann
2023-07-11 10:03 ` Miguel Ojeda
2023-07-11 10:03 ` Miguel Ojeda
2023-07-11 10:03 ` Miguel Ojeda
2023-07-10 12:50 ` [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 13:05 ` Benjamin Tissoires
2023-07-10 13:05 ` Benjamin Tissoires
2023-07-10 13:05 ` Benjamin Tissoires
2023-07-12 9:43 ` Bruno Prémont
2023-07-12 9:43 ` Bruno Prémont
2023-07-12 9:43 ` Bruno Prémont
2023-07-10 12:50 ` [PATCH 11/17] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann [this message]
2023-07-10 12:50 ` [PATCH 12/17] staging: " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 13/17] fbdev: " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 14/17] " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 15/17] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 16/17] fbdev/pxafb: " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 17/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann
2023-07-10 17:19 ` [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Sam Ravnborg
2023-07-10 17:19 ` Sam Ravnborg
2023-07-10 17:19 ` Sam Ravnborg
2023-07-11 6:24 ` Thomas Zimmermann
2023-07-11 6:24 ` Thomas Zimmermann
2023-07-11 6:24 ` Thomas Zimmermann
2023-07-11 14:47 ` Sam Ravnborg
2023-07-11 14:47 ` Sam Ravnborg
2023-07-11 14:47 ` Sam Ravnborg
2023-07-11 15:24 ` Helge Deller
2023-07-11 15:24 ` Helge Deller
2023-07-11 15:24 ` Helge Deller
2023-07-11 16:04 ` Geert Uytterhoeven
2023-07-11 16:04 ` Geert Uytterhoeven
2023-07-11 16:04 ` Geert Uytterhoeven
2023-07-12 6:44 ` Thomas Zimmermann
2023-07-12 6:44 ` Thomas Zimmermann
2023-07-12 6:44 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710130113.14563-13-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.