All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] signal: remove duplicate include header in signal.c
@ 2023-07-10  7:23 ye.xingchen
  2023-07-10 10:11 ` Haifeng Xu
  0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2023-07-10  7:23 UTC (permalink / raw)
  To: rafael.j.wysocki
  Cc: peterz, ebiederm, elver, tglx, michael.christie, haifeng.xu, viro,
	mcgrof, dvyukov, vincent.whitchurch, linux-kernel

From: Ye Xingchen <ye.xingchen@zte.com.cn>

linux/file.h is included more than once.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 kernel/signal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 9a3ff8157ceb..b1da4e81bde6 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -25,7 +25,6 @@
 #include <linux/mm.h>
 #include <linux/proc_fs.h>
 #include <linux/tty.h>
-#include <linux/file.h>
 #include <linux/binfmts.h>
 #include <linux/coredump.h>
 #include <linux/security.h>
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] signal: remove duplicate include header in signal.c
  2023-07-10  7:23 [PATCH] signal: remove duplicate include header in signal.c ye.xingchen
@ 2023-07-10 10:11 ` Haifeng Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Haifeng Xu @ 2023-07-10 10:11 UTC (permalink / raw)
  To: ye.xingchen, rafael.j.wysocki
  Cc: peterz, ebiederm, elver, tglx, michael.christie, viro, mcgrof,
	dvyukov, vincent.whitchurch, linux-kernel

On 2023/7/10 15:23, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?

Thanks, Haifeng.

> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
>  #include <linux/mm.h>
>  #include <linux/proc_fs.h>
>  #include <linux/tty.h>
> -#include <linux/file.h>
>  #include <linux/binfmts.h>
>  #include <linux/coredump.h>
>  #include <linux/security.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-10 10:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10  7:23 [PATCH] signal: remove duplicate include header in signal.c ye.xingchen
2023-07-10 10:11 ` Haifeng Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.