[amir73il:start-write-safe 4/6] fs/nfsd/vfs.c:1031:20: error: implicit declaration of function 'file_access_permission'; did you mean 'file_permission'?

[amir73il:start-write-safe 4/6] fs/nfsd/vfs.c:1031:20: error: implicit declaration of function 'file_access_permission'; did you mean 'file_permission'?

[kernel test robot]

tree:   https://github.com/amir73il/linux start-write-safe
head:   dee92d97ca4a2052cddcf1875441bdbe30e50b13
commit: 28373848f0ca3bbfb2c00e4b210d8b498d145d98 [4/6] splice: move permission hook out of splice_direct_to_actor()
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20230711/202307111306.ZDSbRFMG-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230711/202307111306.ZDSbRFMG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307111306.ZDSbRFMG-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/nfsd/vfs.c: In function 'nfsd_splice_read':
>> fs/nfsd/vfs.c:1031:20: error: implicit declaration of function 'file_access_permission'; did you mean 'file_permission'? [-Werror=implicit-function-declaration]
    1031 |         host_err = file_access_permission(file, MAY_READ);
         |                    ^~~~~~~~~~~~~~~~~~~~~~
         |                    file_permission
   cc1: some warnings being treated as errors


vim +1031 fs/nfsd/vfs.c

  1005	
  1006	/**
  1007	 * nfsd_splice_read - Perform a VFS read using a splice pipe
  1008	 * @rqstp: RPC transaction context
  1009	 * @fhp: file handle of file to be read
  1010	 * @file: opened struct file of file to be read
  1011	 * @offset: starting byte offset
  1012	 * @count: IN: requested number of bytes; OUT: number of bytes read
  1013	 * @eof: OUT: set non-zero if operation reached the end of the file
  1014	 *
  1015	 * Returns nfs_ok on success, otherwise an nfserr stat value is
  1016	 * returned.
  1017	 */
  1018	__be32 nfsd_splice_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
  1019				struct file *file, loff_t offset, unsigned long *count,
  1020				u32 *eof)
  1021	{
  1022		struct splice_desc sd = {
  1023			.len		= 0,
  1024			.total_len	= *count,
  1025			.pos		= offset,
  1026			.u.data		= rqstp,
  1027		};
  1028		ssize_t host_err;
  1029	
  1030		trace_nfsd_read_splice(rqstp, fhp, offset, *count);
> 1031		host_err = file_access_permission(file, MAY_READ);
  1032		if (!host_err)
  1033			host_err = splice_direct_to_actor(file, &sd,
  1034							  nfsd_direct_splice_actor);
  1035		return nfsd_finish_read(rqstp, fhp, file, offset, count, eof, host_err);
  1036	}
  1037	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki