* [PATCH] roms: add back edk2-basetools target
@ 2023-04-11 10:17 Gerd Hoffmann
2023-04-11 10:26 ` Olaf Hering
2023-07-12 8:20 ` Olaf Hering
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2023-04-11 10:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Olaf Hering
The efi nic boot rom builds depend on this, they need the
EfiRom utility from edk2 BaseTools.
Fixes: 22e11539e167 ("edk2: replace build scripts")
Reported-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
roms/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/roms/Makefile b/roms/Makefile
index 6859685290bf..73127445a515 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -153,6 +153,9 @@ efi:
rm -f ../pc-bios/edk2-*.fd.bz2
bzip2 --verbose ../pc-bios/edk2-*.fd
+edk2-basetools:
+ python3 edk2-build.py --config edk2-build.config -m none
+
opensbi32-generic:
$(MAKE) -C opensbi \
CROSS_COMPILE=$(riscv32_cross_prefix) \
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] roms: add back edk2-basetools target
2023-04-11 10:17 [PATCH] roms: add back edk2-basetools target Gerd Hoffmann
@ 2023-04-11 10:26 ` Olaf Hering
2023-04-11 10:53 ` Gerd Hoffmann
2023-07-12 8:20 ` Olaf Hering
1 sibling, 1 reply; 4+ messages in thread
From: Olaf Hering @ 2023-04-11 10:26 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <kraxel@redhat.com>:
> + python3 edk2-build.py --config edk2-build.config -m none
Is '-m none' correct?
I think previously the result was just a native build.
Now that introduced .config attempts cross builds.
Maybe that detail must be mentioned in the release notes, and the build requirements.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] roms: add back edk2-basetools target
2023-04-11 10:17 [PATCH] roms: add back edk2-basetools target Gerd Hoffmann
2023-04-11 10:26 ` Olaf Hering
@ 2023-07-12 8:20 ` Olaf Hering
1 sibling, 0 replies; 4+ messages in thread
From: Olaf Hering @ 2023-07-12 8:20 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <kraxel@redhat.com>:
> +++ b/roms/Makefile
> +edk2-basetools:
> + python3 edk2-build.py --config edk2-build.config -m none
I think that needs to be $(PYTHON), because plain 'python3' may not be the required python version.
In addition, a global EDK2_OPTIONS may allow to pass arbitrary options to their build wrapper, like -j1.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-12 8:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-11 10:17 [PATCH] roms: add back edk2-basetools target Gerd Hoffmann
2023-04-11 10:26 ` Olaf Hering
2023-04-11 10:53 ` Gerd Hoffmann
2023-07-12 8:20 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.