From: Jakub Kicinski <kuba@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Ma Yuying <yuma@redhat.com>, Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Simon Horman <simon.horman@corigine.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v2 1/2] i40e: Add helper for VF inited state check with timeout
Date: Wed, 12 Jul 2023 12:36:13 -0700 [thread overview]
Message-ID: <20230712123613.20a98732@kernel.org> (raw)
In-Reply-To: <20230712133247.588636-1-ivecera@redhat.com>
On Wed, 12 Jul 2023 15:32:46 +0200 Ivan Vecera wrote:
> + for (i = 0; i < 15; i++)
> + if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
> + msleep(20);
> +
> + if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
> + dev_err(&vf->pf->pdev->dev,
> + "VF %d still in reset. Try again.\n", vf->vf_id);
> + return false;
I like my loop more but if you want to have the msleep() indented just
add an else { return true; } branch. Take advantage of the fact this is
a function, now, and you can just return.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, Simon Horman <simon.horman@corigine.com>,
Rafal Romanowski <rafal.romanowski@intel.com>,
Leon Romanovsky <leon@kernel.org>, Ma Yuying <yuma@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET
DRIVERS), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v2 1/2] i40e: Add helper for VF inited state check with timeout
Date: Wed, 12 Jul 2023 12:36:13 -0700 [thread overview]
Message-ID: <20230712123613.20a98732@kernel.org> (raw)
In-Reply-To: <20230712133247.588636-1-ivecera@redhat.com>
On Wed, 12 Jul 2023 15:32:46 +0200 Ivan Vecera wrote:
> + for (i = 0; i < 15; i++)
> + if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
> + msleep(20);
> +
> + if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
> + dev_err(&vf->pf->pdev->dev,
> + "VF %d still in reset. Try again.\n", vf->vf_id);
> + return false;
I like my loop more but if you want to have the msleep() indented just
add an else { return true; } branch. Take advantage of the fact this is
a function, now, and you can just return.
next prev parent reply other threads:[~2023-07-12 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:32 [Intel-wired-lan] [PATCH v2 1/2] i40e: Add helper for VF inited state check with timeout Ivan Vecera
2023-07-12 13:32 ` Ivan Vecera
2023-07-12 13:32 ` [Intel-wired-lan] [PATCH v2 2/2] i40e: Wait for pending VF reset in VF set callbacks Ivan Vecera
2023-07-12 13:32 ` Ivan Vecera
2023-07-12 19:36 ` Jakub Kicinski [this message]
2023-07-12 19:36 ` [PATCH v2 1/2] i40e: Add helper for VF inited state check with timeout Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712123613.20a98732@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yuma@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.