[OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Piotr Łobacz]

Include support for ACLs and extended file attributes for native
builds, depending on which distro target features has been turned
on.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 meta/conf/bitbake.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 9625a6fef4..20684a5126 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -904,12 +904,12 @@ IMAGE_FEATURES += "${EXTRA_IMAGE_FEATURES}"
 
 # Native distro features (will always be used for -native, even if they
 # are not enabled for target)
-DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr"
+DISTRO_FEATURES_NATIVE ?= "x11 ipv6"
 DISTRO_FEATURES_NATIVESDK ?= "x11"
 
 # Normally target distro features will not be applied to native builds:
 # Native distro features on this list will use the target feature value
-DISTRO_FEATURES_FILTER_NATIVE ?= "api-documentation debuginfod opengl wayland"
+DISTRO_FEATURES_FILTER_NATIVE ?= "acl api-documentation debuginfod opengl wayland xattr"
 DISTRO_FEATURES_FILTER_NATIVESDK ?= "api-documentation debuginfod opengl wayland"
 
 DISTRO_FEATURES_BACKFILL = "pulseaudio sysvinit gobject-introspection-data ldconfig"
-- 
2.34.1

[OE-Core][PATCH v4 2/5] package_ipk.bbclass: add support for ACLs and xattr

[Piotr Łobacz]

Extend OPKGBUILDCMD variable, with additional parameters, depending
on target distro features, in order to support ACLs and xattr.

With fix pushed to the opkg-devel:
https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8
opkg-build is able to create tar archives with ACLs and xattr.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 meta/classes-global/package_ipk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
index b4b7bc9ac2..5e151be3cd 100644
--- a/meta/classes-global/package_ipk.bbclass
+++ b/meta/classes-global/package_ipk.bbclass
@@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
 PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
 
 # Program to be used to build opkg packages
-OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
+OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
 
 OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
 OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
-- 
2.34.1

[OE-Core][PATCH v4 3/5] package.bbclass: add support for ACLs and xattr

[Piotr Łobacz]

Extend `tar` command, with additional parameters, depending
on choosen package class and target distro features, in order
to support ACLs and xattr.

Currently only `package_ipk` supports fully ACLs and xattr.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 meta/classes-global/package.bbclass | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass
index e8055a9cdc..6e5d0dd4dc 100644
--- a/meta/classes-global/package.bbclass
+++ b/meta/classes-global/package.bbclass
@@ -342,8 +342,13 @@ python perform_packagecopy () {
 
     # Start by package population by taking a copy of the installed
     # files to operate on
-    # Preserve sparse files and hard links
-    cmd = 'tar --exclude=./sysroot-only -cf - -C %s -p -S . | tar -xf - -C %s' % (dest, dvar)
+    # Preserve sparse files, hard links, ACLs and extended attributes
+    # TODO: for the moment only ipk packages are supporting ACLs and extended attributes
+    # we need to add support for other package systems as well, but that doesn't bother
+    # tar from creating archives with acl and/or xattr support
+    acl = bb.utils.contains('DISTRO_FEATURES', 'acl', '--acls', '', d)
+    xattr = bb.utils.contains('DISTRO_FEATURES', 'xattr', '--xattrs', '', d)
+    cmd = f'tar {acl} {xattr} --numeric-owner --exclude=./sysroot-only -cf - -C {dest} -p -S . | tar {acl} {xattr} -xf - -C {dvar}'
     subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
     # replace RPATHs for the nativesdk binaries, to make them relocatable
-- 
2.34.1

[OE-Core][PATCH v4 4/5] opkg-utils: add acl and xattr support

[Piotr Łobacz]

Add support for tar archives created with --acls and/or --xattrs options,
PAX header format.

GNU tar and libarchive already supports ACLs and extended attributes.
We can now add this support as well to opkg-build script in order to use
fsetattr or setcap inside do_install command and end up with a file in
an image with the relevant ACLs and xattrs.

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 ...kg-build-Add-acls-and-xattrs-support.patch | 80 +++++++++++++++++++
 .../opkg-utils/opkg-utils_0.5.0.bb            |  1 +
 2 files changed, 81 insertions(+)
 create mode 100644 meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch

diff --git a/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch b/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch
new file mode 100644
index 0000000000..a9e5f0e191
--- /dev/null
+++ b/meta/recipes-devtools/opkg-utils/opkg-utils/0002-opkg-build-Add-acls-and-xattrs-support.patch
@@ -0,0 +1,80 @@
+From 5664c17923cc1ab9644ef01f549bc8d352dd8868 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Piotr=20=C5=81obacz?= <p.lobacz@welotec.com>
+Date: Wed, 5 Jul 2023 10:31:13 +0200
+Subject: [PATCH] opkg-build: Add acls and xattrs support
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Add support for tar archives created with --acls and/or --xattrs options,
+PAX header format.
+
+GNU tar and libarchive already supports ACLs and extended attributes.
+We can now add this support as well to opkg-build script in order to use
+fsetattr or setcap inside do_install command and end up with a file in
+an image with the relevant ACLs and xattrs.
+
+Upstream-Status: Accepted [https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8]
+
+[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=15097
+[2] https://groups.google.com/g/opkg-devel/c/aEGL7XRXfaA
+
+Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
+---
+ opkg-build | 15 ++++++++++-----
+ 1 file changed, 10 insertions(+), 5 deletions(-)
+
+diff --git a/opkg-build b/opkg-build
+index a9e45d4..8d9bcfa 100755
+--- a/opkg-build
++++ b/opkg-build
+@@ -145,6 +145,7 @@ You probably want to chown these to a system user: " >&2
+ ###
+ # opkg-build "main"
+ ###
++attributesargs=""
+ ogargs=""
+ outer=ar
+ noclean=0
+@@ -166,7 +167,7 @@ compressorargs=""
+ tarformat=""
+ if tar --help 2>&1 | grep -- "--format" > /dev/null;
+ then
+-    tarformat="--format=gnu"
++    tarformat="--format=posix"
+ fi
+ 
+ compressor_ext() {
+@@ -197,13 +198,17 @@ compressor_ext() {
+ : <<=cut
+ =head1 SYNOPSIS
+ 
+-B<opkg-build> [B<-c>] [B<-C>] [B<-Z> I<compressor>] [B<-a>] [B<-O>] [B<-o> I<owner>] [B<-g> I<group>] I<pkg_directory> [I<destination_directory>]
++B<opkg-build> [B<-A>] [B<-X>] [B<-c>] [B<-C>] [B<-Z> I<compressor>] [B<-a>] [B<-O>] [B<-o> I<owner>] [B<-g> I<group>] I<pkg_directory> [I<destination_directory>]
+ 
+ =cut
+ 
+-usage="Usage: $0 [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]"
+-while getopts "a:cCg:ho:vOZ:" opt; do
++usage="Usage: $0 [-A] [-X] [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]"
++while getopts "Aa:cCg:ho:vOXZ:" opt; do
+     case $opt in
++        A ) attributesargs="--acls"
++            ;;
++        X ) attributesargs="$attributesargs --xattrs"
++            ;;
+ 	o ) owner=$OPTARG
+ 	    ogargs="--owner=$owner"
+ 	    ;;
+@@ -314,7 +319,7 @@ export LANG=C
+ export LC_ALL=C
+ ( cd $pkg_dir/$CONTROL && find . -type f | sort > $tmp_dir/control_list )
+ ( cd $pkg_dir && find . -path ./$CONTROL -prune -o -path . -o -print  | sort > $tmp_dir/file_list )
+-( cd $pkg_dir && tar $ogargs $tsortargs --no-recursion $mtime_args -c $tarformat -T $tmp_dir/file_list | $compressor $compressorargs > $tmp_dir/data.tar.$cext )
++( cd $pkg_dir && tar $attributesargs $ogargs $tsortargs --no-recursion $mtime_args -c $tarformat -T $tmp_dir/file_list | $compressor $compressorargs > $tmp_dir/data.tar.$cext )
+ ( cd $pkg_dir/$CONTROL && tar $ogargs $tsortargs --no-recursion --mtime=@$build_date -c $tarformat -T $tmp_dir/control_list | gzip $zipargs > $tmp_dir/control.tar.gz )
+ rm $tmp_dir/file_list
+ rm $tmp_dir/control_list
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb b/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb
index b27e3ded33..edf730711e 100644
--- a/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb
+++ b/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb
@@ -9,6 +9,7 @@ PROVIDES += "${@bb.utils.contains('PACKAGECONFIG', 'update-alternatives', 'virtu
 
 SRC_URI = "git://git.yoctoproject.org/opkg-utils;protocol=https;branch=master \
            file://0001-update-alternatives-correctly-match-priority.patch \
+           file://0002-opkg-build-Add-acls-and-xattrs-support.patch \
            "
 SRCREV = "9239541f14a2529b9d01c0a253ab11afa2822dab"
 
-- 
2.34.1

[OE-Core][PATCH v4 5/5] opkg: add options to enable support for acl and xattr

[Piotr Łobacz]

The libarchive library, which is being used by opkg, supports ACLs
and xattr already.

More informations can be read at this link:
https://github.com/libarchive/libarchive/pull/691

Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
---
 ...-to-enable-support-for-acl-and-xattr.patch | 70 +++++++++++++++++++
 meta/recipes-devtools/opkg/opkg_0.6.1.bb      |  5 +-
 2 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch

diff --git a/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch b/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch
new file mode 100644
index 0000000000..d6cb1d79fb
--- /dev/null
+++ b/meta/recipes-devtools/opkg/opkg/0002-Add-options-to-enable-support-for-acl-and-xattr.patch
@@ -0,0 +1,70 @@
+From 1c935e994bd572d9fff436f660ac1a060a434df0 Mon Sep 17 00:00:00 2001
+From: Maciej Liszewski <m.liszewski@welotec.com>
+Date: Tue, 4 Jul 2023 22:01:58 +0200
+Subject: [PATCH] Add options to enable support for acl and xattr
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The libarchive library, which is being used by opkg, supports ACLs
+and xattr already.
+
+More informations can be read at this link:
+https://github.com/libarchive/libarchive/pull/691
+
+Upstream-Status: Accepted [https://groups.google.com/g/opkg-devel/c/aEGL7XRXfaA]
+
+[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=15097
+
+Signed-off-by: Maciej Liszewski <m.liszewski@welotec.com>
+Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
+---
+ configure.ac           | 12 ++++++++++++
+ libopkg/opkg_archive.c |  8 ++++++++
+ 2 files changed, 20 insertions(+)
+
+diff --git a/configure.ac b/configure.ac
+index 389a818..46949cd 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -158,6 +158,18 @@ return OPENSSL_VERSION_NUMBER; ],
+   AC_SUBST(OPENSSL_LIBS)
+ fi
+ 
++# check for ACL support
++AC_ARG_WITH([acl], [AS_HELP_STRING([--with-acl], [Enable ACL support])])
++if test "x$with_acl" = "xyes"; then
++  AC_DEFINE([ENABLE_ACL], [1], [Enable ACL support])
++fi
++
++# check for xattr support
++AC_ARG_WITH([xattr], [AS_HELP_STRING([--with-xattr], [Enable xattr support])])
++if test "x$with_xattr" = "xyes"; then
++  AC_DEFINE([ENABLE_XATTR], [1], [Enable xattr support])
++fi
++
+ # check for libsolv solver
+ AC_ARG_WITH(libsolv, AC_HELP_STRING([--with-libsolv], [Use libsolv solver support.
+   ]), [], [with_libsolv="no"])
+diff --git a/libopkg/opkg_archive.c b/libopkg/opkg_archive.c
+index 03a4afb..8dd902d 100644
+--- a/libopkg/opkg_archive.c
++++ b/libopkg/opkg_archive.c
+@@ -912,6 +912,14 @@ struct opkg_ar *ar_open_pkg_data_archive(const char *filename)
+     ar->extract_flags = ARCHIVE_EXTRACT_OWNER | ARCHIVE_EXTRACT_PERM |
+         ARCHIVE_EXTRACT_TIME | ARCHIVE_EXTRACT_UNLINK | ARCHIVE_EXTRACT_NO_OVERWRITE;
+ 
++#ifdef ENABLE_ACL
++    ar->extract_flags |= ARCHIVE_EXTRACT_ACL;
++#endif
++
++#ifdef ENABLE_XATTR
++    ar->extract_flags |= ARCHIVE_EXTRACT_FFLAGS | ARCHIVE_EXTRACT_XATTR;
++#endif
++
+     if (opkg_config->ignore_uid)
+         ar->extract_flags &= ~ARCHIVE_EXTRACT_OWNER;
+ 
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/opkg/opkg_0.6.1.bb b/meta/recipes-devtools/opkg/opkg_0.6.1.bb
index 4c25fe963a..2cac4af644 100644
--- a/meta/recipes-devtools/opkg/opkg_0.6.1.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.6.1.bb
@@ -17,6 +17,7 @@ SRC_URI = "http://downloads.yoctoproject.org/releases/${BPN}/${BPN}-${PV}.tar.gz
            file://0001-opkg_conf-create-opkg.lock-in-run-instead-of-var-run.patch \
            file://0002-opkg-key-remove-no-options-flag-from-gpg-calls.patch \
            file://0001-Define-alignof-using-_Alignof-when-using-C11-or-newe.patch \
+           file://0002-Add-options-to-enable-support-for-acl-and-xattr.patch \
            file://run-ptest \
 "
 
@@ -32,8 +33,10 @@ inherit autotools pkgconfig ptest
 target_localstatedir := "${localstatedir}"
 OPKGLIBDIR ??= "${target_localstatedir}/lib"
 
-PACKAGECONFIG ??= "libsolv"
+PACKAGECONFIG ??= "libsolv ${@bb.utils.filter('DISTRO_FEATURES', 'acl xattr', d)}"
 
+PACKAGECONFIG[acl] = "--with-acl,--without-acl"
+PACKAGECONFIG[xattr] = "--with-xattr,--without-xattr"
 PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,\
     gnupg gpgme libgpg-error,\
     ${@ "gnupg" if ("native" in d.getVar("PN")) else "gnupg-gpg"}\
-- 
2.34.1

Re: [OE-Core][PATCH v4 2/5] package_ipk.bbclass: add support for ACLs and xattr

[Alexandre Belloni]

I tested a previous version and got:

ERROR: run-postinsts-1.0-r10 do_package_write_ipk: Fatal errors occurred in subprocesses:
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts-dev /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts-dbg /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]


any chance this is solved in v4?

On 12/07/2023 14:25:55+0200, Piotr Łobacz wrote:
> Extend OPKGBUILDCMD variable, with additional parameters, depending
> on target distro features, in order to support ACLs and xattr.
> 
> With fix pushed to the opkg-devel:
> https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8
> opkg-build is able to create tar archives with ACLs and xattr.
> 
> Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> ---
>  meta/classes-global/package_ipk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> index b4b7bc9ac2..5e151be3cd 100644
> --- a/meta/classes-global/package_ipk.bbclass
> +++ b/meta/classes-global/package_ipk.bbclass
> @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
>  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
>  
>  # Program to be used to build opkg packages
> -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
>  
>  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
>  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> -- 
> 2.34.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184190): https://lists.openembedded.org/g/openembedded-core/message/184190
> Mute This Topic: https://lists.openembedded.org/mt/100098284/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Richard Purdie]

On Wed, 2023-07-12 at 14:25 +0200, Piotr Łobacz wrote:
> Include support for ACLs and extended file attributes for native
> builds, depending on which distro target features has been turned
> on.
> 
> Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> ---
>  meta/conf/bitbake.conf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 9625a6fef4..20684a5126 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -904,12 +904,12 @@ IMAGE_FEATURES += "${EXTRA_IMAGE_FEATURES}"
>  
>  # Native distro features (will always be used for -native, even if they
>  # are not enabled for target)
> -DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr"
> +DISTRO_FEATURES_NATIVE ?= "x11 ipv6"
>  DISTRO_FEATURES_NATIVESDK ?= "x11"
>  
>  # Normally target distro features will not be applied to native builds:
>  # Native distro features on this list will use the target feature value
> -DISTRO_FEATURES_FILTER_NATIVE ?= "api-documentation debuginfod opengl wayland"
> +DISTRO_FEATURES_FILTER_NATIVE ?= "acl api-documentation debuginfod opengl wayland xattr"
>  DISTRO_FEATURES_FILTER_NATIVESDK ?= "api-documentation debuginfod opengl wayland"
>  
>  DISTRO_FEATURES_BACKFILL = "pulseaudio sysvinit gobject-introspection-data ldconfig"

Just to be clear, I know what Alex said but after further thought, acl
needs to move into DISTRO_FEATURES_NATIVE in my opinion (and Ross'
too).

I suspect Alex will agree with that too after thinking about the
arguments I put forward about simplifying sstate reuse.

Cheers,

Richard

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Alexander Kanavin]

On Wed, 12 Jul 2023 at 19:04, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Just to be clear, I know what Alex said but after further thought, acl
> needs to move into DISTRO_FEATURES_NATIVE in my opinion (and Ross'
> too).
>
> I suspect Alex will agree with that too after thinking about the
> arguments I put forward about simplifying sstate reuse.

My comment was strictly about using the best syntactic sugar, and not
about the merits of conditional (or not) enabling of these features.
I'm fine if they're always enabled.

Alex

ODP: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

OK, I have set in v5 patches set, these acl and xattr attributes by default in DISTRO_FEATURES_NATIVE, without any checks, if it exists in DISTRO_FEATURES. Is that ok for all of you?

BR
Piotr
________________________________
Od: Alexander Kanavin <alex.kanavin@gmail.com>
Wysłane: środa, 12 lipca 2023 19:15
Do: Richard Purdie <richard.purdie@linuxfoundation.org>
DW: Piotr Łobacz <p.lobacz@welotec.com>; openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

On Wed, 12 Jul 2023 at 19:04, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Just to be clear, I know what Alex said but after further thought, acl
> needs to move into DISTRO_FEATURES_NATIVE in my opinion (and Ross'
> too).
>
> I suspect Alex will agree with that too after thinking about the
> arguments I put forward about simplifying sstate reuse.

My comment was strictly about using the best syntactic sugar, and not
about the merits of conditional (or not) enabling of these features.
I'm fine if they're always enabled.

Alex

[-- Attachment #2: Type: text/html, Size: 2530 bytes --]

ODP: [OE-Core][PATCH v4 2/5] package_ipk.bbclass: add support for ACLs and xattr

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 9369 bytes --]

HI Alex,
this is odd because that is not happening for me... I need to do some checks.

BR
Piotr
________________________________
Od: Alexandre Belloni <alexandre.belloni@bootlin.com>
Wysłane: środa, 12 lipca 2023 18:54
Do: Piotr Łobacz <p.lobacz@welotec.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH v4 2/5] package_ipk.bbclass: add support for ACLs and xattr

I tested a previous version and got:

ERROR: run-postinsts-1.0-r10 do_package_write_ipk: Fatal errors occurred in subprocesses:
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts-dev /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]
Command 'PATH="/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/scripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/allarch-poky-linux:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot/usr/bin/crossscripts:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/sbin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/bin:/home/pokybuild/yocto-worker/poky-tiny/build/bitbake/bin:/home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/hosttools" opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" run-postinsts-dbg /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/deploy-ipks/all' returned non-zero exit status 1.
Subprocess output:Usage: /home/pokybuild/yocto-worker/poky-tiny/build/build/tmp/work/all-poky-linux/run-postinsts/1.0-r10/recipe-sysroot-native/usr/bin/opkg-build [-c] [-C] [-Z compressor] [-a compressor_args] [-O] [-o owner] [-g group] <pkg_directory> [<destination_directory>]


any chance this is solved in v4?

On 12/07/2023 14:25:55+0200, Piotr Łobacz wrote:
> Extend OPKGBUILDCMD variable, with additional parameters, depending
> on target distro features, in order to support ACLs and xattr.
>
> With fix pushed to the opkg-devel:
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C0efc7fdd53c24f55f72108db82f89ab6%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638247776502053494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=A3X2JtnQjiM0AsezU9PYnPmYa2e0TpjdRyIRPw0INZI%3D&reserved=0<https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8>
> opkg-build is able to create tar archives with ACLs and xattr.
>
> Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> ---
>  meta/classes-global/package_ipk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-global/package_ipk.bbclass b/meta/classes-global/package_ipk.bbclass
> index b4b7bc9ac2..5e151be3cd 100644
> --- a/meta/classes-global/package_ipk.bbclass
> +++ b/meta/classes-global/package_ipk.bbclass
> @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf"
>  PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks"
>
>  # Program to be used to build opkg packages
> -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"'
> +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" "${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)}" "${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}"'
>
>  OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
>  OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> --
> 2.34.1
>

>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#184190): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Fmessage%2F184190&data=05%7C01%7Cp.lobacz%40welotec.com%7C0efc7fdd53c24f55f72108db82f89ab6%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638247776502053494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FpPC3vbDQvde6a%2Bfk344UcPIBMDY5YUgja%2BsTfgksbA%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/message/184190>
> Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F100098284%2F3617179&data=05%7C01%7Cp.lobacz%40welotec.com%7C0efc7fdd53c24f55f72108db82f89ab6%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638247776502053494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mM9Lg8I2QMHhaDHdsFUjiQNBTUNaB4%2BEj2PAPp27hp4%3D&reserved=0<https://lists.openembedded.org/mt/100098284/3617179>
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-core%2Funsub&data=05%7C01%7Cp.lobacz%40welotec.com%7C0efc7fdd53c24f55f72108db82f89ab6%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638247776502053494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2B5zFOTfuLmQUz66hqJm6HfmZEtD6eFgSQ%2FykKjvH9zY%3D&reserved=0<https://lists.openembedded.org/g/openembedded-core/unsub> [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C0efc7fdd53c24f55f72108db82f89ab6%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638247776502053494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5YnjSEIXmgyT%2BrFQSzlacMVqkKUAiM5y2hvZHo%2FxzI0%3D&reserved=0<https://bootlin.com/>

[-- Attachment #2: Type: text/html, Size: 11461 bytes --]

Re: ODP: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Richard Purdie]

On Wed, 2023-07-12 at 19:08 +0000, Piotr Łobacz wrote:
> OK, I have set in v5 patches set, these acl and xattr attributes by
> default in DISTRO_FEATURES_NATIVE, without any checks, if it exists
> in DISTRO_FEATURES. Is that ok for all of you?

No, don't check DISTRO_FEATURES. Just add acl unconditionally.

Cheers,

Richard

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Richard, but that is exactly, what I have written… wirhout anu checks.

Cheers
Piotr
________________________________
Od: Richard Purdie <richard.purdie@linuxfoundation.org>
Wysłane: Wednesday, July 12, 2023 9:25:15 PM
Do: Piotr Łobacz <p.lobacz@welotec.com>; Alexander Kanavin <alex.kanavin@gmail.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: ODP: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

On Wed, 2023-07-12 at 19:08 +0000, Piotr Łobacz wrote:
> OK, I have set in v5 patches set, these acl and xattr attributes by
> default in DISTRO_FEATURES_NATIVE, without any checks, if it exists
> in DISTRO_FEATURES. Is that ok for all of you?

No, don't check DISTRO_FEATURES. Just add acl unconditionally.

Cheers,

Richard

[-- Attachment #2: Type: text/html, Size: 1571 bytes --]

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Sorry for typo. It should be any, not anu. I’m typing from mobile…

Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
________________________________
Od: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> w imieniu użytkownika Piotr Łobacz via lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
Wysłane: Wednesday, July 12, 2023 10:46:27 PM
Do: Richard Purdie <richard.purdie@linuxfoundation.org>; Alexander Kanavin <alex.kanavin@gmail.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

Richard, but that is exactly, what I have written… wirhout anu checks.

Cheers
Piotr
________________________________
Od: Richard Purdie <richard.purdie@linuxfoundation.org>
Wysłane: Wednesday, July 12, 2023 9:25:15 PM
Do: Piotr Łobacz <p.lobacz@welotec.com>; Alexander Kanavin <alex.kanavin@gmail.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: ODP: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

On Wed, 2023-07-12 at 19:08 +0000, Piotr Łobacz wrote:
> OK, I have set in v5 patches set, these acl and xattr attributes by
> default in DISTRO_FEATURES_NATIVE, without any checks, if it exists
> in DISTRO_FEATURES. Is that ok for all of you?

No, don't check DISTRO_FEATURES. Just add acl unconditionally.

Cheers,

Richard

[-- Attachment #2: Type: text/html, Size: 2675 bytes --]

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Richard Purdie]

On Wed, 2023-07-12 at 20:48 +0000, Piotr Łobacz wrote:
> Richard, but that is exactly, what I have written… wirhout any
> checks.

No, I mean that the right patch should be:

-DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr"
+DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr acl"

i.e. add acl to DISTRO_FEATURES_NATIVE and leave xattr there.

Cheers,

Richard

Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

But I have sent already v5 with this change…

BR
Piotr

Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
________________________________
Od: Richard Purdie <richard.purdie@linuxfoundation.org>
Wysłane: Wednesday, July 12, 2023 11:33:37 PM
Do: Piotr Łobacz <p.lobacz@welotec.com>; Alexander Kanavin <alex.kanavin@gmail.com>
DW: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Temat: Re: [OE-Core][PATCH v4 1/5] bitbake.conf: add acl and xattr distro native features support

On Wed, 2023-07-12 at 20:48 +0000, Piotr Łobacz wrote:
> Richard, but that is exactly, what I have written… wirhout any
> checks.

No, I mean that the right patch should be:

-DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr"
+DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr acl"

i.e. add acl to DISTRO_FEATURES_NATIVE and leave xattr there.

Cheers,

Richard


[-- Attachment #2: Type: text/html, Size: 1705 bytes --]