From: Greg KH <gregkh@linuxfoundation.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 1/3] usb: misc: Add the interface for notifier call for Embedded USB Debugger(EUD)
Date: Wed, 12 Jul 2023 18:41:07 +0200 [thread overview]
Message-ID: <2023071259-stumbling-collected-9c59@gregkh> (raw)
In-Reply-To: <a2b04d69396c9522327f6c0f22637a83161a5fe9.1689148711.git.quic_schowdhu@quicinc.com>
On Wed, Jul 12, 2023 at 01:52:38PM +0530, Souradeep Chowdhury wrote:
> Add the interface for notifier calls that can be made to check the role
> switch status of EUD. An external module can import this file and use the
> wrapper functions eud_register_notify to register a notifier to the EUD
> notifier chain, eud_unregister_notify to unregister the notifier from the
> chain, eud_notifier_call_chain to call the notifier chain to check the
> status of role-switch. These interfaces are provided to handle the case
> where multiple modules might go for a role-switch on the same port in which
> case EUD will be given priority over the rest.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> drivers/usb/misc/qcom_eud_notifier.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 drivers/usb/misc/qcom_eud_notifier.h
>
> diff --git a/drivers/usb/misc/qcom_eud_notifier.h b/drivers/usb/misc/qcom_eud_notifier.h
> new file mode 100644
> index 000000000000..0cae42a5f6bf
> --- /dev/null
> +++ b/drivers/usb/misc/qcom_eud_notifier.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Released under the GPLv2 only.
> + */
> +
> +#include <linux/notifier.h>
> +
> +extern int eud_register_notify(struct notifier_block *nb);
> +extern void eud_unregister_notify(struct notifier_block *nb);
> +extern void eud_notifier_call_chain(unsigned long role_switch_state);
> --
> 2.17.1
>
Don't add .h files that no one actually use.
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V1 1/3] usb: misc: Add the interface for notifier call for Embedded USB Debugger(EUD)
Date: Wed, 12 Jul 2023 18:41:07 +0200 [thread overview]
Message-ID: <2023071259-stumbling-collected-9c59@gregkh> (raw)
In-Reply-To: <a2b04d69396c9522327f6c0f22637a83161a5fe9.1689148711.git.quic_schowdhu@quicinc.com>
On Wed, Jul 12, 2023 at 01:52:38PM +0530, Souradeep Chowdhury wrote:
> Add the interface for notifier calls that can be made to check the role
> switch status of EUD. An external module can import this file and use the
> wrapper functions eud_register_notify to register a notifier to the EUD
> notifier chain, eud_unregister_notify to unregister the notifier from the
> chain, eud_notifier_call_chain to call the notifier chain to check the
> status of role-switch. These interfaces are provided to handle the case
> where multiple modules might go for a role-switch on the same port in which
> case EUD will be given priority over the rest.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
> ---
> drivers/usb/misc/qcom_eud_notifier.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 drivers/usb/misc/qcom_eud_notifier.h
>
> diff --git a/drivers/usb/misc/qcom_eud_notifier.h b/drivers/usb/misc/qcom_eud_notifier.h
> new file mode 100644
> index 000000000000..0cae42a5f6bf
> --- /dev/null
> +++ b/drivers/usb/misc/qcom_eud_notifier.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Released under the GPLv2 only.
> + */
> +
> +#include <linux/notifier.h>
> +
> +extern int eud_register_notify(struct notifier_block *nb);
> +extern void eud_unregister_notify(struct notifier_block *nb);
> +extern void eud_notifier_call_chain(unsigned long role_switch_state);
> --
> 2.17.1
>
Don't add .h files that no one actually use.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-12 16:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 8:22 [PATCH V1 0/3] Add notifier call chain to Embedded USB Debug(EUD) driver Souradeep Chowdhury
2023-07-12 8:22 ` Souradeep Chowdhury
2023-07-12 8:22 ` [PATCH V1 1/3] usb: misc: Add the interface for notifier call for Embedded USB Debugger(EUD) Souradeep Chowdhury
2023-07-12 8:22 ` Souradeep Chowdhury
2023-07-12 16:41 ` Greg KH [this message]
2023-07-12 16:41 ` Greg KH
2023-07-12 8:22 ` [PATCH V1 2/3] usb: misc: Add notifier call chain to Embedded USB Debug(EUD) driver Souradeep Chowdhury
2023-07-12 8:22 ` Souradeep Chowdhury
2023-07-12 18:22 ` Bhupesh Sharma
2023-07-12 18:22 ` Bhupesh Sharma
2023-07-13 8:30 ` Souradeep Chowdhury
2023-07-13 8:30 ` Souradeep Chowdhury
2023-07-12 8:22 ` [PATCH V1 3/3] MAINTAINERS: Add the header file entry for Embedded USB debugger(EUD) Souradeep Chowdhury
2023-07-12 8:22 ` Souradeep Chowdhury
2023-07-12 18:24 ` Bhupesh Sharma
2023-07-12 18:24 ` Bhupesh Sharma
2023-07-12 16:40 ` [PATCH V1 0/3] Add notifier call chain to Embedded USB Debug(EUD) driver Greg KH
2023-07-12 16:40 ` Greg KH
2023-07-13 8:25 ` Souradeep Chowdhury
2023-07-13 8:25 ` Souradeep Chowdhury
2023-07-13 13:52 ` Greg KH
2023-07-13 13:52 ` Greg KH
2023-07-12 16:43 ` Konrad Dybcio
2023-07-12 16:43 ` Konrad Dybcio
2023-07-13 8:26 ` Souradeep Chowdhury
2023-07-13 8:26 ` Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071259-stumbling-collected-9c59@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_sibis@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.