From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
quic_nitirawa@quicinc.com, quic_narepall@quicinc.com,
quic_bhaskarv@quicinc.com, quic_richardp@quicinc.com,
quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
bmasney@redhat.com, krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH 10/14] scsi: ufs: core: Add OPP support for scaling clocks and regulators
Date: Thu, 13 Jul 2023 10:37:11 +0530 [thread overview]
Message-ID: <20230713050711.GC3047@thinkpad> (raw)
In-Reply-To: <20230713040142.3nsrzezvi2hsp52e@vireshk-i7>
On Thu, Jul 13, 2023 at 09:31:42AM +0530, Viresh Kumar wrote:
> On 12-07-23, 16:02, Manivannan Sadhasivam wrote:
> > +static int ufshcd_opp_set_rate(struct ufs_hba *hba, unsigned long freq)
> > +{
> > + struct dev_pm_opp *opp;
> > +
> > + opp = dev_pm_opp_find_freq_floor_indexed(hba->dev,
> > + &freq, 0);
> > + if (IS_ERR(opp))
> > + return PTR_ERR(opp);
> > +
> > + dev_pm_opp_put(opp);
>
> You can't free the OPP while you are still using it :)
>
Ah... will fix it!
- Mani
> > +
> > + return dev_pm_opp_set_opp(hba->dev, opp);
> > +}
>
> --
> viresh
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-07-13 5:07 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 10:31 [PATCH 00/14] UFS: Add OPP and interconnect support Manivannan Sadhasivam
2023-07-12 10:31 ` [PATCH 01/14] dt-bindings: ufs: common: add OPP table Manivannan Sadhasivam
2023-07-12 10:31 ` [PATCH 02/14] dt-bindings: opp: Increase maxItems for opp-hz property Manivannan Sadhasivam
2023-07-12 10:39 ` Viresh Kumar
2023-07-12 11:04 ` Manivannan Sadhasivam
2023-07-14 16:17 ` Rob Herring
2023-07-17 7:00 ` Manivannan Sadhasivam
2023-07-12 10:31 ` [PATCH 03/14] arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC Manivannan Sadhasivam
2023-07-12 10:39 ` Konrad Dybcio
2023-07-12 10:31 ` [PATCH 04/14] arm64: dts: qcom: sdm845: Fix the min frequency of "ice_core_clk" Manivannan Sadhasivam
2023-07-12 10:45 ` Konrad Dybcio
2023-07-12 11:04 ` Manivannan Sadhasivam
2023-07-13 7:30 ` Eric Biggers
2023-07-13 7:37 ` Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 05/14] arm64: dts: qcom: sdm845: Add OPP table support to UFSHC Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 06/14] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 07/14] OPP: Introduce dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 08/14] OPP: Introduce dev_pm_opp_get_freq_indexed() API Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 09/14] PM / devfreq: Switch to dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 10/14] scsi: ufs: core: Add OPP support for scaling clocks and regulators Manivannan Sadhasivam
2023-07-13 4:01 ` Viresh Kumar
2023-07-13 5:07 ` Manivannan Sadhasivam [this message]
2023-07-12 10:32 ` [PATCH 10/13] scsi: ufs: host: Add support for parsing OPP Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 11/13] arm64: dts: qcom: sdm845: Add interconnect paths to UFSHC Manivannan Sadhasivam
2023-07-15 13:12 ` Konrad Dybcio
2023-07-12 10:32 ` [PATCH 11/14] scsi: ufs: host: Add support for parsing OPP Manivannan Sadhasivam
2023-07-12 13:15 ` Dmitry Baryshkov
2023-07-12 16:34 ` Manivannan Sadhasivam
2023-07-12 16:48 ` Dmitry Baryshkov
2023-07-13 4:09 ` Viresh Kumar
2023-07-13 5:05 ` Manivannan Sadhasivam
2023-07-13 5:12 ` Viresh Kumar
2023-07-13 5:28 ` Manivannan Sadhasivam
2023-07-13 5:43 ` Viresh Kumar
2023-07-13 5:53 ` Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 12/14] arm64: dts: qcom: sdm845: Add interconnect paths to UFSHC Manivannan Sadhasivam
2023-07-15 13:12 ` Konrad Dybcio
2023-07-12 10:32 ` [PATCH 12/13] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-07-15 13:13 ` Konrad Dybcio
2023-07-12 10:32 ` [PATCH 13/14] " Manivannan Sadhasivam
2023-07-15 13:14 ` Konrad Dybcio
2023-07-12 10:32 ` [PATCH 13/13] scsi: ufs: qcom: Add support for scaling interconnects Manivannan Sadhasivam
2023-07-12 10:32 ` [PATCH 14/14] " Manivannan Sadhasivam
2023-07-12 13:22 ` Dmitry Baryshkov
2023-07-12 16:41 ` Manivannan Sadhasivam
2023-07-12 17:23 ` Dmitry Baryshkov
2023-07-13 5:20 ` Manivannan Sadhasivam
2023-07-12 10:40 ` [PATCH 00/14] UFS: Add OPP and interconnect support Manivannan Sadhasivam
2023-07-12 12:18 ` Dmitry Baryshkov
2023-07-12 12:27 ` Manivannan Sadhasivam
2023-07-12 11:02 ` John Garry
2023-07-12 11:12 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713050711.GC3047@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.