From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, jiri@nvidia.com,
dtatulea@nvidia.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support
Date: Thu, 13 Jul 2023 07:40:12 -0400 [thread overview]
Message-ID: <20230713074001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230710092005.5062-1-gavinl@nvidia.com>
On Mon, Jul 10, 2023 at 12:20:01PM +0300, Gavin Li wrote:
> Currently, coalescing parameters are grouped for all transmit and receive
> virtqueues. This patch series add support to set or get the parameters for
> a specified virtqueue.
>
> When the traffic between virtqueues is unbalanced, for example, one virtqueue
> is busy and another virtqueue is idle, then it will be very useful to
> control coalescing parameters at the virtqueue granularity.
series:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Example command:
> $ ethtool -Q eth5 queue_mask 0x1 --coalesce tx-packets 10
> Would set max_packets=10 to VQ 1.
> $ ethtool -Q eth5 queue_mask 0x1 --coalesce rx-packets 10
> Would set max_packets=10 to VQ 0.
> $ ethtool -Q eth5 queue_mask 0x1 --show-coalesce
> Queue: 0
> Adaptive RX: off TX: off
> stats-block-usecs: 0
> sample-interval: 0
> pkt-rate-low: 0
> pkt-rate-high: 0
>
> rx-usecs: 222
> rx-frames: 0
> rx-usecs-irq: 0
> rx-frames-irq: 256
>
> tx-usecs: 222
> tx-frames: 0
> tx-usecs-irq: 0
> tx-frames-irq: 256
>
> rx-usecs-low: 0
> rx-frame-low: 0
> tx-usecs-low: 0
> tx-frame-low: 0
>
> rx-usecs-high: 0
> rx-frame-high: 0
> tx-usecs-high: 0
> tx-frame-high: 0
>
> In this patch series:
> Patch-1: Extract interrupt coalescing settings to a structure.
> Patch-2: Extract get/set interrupt coalesce to a function.
> Patch-3: Support per queue interrupt coalesce command.
> Patch-4: Enable per queue interrupt coalesce feature.
>
> Gavin Li (4):
> virtio_net: extract interrupt coalescing settings to a structure
> virtio_net: extract get/set interrupt coalesce to a function
> virtio_net: support per queue interrupt coalesce command
> virtio_net: enable per queue interrupt coalesce feature
>
> drivers/net/virtio_net.c | 169 ++++++++++++++++++++++++++------
> include/uapi/linux/virtio_net.h | 14 +++
> 2 files changed, 154 insertions(+), 29 deletions(-)
>
> --
> 2.39.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: xuanzhuo@linux.alibaba.com, hawk@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
john.fastabend@gmail.com, ast@kernel.org, edumazet@google.com,
jiri@nvidia.com, kuba@kernel.org, bpf@vger.kernel.org,
pabeni@redhat.com, virtualization@lists.linux-foundation.org,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support
Date: Thu, 13 Jul 2023 07:40:12 -0400 [thread overview]
Message-ID: <20230713074001-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230710092005.5062-1-gavinl@nvidia.com>
On Mon, Jul 10, 2023 at 12:20:01PM +0300, Gavin Li wrote:
> Currently, coalescing parameters are grouped for all transmit and receive
> virtqueues. This patch series add support to set or get the parameters for
> a specified virtqueue.
>
> When the traffic between virtqueues is unbalanced, for example, one virtqueue
> is busy and another virtqueue is idle, then it will be very useful to
> control coalescing parameters at the virtqueue granularity.
series:
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Example command:
> $ ethtool -Q eth5 queue_mask 0x1 --coalesce tx-packets 10
> Would set max_packets=10 to VQ 1.
> $ ethtool -Q eth5 queue_mask 0x1 --coalesce rx-packets 10
> Would set max_packets=10 to VQ 0.
> $ ethtool -Q eth5 queue_mask 0x1 --show-coalesce
> Queue: 0
> Adaptive RX: off TX: off
> stats-block-usecs: 0
> sample-interval: 0
> pkt-rate-low: 0
> pkt-rate-high: 0
>
> rx-usecs: 222
> rx-frames: 0
> rx-usecs-irq: 0
> rx-frames-irq: 256
>
> tx-usecs: 222
> tx-frames: 0
> tx-usecs-irq: 0
> tx-frames-irq: 256
>
> rx-usecs-low: 0
> rx-frame-low: 0
> tx-usecs-low: 0
> tx-frame-low: 0
>
> rx-usecs-high: 0
> rx-frame-high: 0
> tx-usecs-high: 0
> tx-frame-high: 0
>
> In this patch series:
> Patch-1: Extract interrupt coalescing settings to a structure.
> Patch-2: Extract get/set interrupt coalesce to a function.
> Patch-3: Support per queue interrupt coalesce command.
> Patch-4: Enable per queue interrupt coalesce feature.
>
> Gavin Li (4):
> virtio_net: extract interrupt coalescing settings to a structure
> virtio_net: extract get/set interrupt coalesce to a function
> virtio_net: support per queue interrupt coalesce command
> virtio_net: enable per queue interrupt coalesce feature
>
> drivers/net/virtio_net.c | 169 ++++++++++++++++++++++++++------
> include/uapi/linux/virtio_net.h | 14 +++
> 2 files changed, 154 insertions(+), 29 deletions(-)
>
> --
> 2.39.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-07-13 11:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:20 [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support Gavin Li
2023-07-10 9:20 ` [PATCH net-next V1 1/4] virtio_net: extract interrupt coalescing settings to a structure Gavin Li
2023-07-12 7:35 ` Jason Wang
2023-07-10 9:20 ` [PATCH net-next V1 2/4] virtio_net: extract get/set interrupt coalesce to a function Gavin Li
2023-07-12 7:39 ` Jason Wang
2023-07-10 9:20 ` [PATCH net-next V1 3/4] virtio_net: support per queue interrupt coalesce command Gavin Li
2023-07-12 8:01 ` Jason Wang
2023-07-12 9:39 ` Xuan Zhuo
2023-07-12 9:39 ` Xuan Zhuo
2023-07-12 9:44 ` Gavin Li
2023-07-10 9:20 ` [PATCH net-next V1 4/4] virtio_net: enable per queue interrupt coalesce feature Gavin Li
2023-07-10 9:25 ` [PATCH net-next V1 0/4] virtio_net: add per queue interrupt coalescing support Xuan Zhuo
2023-07-10 9:25 ` Xuan Zhuo
2023-07-11 2:34 ` Gavin Li
2023-07-11 3:10 ` Xuan Zhuo
2023-07-11 3:10 ` Xuan Zhuo
2023-07-12 8:34 ` Heng Qi
2023-07-13 2:22 ` Gavin Li
2023-07-13 11:40 ` Michael S. Tsirkin [this message]
2023-07-13 11:40 ` Michael S. Tsirkin
2023-07-14 2:10 ` Xuan Zhuo
2023-07-14 2:10 ` Xuan Zhuo
2023-08-30 19:42 ` Michael S. Tsirkin
2023-08-30 19:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713074001-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gavinl@nvidia.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.