From: Alexander Potapenko <glider@google.com>
To: glider@google.com, catalin.marinas@arm.com, will@kernel.org,
pcc@google.com, andreyknvl@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
yury.norov@gmail.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, eugenis@google.com
Subject: [v2 2/5] lib/test_bitmap: add tests for bitmap_{set,get}_value_unaligned
Date: Thu, 13 Jul 2023 14:57:02 +0200 [thread overview]
Message-ID: <20230713125706.2884502-3-glider@google.com> (raw)
In-Reply-To: <20230713125706.2884502-1-glider@google.com>
Add basic tests ensuring that values can be added at arbitrary positions
of the bitmap, including those spanning into the adjacent unsigned
longs.
Signed-off-by: Alexander Potapenko <glider@google.com>
---
lib/test_bitmap.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 187f5b2db4cf1..8ca61f6e7f26e 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -71,6 +71,17 @@ __check_eq_uint(const char *srcfile, unsigned int line,
return true;
}
+static bool __init
+__check_eq_ulong(const char *srcfile, unsigned int line,
+ const unsigned long exp_ulong, unsigned long x)
+{
+ if (exp_ulong != x) {
+ pr_err("[%s:%u] expected %lu, got %lu\n",
+ srcfile, line, exp_ulong, x);
+ return false;
+ }
+ return true;
+}
static bool __init
__check_eq_bitmap(const char *srcfile, unsigned int line,
@@ -186,6 +197,7 @@ __check_eq_str(const char *srcfile, unsigned int line,
})
#define expect_eq_uint(...) __expect_eq(uint, ##__VA_ARGS__)
+#define expect_eq_ulong(...) __expect_eq(ulong, ##__VA_ARGS__)
#define expect_eq_bitmap(...) __expect_eq(bitmap, ##__VA_ARGS__)
#define expect_eq_pbl(...) __expect_eq(pbl, ##__VA_ARGS__)
#define expect_eq_u32_array(...) __expect_eq(u32_array, ##__VA_ARGS__)
@@ -1222,6 +1234,26 @@ static void __init test_bitmap_const_eval(void)
BUILD_BUG_ON(~var != ~BIT(25));
}
+static void __init test_set_get_value_unaligned(void)
+{
+ DECLARE_BITMAP(bitmap, BITS_PER_LONG * 2);
+ unsigned long val;
+ int i;
+
+ for (i = 0; i < BITS_PER_LONG * 2 - 7; i++) {
+ bitmap_zero(bitmap, BITS_PER_LONG * 2);
+ bitmap_set_value_unaligned(bitmap, 0b10101UL, i, 5);
+ val = bitmap_get_value_unaligned(bitmap, i, 5);
+ expect_eq_ulong(0b10101UL, val);
+ bitmap_set_value_unaligned(bitmap, 0b101UL, i + 5, 3);
+ val = bitmap_get_value_unaligned(bitmap, i + 5, 3);
+ expect_eq_ulong(0b101UL, val);
+ val = bitmap_get_value_unaligned(bitmap, i, 8);
+ expect_eq_ulong(0b10101101UL, val);
+ }
+}
+
+
static void __init selftest(void)
{
test_zero_clear();
@@ -1249,6 +1281,8 @@ static void __init selftest(void)
test_for_each_clear_bitrange_from();
test_for_each_set_clump8();
test_for_each_set_bit_wrap();
+
+ test_set_get_value_unaligned();
}
KSTM_MODULE_LOADERS(test_bitmap);
--
2.41.0.255.g8b1d071c50-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Potapenko <glider@google.com>
To: glider@google.com, catalin.marinas@arm.com, will@kernel.org,
pcc@google.com, andreyknvl@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
yury.norov@gmail.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, eugenis@google.com
Subject: [v2 2/5] lib/test_bitmap: add tests for bitmap_{set,get}_value_unaligned
Date: Thu, 13 Jul 2023 14:57:02 +0200 [thread overview]
Message-ID: <20230713125706.2884502-3-glider@google.com> (raw)
In-Reply-To: <20230713125706.2884502-1-glider@google.com>
Add basic tests ensuring that values can be added at arbitrary positions
of the bitmap, including those spanning into the adjacent unsigned
longs.
Signed-off-by: Alexander Potapenko <glider@google.com>
---
lib/test_bitmap.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 187f5b2db4cf1..8ca61f6e7f26e 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -71,6 +71,17 @@ __check_eq_uint(const char *srcfile, unsigned int line,
return true;
}
+static bool __init
+__check_eq_ulong(const char *srcfile, unsigned int line,
+ const unsigned long exp_ulong, unsigned long x)
+{
+ if (exp_ulong != x) {
+ pr_err("[%s:%u] expected %lu, got %lu\n",
+ srcfile, line, exp_ulong, x);
+ return false;
+ }
+ return true;
+}
static bool __init
__check_eq_bitmap(const char *srcfile, unsigned int line,
@@ -186,6 +197,7 @@ __check_eq_str(const char *srcfile, unsigned int line,
})
#define expect_eq_uint(...) __expect_eq(uint, ##__VA_ARGS__)
+#define expect_eq_ulong(...) __expect_eq(ulong, ##__VA_ARGS__)
#define expect_eq_bitmap(...) __expect_eq(bitmap, ##__VA_ARGS__)
#define expect_eq_pbl(...) __expect_eq(pbl, ##__VA_ARGS__)
#define expect_eq_u32_array(...) __expect_eq(u32_array, ##__VA_ARGS__)
@@ -1222,6 +1234,26 @@ static void __init test_bitmap_const_eval(void)
BUILD_BUG_ON(~var != ~BIT(25));
}
+static void __init test_set_get_value_unaligned(void)
+{
+ DECLARE_BITMAP(bitmap, BITS_PER_LONG * 2);
+ unsigned long val;
+ int i;
+
+ for (i = 0; i < BITS_PER_LONG * 2 - 7; i++) {
+ bitmap_zero(bitmap, BITS_PER_LONG * 2);
+ bitmap_set_value_unaligned(bitmap, 0b10101UL, i, 5);
+ val = bitmap_get_value_unaligned(bitmap, i, 5);
+ expect_eq_ulong(0b10101UL, val);
+ bitmap_set_value_unaligned(bitmap, 0b101UL, i + 5, 3);
+ val = bitmap_get_value_unaligned(bitmap, i + 5, 3);
+ expect_eq_ulong(0b101UL, val);
+ val = bitmap_get_value_unaligned(bitmap, i, 8);
+ expect_eq_ulong(0b10101101UL, val);
+ }
+}
+
+
static void __init selftest(void)
{
test_zero_clear();
@@ -1249,6 +1281,8 @@ static void __init selftest(void)
test_for_each_clear_bitrange_from();
test_for_each_set_clump8();
test_for_each_set_bit_wrap();
+
+ test_set_get_value_unaligned();
}
KSTM_MODULE_LOADERS(test_bitmap);
--
2.41.0.255.g8b1d071c50-goog
next prev parent reply other threads:[~2023-07-13 12:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 12:57 [v2 0/5] Implement MTE tag compression for swapped pages Alexander Potapenko
2023-07-13 12:57 ` Alexander Potapenko
2023-07-13 12:57 ` [v2 1/5] lib/bitmap: add bitmap_{set,get}_value_unaligned() Alexander Potapenko
2023-07-13 12:57 ` Alexander Potapenko
2023-07-13 17:28 ` Andy Shevchenko
2023-07-13 17:28 ` Andy Shevchenko
2023-07-13 18:05 ` Alexander Potapenko
2023-07-13 18:05 ` Alexander Potapenko
2023-07-14 8:04 ` Andy Shevchenko
2023-07-14 8:04 ` Andy Shevchenko
2023-07-14 11:19 ` William Breathitt Gray
2023-07-14 11:19 ` William Breathitt Gray
2023-07-14 11:28 ` Andy Shevchenko
2023-07-14 11:28 ` Andy Shevchenko
2023-07-14 12:07 ` Alexander Potapenko
2023-07-14 12:07 ` Alexander Potapenko
2023-07-14 12:30 ` Andy Shevchenko
2023-07-14 12:30 ` Andy Shevchenko
2023-07-13 12:57 ` Alexander Potapenko [this message]
2023-07-13 12:57 ` [v2 2/5] lib/test_bitmap: add tests for bitmap_{set,get}_value_unaligned Alexander Potapenko
2023-07-13 12:57 ` [v2 3/5] arm64: mte: implement CONFIG_ARM64_MTE_COMP Alexander Potapenko
2023-07-13 12:57 ` Alexander Potapenko
2023-07-13 16:37 ` Alexander Potapenko
2023-07-13 16:37 ` Alexander Potapenko
2023-07-13 17:23 ` Andy Shevchenko
2023-07-13 17:23 ` Andy Shevchenko
2023-07-13 19:27 ` Yury Norov
2023-07-13 19:27 ` Yury Norov
2023-07-14 8:01 ` Andy Shevchenko
2023-07-14 8:01 ` Andy Shevchenko
2023-07-14 9:25 ` Alexander Potapenko
2023-07-14 9:25 ` Alexander Potapenko
2023-07-14 10:47 ` Andy Shevchenko
2023-07-14 10:47 ` Andy Shevchenko
2023-07-14 11:17 ` Alexander Potapenko
2023-07-14 11:17 ` Alexander Potapenko
2023-07-13 12:57 ` [v2 4/5] arm64: mte: add a test for MTE tags compression Alexander Potapenko
2023-07-13 12:57 ` Alexander Potapenko
2023-07-13 12:57 ` [v2 5/5] arm64: mte: add compression support to mteswap.c Alexander Potapenko
2023-07-13 12:57 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713125706.2884502-3-glider@google.com \
--to=glider@google.com \
--cc=andreyknvl@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=eugenis@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pcc@google.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.