* [PATCH] mfd: rk808: Make MFD_RK8XX tristate
@ 2023-07-04 13:07 Geert Uytterhoeven
2023-07-05 17:26 ` Sebastian Reichel
2023-07-13 13:34 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-07-04 13:07 UTC (permalink / raw)
To: Lee Jones, Sebastian Reichel, Alexandre Belloni
Cc: linux-kernel, Geert Uytterhoeven
There is no reason for MFD_RK8XX to be bool, all drivers that depend on
it, or that select it, are tristate.
Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1197,7 +1197,7 @@ config MFD_RC5T583
different functionality of the device.
config MFD_RK8XX
- bool
+ tristate
select MFD_CORE
config MFD_RK8XX_I2C
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate
2023-07-04 13:07 [PATCH] mfd: rk808: Make MFD_RK8XX tristate Geert Uytterhoeven
@ 2023-07-05 17:26 ` Sebastian Reichel
2023-07-13 13:34 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-07-05 17:26 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Lee Jones, Alexandre Belloni, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Hi,
On Tue, Jul 04, 2023 at 03:07:48PM +0200, Geert Uytterhoeven wrote:
> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
>
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, LGTM.
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f5b259a6d6a0b9d..f6b519eaaa710e71 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1197,7 +1197,7 @@ config MFD_RC5T583
> different functionality of the device.
>
> config MFD_RK8XX
> - bool
> + tristate
> select MFD_CORE
>
> config MFD_RK8XX_I2C
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: rk808: Make MFD_RK8XX tristate
2023-07-04 13:07 [PATCH] mfd: rk808: Make MFD_RK8XX tristate Geert Uytterhoeven
2023-07-05 17:26 ` Sebastian Reichel
@ 2023-07-13 13:34 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-07-13 13:34 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Sebastian Reichel, Alexandre Belloni, linux-kernel
On Tue, 04 Jul 2023, Geert Uytterhoeven wrote:
> There is no reason for MFD_RK8XX to be bool, all drivers that depend on
> it, or that select it, are tristate.
>
> Fixes: c20e8c5b1203af37 ("mfd: rk808: Split into core and i2c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 13:07 [PATCH] mfd: rk808: Make MFD_RK8XX tristate Geert Uytterhoeven
2023-07-05 17:26 ` Sebastian Reichel
2023-07-13 13:34 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.