* [PATCH] mfd: wcd934x: Update to use maple tree register cache
@ 2023-07-12 16:40 Mark Brown
2023-07-13 15:43 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2023-07-12 16:40 UTC (permalink / raw)
To: Lee Jones; +Cc: Srinivas Kandagatla, linux-kernel, Mark Brown
The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache. In
v6.5 it has also acquired the ability to generate multi-register writes in
sync operations, bringing performance up to parity with the rbtree cache
there.
Update the wcd934x to use the more modern data structure.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
Signed-off-by: Mark
---
drivers/mfd/wcd934x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
index 6b942d5270c1..7b9873b72c37 100644
--- a/drivers/mfd/wcd934x.c
+++ b/drivers/mfd/wcd934x.c
@@ -112,7 +112,7 @@ static const struct regmap_range_cfg wcd934x_ranges[] = {
static struct regmap_config wcd934x_regmap_config = {
.reg_bits = 16,
.val_bits = 8,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = 0xffff,
.can_multi_write = true,
.ranges = wcd934x_ranges,
---
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
change-id: 20230623-mfd-wcd934x-maple-852535e3b2c6
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: wcd934x: Update to use maple tree register cache
2023-07-12 16:40 [PATCH] mfd: wcd934x: Update to use maple tree register cache Mark Brown
@ 2023-07-13 15:43 ` Lee Jones
2023-07-13 15:56 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2023-07-13 15:43 UTC (permalink / raw)
To: Mark Brown; +Cc: Srinivas Kandagatla, linux-kernel
On Wed, 12 Jul 2023, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache. In
> v6.5 it has also acquired the ability to generate multi-register writes in
> sync operations, bringing performance up to parity with the rbtree cache
> there.
>
> Update the wcd934x to use the more modern data structure.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>
>
> Signed-off-by: Mark
Something going on with your helpers?
> ---
> drivers/mfd/wcd934x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 16:40 [PATCH] mfd: wcd934x: Update to use maple tree register cache Mark Brown
2023-07-13 15:43 ` Lee Jones
2023-07-13 15:56 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.