From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [LTP] [linus:master] [iomap] 219580eea1: ltp.writev07.fail
Date: Thu, 13 Jul 2023 17:56:31 +0200 [thread overview]
Message-ID: <20230713155631.GA29281@lst.de> (raw)
In-Reply-To: <ZLAZn_SBmoIFG5F5@yuki>
On Thu, Jul 13, 2023 at 05:34:55PM +0200, Cyril Hrubis wrote:
> iter.processed = iomap_write_iter(&iter, i);
>
> + iocb->ki_pos += iter.pos - iocb->ki_pos;
> +
> if (unlikely(ret < 0))
> return ret;
> - ret = iter.pos - iocb->ki_pos;
> - iocb->ki_pos += ret;
> - return ret;
> +
> + return iter.pos - iocb->ki_pos;
I don't think this works, as iocb->ki_pos has been updated above.
What you want is probably the version below. But so far I can't
reproduce anything yet..
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index adb92cdb24b009..02aea0174ddbcf 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -872,7 +872,7 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
while ((ret = iomap_iter(&iter, ops)) > 0)
iter.processed = iomap_write_iter(&iter, i);
- if (unlikely(ret < 0))
+ if (iter.pos == iocb->ki_pos)
return ret;
ret = iter.pos - iocb->ki_pos;
iocb->ki_pos += ret;
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
kernel test robot <oliver.sang@intel.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Matthew Wilcox <willy@infradead.org>,
cluster-devel@redhat.com, Ilya Dryomov <idryomov@gmail.com>,
Miklos Szeredi <mszeredi@redhat.com>, Chao Yu <chao@kernel.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Jaegeuk Kim <jaegeuk@kernel.org>, Xiubo Li <xiubli@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
ltp@lists.linux.it, lkp@intel.com, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
Anna Schumaker <anna@kernel.org>,
oe-lkp@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [LTP] [linus:master] [iomap] 219580eea1: ltp.writev07.fail
Date: Thu, 13 Jul 2023 17:56:31 +0200 [thread overview]
Message-ID: <20230713155631.GA29281@lst.de> (raw)
In-Reply-To: <ZLAZn_SBmoIFG5F5@yuki>
On Thu, Jul 13, 2023 at 05:34:55PM +0200, Cyril Hrubis wrote:
> iter.processed = iomap_write_iter(&iter, i);
>
> + iocb->ki_pos += iter.pos - iocb->ki_pos;
> +
> if (unlikely(ret < 0))
> return ret;
> - ret = iter.pos - iocb->ki_pos;
> - iocb->ki_pos += ret;
> - return ret;
> +
> + return iter.pos - iocb->ki_pos;
I don't think this works, as iocb->ki_pos has been updated above.
What you want is probably the version below. But so far I can't
reproduce anything yet..
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index adb92cdb24b009..02aea0174ddbcf 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -872,7 +872,7 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
while ((ret = iomap_iter(&iter, ops)) > 0)
iter.processed = iomap_write_iter(&iter, i);
- if (unlikely(ret < 0))
+ if (iter.pos == iocb->ki_pos)
return ret;
ret = iter.pos - iocb->ki_pos;
iocb->ki_pos += ret;
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Andreas Gruenbacher <agruenba@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Matthew Wilcox <willy@infradead.org>,
cluster-devel@redhat.com, Ilya Dryomov <idryomov@gmail.com>,
Miklos Szeredi <mszeredi@redhat.com>, Chao Yu <chao@kernel.org>,
oe-lkp@lists.linux.dev, Al Viro <viro@zeniv.linux.org.uk>,
Jaegeuk Kim <jaegeuk@kernel.org>, Xiubo Li <xiubli@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
ltp@lists.linux.it, lkp@intel.com, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>,
Anna Schumaker <anna@kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [LTP] [linus:master] [iomap] 219580eea1: ltp.writev07.fail
Date: Thu, 13 Jul 2023 17:56:31 +0200 [thread overview]
Message-ID: <20230713155631.GA29281@lst.de> (raw)
In-Reply-To: <ZLAZn_SBmoIFG5F5@yuki>
On Thu, Jul 13, 2023 at 05:34:55PM +0200, Cyril Hrubis wrote:
> iter.processed = iomap_write_iter(&iter, i);
>
> + iocb->ki_pos += iter.pos - iocb->ki_pos;
> +
> if (unlikely(ret < 0))
> return ret;
> - ret = iter.pos - iocb->ki_pos;
> - iocb->ki_pos += ret;
> - return ret;
> +
> + return iter.pos - iocb->ki_pos;
I don't think this works, as iocb->ki_pos has been updated above.
What you want is probably the version below. But so far I can't
reproduce anything yet..
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index adb92cdb24b009..02aea0174ddbcf 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -872,7 +872,7 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i,
while ((ret = iomap_iter(&iter, ops)) > 0)
iter.processed = iomap_write_iter(&iter, i);
- if (unlikely(ret < 0))
+ if (iter.pos == iocb->ki_pos)
return ret;
ret = iter.pos - iocb->ki_pos;
iocb->ki_pos += ret;
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-07-13 15:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:25 [Cluster-devel] [linus:master] [iomap] 219580eea1: ltp.writev07.fail kernel test robot
2023-07-13 13:25 ` kernel test robot
2023-07-13 13:25 ` [LTP] " kernel test robot
2023-07-13 15:09 ` [Cluster-devel] " Christoph Hellwig
2023-07-13 15:09 ` Christoph Hellwig
2023-07-13 15:09 ` [LTP] " Christoph Hellwig
2023-07-13 15:34 ` [Cluster-devel] " Cyril Hrubis
2023-07-13 15:34 ` Cyril Hrubis
2023-07-13 15:34 ` Cyril Hrubis
2023-07-13 15:56 ` Christoph Hellwig [this message]
2023-07-13 15:56 ` Christoph Hellwig
2023-07-13 15:56 ` Christoph Hellwig
2023-07-14 11:50 ` [Cluster-devel] " Jan Stancek
2023-07-14 11:50 ` Jan Stancek
2023-07-14 11:50 ` Jan Stancek
2023-07-14 11:53 ` [Cluster-devel] " Cyril Hrubis
2023-07-14 11:53 ` Cyril Hrubis
2023-07-14 11:53 ` Cyril Hrubis
2023-07-13 15:12 ` [Cluster-devel] " Cyril Hrubis
2023-07-13 15:12 ` Cyril Hrubis
2023-07-13 15:12 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713155631.GA29281@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.