From: Jakub Kicinski <kuba@kernel.org>
To: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, shuah@kernel.org,
davem@davemloft.net, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1] selftests/net: replace manual array size calc with ARRAYSIZE macro.
Date: Fri, 14 Jul 2023 12:52:00 -0700 [thread overview]
Message-ID: <20230714125200.716d2c14@kernel.org> (raw)
In-Reply-To: <20230714194635.1779496-1-mahmoudmatook.mm@gmail.com>
On Fri, 14 Jul 2023 23:46:35 +0400 Mahmoud Maatuq wrote:
> diff --git a/tools/testing/selftests/net/hwtstamp_config.c b/tools/testing/selftests/net/hwtstamp_config.c
Please resend and CC netdev@
There's ongoing work on hwtstamp configuration, there may be a conflict
if this goes via the general selftest tree.
> index 263cc1c34165..873f4937f37f 100644
> --- a/tools/testing/selftests/net/hwtstamp_config.c
> +++ b/tools/testing/selftests/net/hwtstamp_config.c
> @@ -16,9 +16,8 @@
> #include <linux/net_tstamp.h>
> #include <linux/sockios.h>
>
> -#ifndef ARRAY_SIZE
> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> -#endif
> +#include "kselftest.h"
> +
>
unnecessary extra new line
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
davem@davemloft.net,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v1] selftests/net: replace manual array size calc with ARRAYSIZE macro.
Date: Fri, 14 Jul 2023 12:52:00 -0700 [thread overview]
Message-ID: <20230714125200.716d2c14@kernel.org> (raw)
In-Reply-To: <20230714194635.1779496-1-mahmoudmatook.mm@gmail.com>
On Fri, 14 Jul 2023 23:46:35 +0400 Mahmoud Maatuq wrote:
> diff --git a/tools/testing/selftests/net/hwtstamp_config.c b/tools/testing/selftests/net/hwtstamp_config.c
Please resend and CC netdev@
There's ongoing work on hwtstamp configuration, there may be a conflict
if this goes via the general selftest tree.
> index 263cc1c34165..873f4937f37f 100644
> --- a/tools/testing/selftests/net/hwtstamp_config.c
> +++ b/tools/testing/selftests/net/hwtstamp_config.c
> @@ -16,9 +16,8 @@
> #include <linux/net_tstamp.h>
> #include <linux/sockios.h>
>
> -#ifndef ARRAY_SIZE
> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> -#endif
> +#include "kselftest.h"
> +
>
unnecessary extra new line
next prev parent reply other threads:[~2023-07-14 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 19:46 [PATCH v1] selftests/net: replace manual array size calc with ARRAYSIZE macro Mahmoud Maatuq
2023-07-14 19:46 ` Mahmoud Maatuq
2023-07-14 19:52 ` Jakub Kicinski [this message]
2023-07-14 19:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714125200.716d2c14@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mahmoudmatook.mm@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.