* [PATCH v2 0/3] support PWM for exynosautov9
@ 2023-07-14 10:09 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add pwm nodes to support PWM fan on exynosautov9-sadk board.
Changes in v2.
- add new compatible string for exynosautov9
Jaewon Kim (3):
dt-bindings: pwm: samsung: add exynosautov9 compatible
pwm: samsung: Add compatible for ExynosAutov9 SoC
arm64: dts: exynos: add pwm node for exynosautov9-sadk
Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 +++++++++
drivers/pwm/pwm-samsung.c | 1 +
4 files changed, 17 insertions(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-14 10:09 ` Jaewon Kim
-1 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add samsung,exynosautov9-pwm compatible string to binding document.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index fe603fb1b2cc..39a471083016 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -26,6 +26,7 @@ properties:
- samsung,s5p6440-pwm # 32-bit, S5P64x0
- samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
- samsung,exynos4210-pwm # 32-bit, Exynos
+ - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9
reg:
maxItems: 1
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
@ 2023-07-14 10:09 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add samsung,exynosautov9-pwm compatible string to binding document.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index fe603fb1b2cc..39a471083016 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -26,6 +26,7 @@ properties:
- samsung,s5p6440-pwm # 32-bit, S5P64x0
- samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
- samsung,exynos4210-pwm # 32-bit, Exynos
+ - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9
reg:
maxItems: 1
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-15 2:46 ` Rob Herring
-1 siblings, 0 replies; 22+ messages in thread
From: Rob Herring @ 2023-07-15 2:46 UTC (permalink / raw)
To: Jaewon Kim
Cc: Uwe Kleine-König, linux-arm-kernel, Thierry Reding,
linux-pwm, Chanho Park, Alim Akhtar, Rob Herring, devicetree,
linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
Conor Dooley
On Fri, 14 Jul 2023 19:09:27 +0900, Jaewon Kim wrote:
> Add samsung,exynosautov9-pwm compatible string to binding document.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
@ 2023-07-15 2:46 ` Rob Herring
0 siblings, 0 replies; 22+ messages in thread
From: Rob Herring @ 2023-07-15 2:46 UTC (permalink / raw)
To: Jaewon Kim
Cc: Uwe Kleine-König, linux-arm-kernel, Thierry Reding,
linux-pwm, Chanho Park, Alim Akhtar, Rob Herring, devicetree,
linux-samsung-soc, linux-kernel, Krzysztof Kozlowski,
Conor Dooley
On Fri, 14 Jul 2023 19:09:27 +0900, Jaewon Kim wrote:
> Add samsung,exynosautov9-pwm compatible string to binding document.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-17 5:59 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 5:59 UTC (permalink / raw)
To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 14/07/2023 12:09, Jaewon Kim wrote:
> Add samsung,exynosautov9-pwm compatible string to binding document.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> index fe603fb1b2cc..39a471083016 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> @@ -26,6 +26,7 @@ properties:
> - samsung,s5p6440-pwm # 32-bit, S5P64x0
> - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
> - samsung,exynos4210-pwm # 32-bit, Exynos
> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9
This does not express compatibility properly.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: pwm: samsung: add exynosautov9 compatible
@ 2023-07-17 5:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 5:59 UTC (permalink / raw)
To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 14/07/2023 12:09, Jaewon Kim wrote:
> Add samsung,exynosautov9-pwm compatible string to binding document.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-samsung.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> index fe603fb1b2cc..39a471083016 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
> @@ -26,6 +26,7 @@ properties:
> - samsung,s5p6440-pwm # 32-bit, S5P64x0
> - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
> - samsung,exynos4210-pwm # 32-bit, Exynos
> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9
This does not express compatibility properly.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-14 10:09 ` Jaewon Kim
-1 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add new compatible string to support ExynosAutov9 SoC.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
drivers/pwm/pwm-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index e8828f57ab15..50a88565c440 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
{ .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
{ .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
{ .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
+ { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
{},
};
MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-14 10:09 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add new compatible string to support ExynosAutov9 SoC.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
drivers/pwm/pwm-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index e8828f57ab15..50a88565c440 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
{ .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
{ .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
{ .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
+ { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
{},
};
MODULE_DEVICE_TABLE(of, samsung_pwm_matches);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-15 7:22 ` Uwe Kleine-König
-1 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2023-07-15 7:22 UTC (permalink / raw)
To: Jaewon Kim
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hello,
On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
> Add new compatible string to support ExynosAutov9 SoC.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
Looks good to me:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
What are the merge plans here? The whole series via pwm or a samsung
tree? Or a mixture?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-15 7:22 ` Uwe Kleine-König
0 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2023-07-15 7:22 UTC (permalink / raw)
To: Jaewon Kim
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
[-- Attachment #1.1: Type: text/plain, Size: 546 bytes --]
Hello,
On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
> Add new compatible string to support ExynosAutov9 SoC.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
Looks good to me:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
What are the merge plans here? The whole series via pwm or a samsung
tree? Or a mixture?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-15 7:22 ` Uwe Kleine-König
@ 2023-07-17 4:44 ` Jaewon Kim
-1 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-17 4:44 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
Hello,
On 23. 7. 15. 16:22, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
>> Add new compatible string to support ExynosAutov9 SoC.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> Looks good to me:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> What are the merge plans here? The whole series via pwm or a samsung
> tree? Or a mixture?
It would be nice to be merged whole series in the samsung tree.
Krzysztof could you apply all patch after your review?
>
> Best regards
> Uwe
>
Thanks
Jaewon Kim
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-17 4:44 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-17 4:44 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
Hello,
On 23. 7. 15. 16:22, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
>> Add new compatible string to support ExynosAutov9 SoC.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> Looks good to me:
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> What are the merge plans here? The whole series via pwm or a samsung
> tree? Or a mixture?
It would be nice to be merged whole series in the samsung tree.
Krzysztof could you apply all patch after your review?
>
> Best regards
> Uwe
>
Thanks
Jaewon Kim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-17 4:44 ` Jaewon Kim
@ 2023-07-17 6:00 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 6:00 UTC (permalink / raw)
To: Jaewon Kim, Uwe Kleine-König
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
On 17/07/2023 06:44, Jaewon Kim wrote:
> Hello,
>
>
> On 23. 7. 15. 16:22, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
>>> Add new compatible string to support ExynosAutov9 SoC.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> Looks good to me:
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> What are the merge plans here? The whole series via pwm or a samsung
>> tree? Or a mixture?
>
> It would be nice to be merged whole series in the samsung tree.
>
> Krzysztof could you apply all patch after your review?
Patch needs fixes - it is really different than we talked about.
Anyway, both PWM patches - bindings and driver - should go via PWM tree.
I will take the DTS, once proper version is sent.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-17 6:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 6:00 UTC (permalink / raw)
To: Jaewon Kim, Uwe Kleine-König
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, Chanho Park
On 17/07/2023 06:44, Jaewon Kim wrote:
> Hello,
>
>
> On 23. 7. 15. 16:22, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Fri, Jul 14, 2023 at 07:09:28PM +0900, Jaewon Kim wrote:
>>> Add new compatible string to support ExynosAutov9 SoC.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> Looks good to me:
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> What are the merge plans here? The whole series via pwm or a samsung
>> tree? Or a mixture?
>
> It would be nice to be merged whole series in the samsung tree.
>
> Krzysztof could you apply all patch after your review?
Patch needs fixes - it is really different than we talked about.
Anyway, both PWM patches - bindings and driver - should go via PWM tree.
I will take the DTS, once proper version is sent.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-17 5:58 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 5:58 UTC (permalink / raw)
To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 14/07/2023 12:09, Jaewon Kim wrote:
> Add new compatible string to support ExynosAutov9 SoC.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> drivers/pwm/pwm-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index e8828f57ab15..50a88565c440 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
> { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
> { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
> { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
> + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
That's not what I asked for. You do not need entry here. Devices are
compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-17 5:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-17 5:58 UTC (permalink / raw)
To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 14/07/2023 12:09, Jaewon Kim wrote:
> Add new compatible string to support ExynosAutov9 SoC.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> drivers/pwm/pwm-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index e8828f57ab15..50a88565c440 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
> { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
> { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
> { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
> + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
That's not what I asked for. You do not need entry here. Devices are
compatible.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
2023-07-17 5:58 ` Krzysztof Kozlowski
@ 2023-07-17 6:22 ` Jaewon Kim
-1 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-17 6:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thierry Reding, Uwe Kleine-König,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 23. 7. 17. 14:58, Krzysztof Kozlowski wrote:
> On 14/07/2023 12:09, Jaewon Kim wrote:
>> Add new compatible string to support ExynosAutov9 SoC.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>> drivers/pwm/pwm-samsung.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
>> index e8828f57ab15..50a88565c440 100644
>> --- a/drivers/pwm/pwm-samsung.c
>> +++ b/drivers/pwm/pwm-samsung.c
>> @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
>> { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
>> { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
>> { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
>> + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
> That's not what I asked for. You do not need entry here. Devices are
> compatible.
I misunderstood your intent.
I will add only this compatible to DT and send it again with v3 patch.
> Best regards,
> Krzysztof
>
>
Thanks
Jaewon Kim
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v2 2/3] pwm: samsung: Add compatible for ExynosAutov9 SoC
@ 2023-07-17 6:22 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-17 6:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Thierry Reding, Uwe Kleine-König,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park
On 23. 7. 17. 14:58, Krzysztof Kozlowski wrote:
> On 14/07/2023 12:09, Jaewon Kim wrote:
>> Add new compatible string to support ExynosAutov9 SoC.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>> drivers/pwm/pwm-samsung.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
>> index e8828f57ab15..50a88565c440 100644
>> --- a/drivers/pwm/pwm-samsung.c
>> +++ b/drivers/pwm/pwm-samsung.c
>> @@ -513,6 +513,7 @@ static const struct of_device_id samsung_pwm_matches[] = {
>> { .compatible = "samsung,s5p6440-pwm", .data = &s5p64x0_variant },
>> { .compatible = "samsung,s5pc100-pwm", .data = &s5pc100_variant },
>> { .compatible = "samsung,exynos4210-pwm", .data = &s5p64x0_variant },
>> + { .compatible = "samsung,exynosautov9-pwm", .data = &s5p64x0_variant },
> That's not what I asked for. You do not need entry here. Devices are
> compatible.
I misunderstood your intent.
I will add only this compatible to DT and send it again with v3 patch.
> Best regards,
> Krzysztof
>
>
Thanks
Jaewon Kim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 3/3] arm64: dts: exynos: add pwm node for exynosautov9-sadk
2023-07-14 10:09 ` Jaewon Kim
@ 2023-07-14 10:09 ` Jaewon Kim
-1 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add pwm node to support fan on exynosautov9-sadk board.
PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
in SADK board.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 +++++++++
2 files changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
index 898c2fc345ed..e717bb1cad81 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
@@ -50,6 +50,12 @@
};
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm_tout3>;
+ status = "okay";
+};
+
&serial_0 {
pinctrl-0 = <&uart0_bus_dual>;
status = "okay";
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index d3c5cdeff47f..672af47c79c1 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -1560,6 +1560,15 @@
samsung,syscon-phandle = <&pmu_system_controller>;
samsung,cluster-index = <1>;
};
+
+ pwm: pwm@103f0000 {
+ compatible = "samsung,exynosautov9-pwm";
+ reg = <0x103f0000 0x100>;
+ samsung,pwm-outputs = <0>, <1>, <2>, <3>;
+ #pwm-cells = <3>;
+ clocks = <&xtcxo>;
+ clock-names = "timers";
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v2 3/3] arm64: dts: exynos: add pwm node for exynosautov9-sadk
@ 2023-07-14 10:09 ` Jaewon Kim
0 siblings, 0 replies; 22+ messages in thread
From: Jaewon Kim @ 2023-07-14 10:09 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, Chanho Park, Jaewon Kim
Add pwm node to support fan on exynosautov9-sadk board.
PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
in SADK board.
Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 +++++++++
2 files changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
index 898c2fc345ed..e717bb1cad81 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
@@ -50,6 +50,12 @@
};
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm_tout3>;
+ status = "okay";
+};
+
&serial_0 {
pinctrl-0 = <&uart0_bus_dual>;
status = "okay";
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index d3c5cdeff47f..672af47c79c1 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -1560,6 +1560,15 @@
samsung,syscon-phandle = <&pmu_system_controller>;
samsung,cluster-index = <1>;
};
+
+ pwm: pwm@103f0000 {
+ compatible = "samsung,exynosautov9-pwm";
+ reg = <0x103f0000 0x100>;
+ samsung,pwm-outputs = <0>, <1>, <2>, <3>;
+ #pwm-cells = <3>;
+ clocks = <&xtcxo>;
+ clock-names = "timers";
+ };
};
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 22+ messages in thread