[PATCH v1] kernel: locking: Updates return value check

[PATCH v1] kernel: locking: Updates return value check

[Atul Kumar Pant]

Updating the check of return value from debugfs_create_file
and debugfs_create_dir to use IS_ERR.

Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
 kernel/locking/lock_events.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/locking/lock_events.c b/kernel/locking/lock_events.c
index fa2c2f951c6b..e68d82099558 100644
--- a/kernel/locking/lock_events.c
+++ b/kernel/locking/lock_events.c
@@ -146,7 +146,7 @@ static int __init init_lockevent_counts(void)
 	struct dentry *d_counts = debugfs_create_dir(LOCK_EVENTS_DIR, NULL);
 	int i;
 
-	if (!d_counts)
+	if (IS_ERR(d_counts))
 		goto out;
 
 	/*
@@ -159,14 +159,14 @@ static int __init init_lockevent_counts(void)
 	for (i = 0; i < lockevent_num; i++) {
 		if (skip_lockevent(lockevent_names[i]))
 			continue;
-		if (!debugfs_create_file(lockevent_names[i], 0400, d_counts,
-					 (void *)(long)i, &fops_lockevent))
+		if (IS_ERR(debugfs_create_file(lockevent_names[i], 0400, d_counts,
+					 (void *)(long)i, &fops_lockevent)))
 			goto fail_undo;
 	}
 
-	if (!debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
+	if (IS_ERR(debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
 				 d_counts, (void *)(long)LOCKEVENT_reset_cnts,
-				 &fops_lockevent))
+				 &fops_lockevent)))
 		goto fail_undo;
 
 	return 0;
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [PATCH v1] kernel: locking: Updates return value check

[Waiman Long]

On 7/16/23 14:06, Atul Kumar Pant wrote:
> Updating the check of return value from debugfs_create_file
> and debugfs_create_dir to use IS_ERR.
>
> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> ---
>   kernel/locking/lock_events.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/locking/lock_events.c b/kernel/locking/lock_events.c
> index fa2c2f951c6b..e68d82099558 100644
> --- a/kernel/locking/lock_events.c
> +++ b/kernel/locking/lock_events.c
> @@ -146,7 +146,7 @@ static int __init init_lockevent_counts(void)
>   	struct dentry *d_counts = debugfs_create_dir(LOCK_EVENTS_DIR, NULL);
>   	int i;
>   
> -	if (!d_counts)
> +	if (IS_ERR(d_counts))
>   		goto out;
>   
>   	/*
> @@ -159,14 +159,14 @@ static int __init init_lockevent_counts(void)
>   	for (i = 0; i < lockevent_num; i++) {
>   		if (skip_lockevent(lockevent_names[i]))
>   			continue;
> -		if (!debugfs_create_file(lockevent_names[i], 0400, d_counts,
> -					 (void *)(long)i, &fops_lockevent))
> +		if (IS_ERR(debugfs_create_file(lockevent_names[i], 0400, d_counts,
> +					 (void *)(long)i, &fops_lockevent)))
>   			goto fail_undo;
>   	}
>   
> -	if (!debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
> +	if (IS_ERR(debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
>   				 d_counts, (void *)(long)LOCKEVENT_reset_cnts,
> -				 &fops_lockevent))
> +				 &fops_lockevent)))
>   		goto fail_undo;
>   
>   	return 0;

It looks good to me, though the chance of getting an error return is 
really slim unless there is something really wrong with the system.

Acked-by: Waiman Long <longman@redhat.com>

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees