All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Md Sadre Alam <quic_mdalam@quicinc.com>,
	Sricharan Ramabadhran <quic_srichara@quicinc.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] mtd: rawnand: qcom: Use the BIT() macro
Date: Mon, 17 Jul 2023 07:55:48 +0530	[thread overview]
Message-ID: <20230717022548.GA5996@thinkpad> (raw)
In-Reply-To: <20230716144612.32132-2-miquel.raynal@bootlin.com>

On Sun, Jul 16, 2023 at 04:46:05PM +0200, Miquel Raynal wrote:
> Fix the following checkpatch warning:
>     "CHECK: Prefer using the BIT macro"
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Acked-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  drivers/mtd/nand/raw/qcom_nandc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index b1e69d634d4a..023c8b36426b 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -123,8 +123,8 @@
>  /* NAND_ERASED_CW_DETECT_CFG bits */
>  #define	ERASED_CW_ECC_MASK		1
>  #define	AUTO_DETECT_RES			0
> -#define	MASK_ECC			(1 << ERASED_CW_ECC_MASK)
> -#define	RESET_ERASED_DET		(1 << AUTO_DETECT_RES)
> +#define	MASK_ECC			BIT(ERASED_CW_ECC_MASK)
> +#define	RESET_ERASED_DET		BIT(AUTO_DETECT_RES)
>  #define	ACTIVE_ERASED_DET		(0 << AUTO_DETECT_RES)
>  #define	CLR_ERASED_PAGE_DET		(RESET_ERASED_DET | MASK_ECC)
>  #define	SET_ERASED_PAGE_DET		(ACTIVE_ERASED_DET | MASK_ECC)
> -- 
> 2.34.1
> 

-- 
மணிவண்ணன் சதாசிவம்

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Md Sadre Alam <quic_mdalam@quicinc.com>,
	Sricharan Ramabadhran <quic_srichara@quicinc.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] mtd: rawnand: qcom: Use the BIT() macro
Date: Mon, 17 Jul 2023 07:55:48 +0530	[thread overview]
Message-ID: <20230717022548.GA5996@thinkpad> (raw)
In-Reply-To: <20230716144612.32132-2-miquel.raynal@bootlin.com>

On Sun, Jul 16, 2023 at 04:46:05PM +0200, Miquel Raynal wrote:
> Fix the following checkpatch warning:
>     "CHECK: Prefer using the BIT macro"
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Acked-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  drivers/mtd/nand/raw/qcom_nandc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index b1e69d634d4a..023c8b36426b 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -123,8 +123,8 @@
>  /* NAND_ERASED_CW_DETECT_CFG bits */
>  #define	ERASED_CW_ECC_MASK		1
>  #define	AUTO_DETECT_RES			0
> -#define	MASK_ECC			(1 << ERASED_CW_ECC_MASK)
> -#define	RESET_ERASED_DET		(1 << AUTO_DETECT_RES)
> +#define	MASK_ECC			BIT(ERASED_CW_ECC_MASK)
> +#define	RESET_ERASED_DET		BIT(AUTO_DETECT_RES)
>  #define	ACTIVE_ERASED_DET		(0 << AUTO_DETECT_RES)
>  #define	CLR_ERASED_PAGE_DET		(RESET_ERASED_DET | MASK_ECC)
>  #define	SET_ERASED_PAGE_DET		(ACTIVE_ERASED_DET | MASK_ECC)
> -- 
> 2.34.1
> 

-- 
மணிவண்ணன் சதாசிவம்

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-17  2:26 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-16 14:46 [PATCH 0/8] mtd: rawnand: qcom: Misc fixes Miquel Raynal
2023-07-16 14:46 ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 1/8] mtd: rawnand: qcom: Use the BIT() macro Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:25   ` Manivannan Sadhasivam [this message]
2023-07-17  2:25     ` Manivannan Sadhasivam
2023-07-28  2:16   ` Tudor Ambarus
2023-07-28  2:16     ` Tudor Ambarus
2023-07-28 12:35   ` Miquel Raynal
2023-07-28 12:35     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 2/8] mtd: rawnand: qcom: Use u8 instead of uint8_t Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:26   ` Manivannan Sadhasivam
2023-07-17  2:26     ` Manivannan Sadhasivam
2023-07-28  2:17   ` Tudor Ambarus
2023-07-28  2:17     ` Tudor Ambarus
2023-07-28 12:35   ` Miquel Raynal
2023-07-28 12:35     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 3/8] mtd: rawnand: qcom: Fix alignment with open parenthesis Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:27   ` Manivannan Sadhasivam
2023-07-17  2:27     ` Manivannan Sadhasivam
2023-07-28  2:17   ` Tudor Ambarus
2023-07-28  2:17     ` Tudor Ambarus
2023-07-16 14:46 ` [PATCH 4/8] mtd: rawnand: qcom: Fix the spacing Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:28   ` Manivannan Sadhasivam
2023-07-17  2:28     ` Manivannan Sadhasivam
2023-07-28  2:18   ` Tudor Ambarus
2023-07-28  2:18     ` Tudor Ambarus
2023-07-28 12:34   ` Miquel Raynal
2023-07-28 12:34     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 5/8] mtd: rawnand: qcom: Fix wrong indentation Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:29   ` Manivannan Sadhasivam
2023-07-17  2:29     ` Manivannan Sadhasivam
2023-07-28  2:20   ` Tudor Ambarus
2023-07-28  2:20     ` Tudor Ambarus
2023-07-28 12:34   ` Miquel Raynal
2023-07-28 12:34     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 6/8] mtd: rawnand: qcom: Fix a typo Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:30   ` Manivannan Sadhasivam
2023-07-17  2:30     ` Manivannan Sadhasivam
2023-07-28  2:22   ` Tudor Ambarus
2023-07-28  2:22     ` Tudor Ambarus
2023-07-28 12:34   ` Miquel Raynal
2023-07-28 12:34     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 7/8] mtd: rawnand: qcom: Early structure initialization Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  2:31   ` Manivannan Sadhasivam
2023-07-17  2:31     ` Manivannan Sadhasivam
2023-07-27 15:03   ` Tudor Ambarus
2023-07-27 15:03     ` Tudor Ambarus
2023-07-27 15:14     ` Miquel Raynal
2023-07-27 15:14       ` Miquel Raynal
2023-07-28  2:23   ` Tudor Ambarus
2023-07-28  2:23     ` Tudor Ambarus
2023-07-28 12:34   ` Miquel Raynal
2023-07-28 12:34     ` Miquel Raynal
2023-07-16 14:46 ` [PATCH 8/8] mtd: rawnand: qcom: Fix address parsing within ->exec_op() Miquel Raynal
2023-07-16 14:46   ` Miquel Raynal
2023-07-17  6:38   ` Manivannan Sadhasivam
2023-07-17  6:38     ` Manivannan Sadhasivam
2023-07-27 14:59     ` Miquel Raynal
2023-07-27 14:59       ` Miquel Raynal
2023-07-28  2:31       ` Tudor Ambarus
2023-07-28  2:31         ` Tudor Ambarus
2023-07-28  7:56         ` Miquel Raynal
2023-07-28  7:56           ` Miquel Raynal
2023-07-28  2:33       ` Sricharan Ramabadhran
2023-07-28  2:33         ` Sricharan Ramabadhran
2023-07-28  4:14         ` Sricharan Ramabadhran
2023-07-28  4:14           ` Sricharan Ramabadhran
2023-07-28  7:55           ` Miquel Raynal
2023-07-28  7:55             ` Miquel Raynal
2023-07-28  2:27   ` Tudor Ambarus
2023-07-28  2:27     ` Tudor Ambarus
2023-07-28 12:34   ` Miquel Raynal
2023-07-28 12:34     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717022548.GA5996@thinkpad \
    --to=mani@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.