All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 1/1] arm64: dts: imx8mq: Add coresight trace components
Date: Tue, 18 Jul 2023 09:46:49 +0800	[thread overview]
Message-ID: <20230718014649.GT9559@dragon> (raw)
In-Reply-To: <20230616075914.2315189-1-alexander.stein@ew.tq-group.com>

On Fri, Jun 16, 2023 at 09:59:14AM +0200, Alexander Stein wrote:
> Add coresight trace components (ETM, ETF, ETB and Funnel).
> 
> ┌───────┐  ┌───────┐  ┌───────┐
> │ CPU0  ├─►│ ETM0  ├─►│       │
> └───────┘  └───────┘  │       │
>                       │       │
> ┌───────┐  ┌───────┐  │  ATP  │
> │ CPU1  ├─►│ ETM1  ├─►│       │
> └───────┘  └───────┘  │       │
>                       │ FUNNEL│
> ┌───────┐  ┌───────┐  │       │
> │ CPU2  ├─►│ ETM2  ├─►│       │
> └───────┘  └───────┘  │       │   ┌─────┐
>                       │       │   │     │
> ┌───────┐  ┌───────┐  │       │   │ M4  │
> │ CPU3  ├─►│ ETM3  ├─►│       │   │     │
> └───────┘  └───────┘  └───┬───┘   └──┬──┘                        AXI
>                           │          │                            ▲
>                           ▼          ▼                            │
>                       ┌───────────────────────────┐   ┌─────┐   ┌─┴──┐
>                       │          ATP FUNNEL       ├──►│ ETF ├─► │ETR │
>                       └───────────────────────────┘   └─────┘   └────┘
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> This is a 1:1 copy from commit 71c2ac9a2a3da ("arm64: dts: imx8mp: Add
> coresight trace components") with the following changes:
> * Adjust clock names
> * Replace (Cortex-)M7 with M4 in comment
> * Remove Audio DSP funnel port
> 
> This is untested, but the base addresses for the components are
> identical in the reference manuals.

I prefer to have it tested in some way before we apply it.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 1/1] arm64: dts: imx8mq: Add coresight trace components
Date: Tue, 18 Jul 2023 09:46:49 +0800	[thread overview]
Message-ID: <20230718014649.GT9559@dragon> (raw)
In-Reply-To: <20230616075914.2315189-1-alexander.stein@ew.tq-group.com>

On Fri, Jun 16, 2023 at 09:59:14AM +0200, Alexander Stein wrote:
> Add coresight trace components (ETM, ETF, ETB and Funnel).
> 
> ┌───────┐  ┌───────┐  ┌───────┐
> │ CPU0  ├─►│ ETM0  ├─►│       │
> └───────┘  └───────┘  │       │
>                       │       │
> ┌───────┐  ┌───────┐  │  ATP  │
> │ CPU1  ├─►│ ETM1  ├─►│       │
> └───────┘  └───────┘  │       │
>                       │ FUNNEL│
> ┌───────┐  ┌───────┐  │       │
> │ CPU2  ├─►│ ETM2  ├─►│       │
> └───────┘  └───────┘  │       │   ┌─────┐
>                       │       │   │     │
> ┌───────┐  ┌───────┐  │       │   │ M4  │
> │ CPU3  ├─►│ ETM3  ├─►│       │   │     │
> └───────┘  └───────┘  └───┬───┘   └──┬──┘                        AXI
>                           │          │                            ▲
>                           ▼          ▼                            │
>                       ┌───────────────────────────┐   ┌─────┐   ┌─┴──┐
>                       │          ATP FUNNEL       ├──►│ ETF ├─► │ETR │
>                       └───────────────────────────┘   └─────┘   └────┘
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> This is a 1:1 copy from commit 71c2ac9a2a3da ("arm64: dts: imx8mp: Add
> coresight trace components") with the following changes:
> * Adjust clock names
> * Replace (Cortex-)M7 with M4 in comment
> * Remove Audio DSP funnel port
> 
> This is untested, but the base addresses for the components are
> identical in the reference manuals.

I prefer to have it tested in some way before we apply it.

Shawn

  reply	other threads:[~2023-07-19  5:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  7:59 [PATCH 1/1] arm64: dts: imx8mq: Add coresight trace components Alexander Stein
2023-06-16  7:59 ` Alexander Stein
2023-07-18  1:46 ` Shawn Guo [this message]
2023-07-18  1:46   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718014649.GT9559@dragon \
    --to=shawnguo@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.