All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Han Xu <han.xu@nxp.com>,
	Haibo Chen <haibo.chen@nxp.com>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 08/10] arm64: dts: imx8ulp-evk: add spi-nor device support
Date: Tue, 18 Jul 2023 11:29:34 +0800	[thread overview]
Message-ID: <20230718032934.GC9559@dragon> (raw)
In-Reply-To: <20230625124238.4071717-9-peng.fan@oss.nxp.com>

On Sun, Jun 25, 2023 at 08:42:36PM +0800, Peng Fan (OSS) wrote:
> From: Han Xu <han.xu@nxp.com>
> 
> Add spi-nor support.
> - 8 bit mode for RX/TX.
> - Set the clock rate to 200MHz.
> - add default/sleep pinctrl.
> 
> Co-developed-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Han Xu <han.xu@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> index d66e31cf83fe..e459dc35e469 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> @@ -95,6 +95,23 @@ &cm33 {
>  	status = "okay";
>  };
>  
> +&flexspi2 {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_flexspi2_ptd>;
> +	pinctrl-1 = <&pinctrl_flexspi2_ptd>;
> +	status = "okay";
> +
> +	mx25uw51345gxdi00: flash@0 {
> +		reg = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "jedec,spi-nor";

We usually start the property list with 'compatible'.

Shawn

> +		spi-max-frequency = <200000000>;
> +		spi-tx-bus-width = <8>;
> +		spi-rx-bus-width = <8>;


> +	};
> +};
> +
>  &lpuart5 {
>  	/* console */
>  	pinctrl-names = "default", "sleep";
> @@ -159,6 +176,23 @@ MX8ULP_PAD_PTF10__ENET0_1588_CLKIN 0x43
>  		>;
>  	};
>  
> +	pinctrl_flexspi2_ptd: flexspi2ptdgrp {
> +		fsl,pins = <
> +
> +			MX8ULP_PAD_PTD12__FLEXSPI2_A_SS0_B	0x42
> +			MX8ULP_PAD_PTD13__FLEXSPI2_A_SCLK	0x42
> +			MX8ULP_PAD_PTD14__FLEXSPI2_A_DATA3	0x42
> +			MX8ULP_PAD_PTD15__FLEXSPI2_A_DATA2	0x42
> +			MX8ULP_PAD_PTD16__FLEXSPI2_A_DATA1	0x42
> +			MX8ULP_PAD_PTD17__FLEXSPI2_A_DATA0	0x42
> +			MX8ULP_PAD_PTD18__FLEXSPI2_A_DQS	0x42
> +			MX8ULP_PAD_PTD19__FLEXSPI2_A_DATA7	0x42
> +			MX8ULP_PAD_PTD20__FLEXSPI2_A_DATA6	0x42
> +			MX8ULP_PAD_PTD21__FLEXSPI2_A_DATA5	0x42
> +			MX8ULP_PAD_PTD22__FLEXSPI2_A_DATA4	0x42
> +		>;
> +	};
> +
>  	pinctrl_lpuart5: lpuart5grp {
>  		fsl,pins = <
>  			MX8ULP_PAD_PTF14__LPUART5_TX	0x3
> -- 
> 2.37.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Han Xu <han.xu@nxp.com>,
	Haibo Chen <haibo.chen@nxp.com>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 08/10] arm64: dts: imx8ulp-evk: add spi-nor device support
Date: Tue, 18 Jul 2023 11:29:34 +0800	[thread overview]
Message-ID: <20230718032934.GC9559@dragon> (raw)
In-Reply-To: <20230625124238.4071717-9-peng.fan@oss.nxp.com>

On Sun, Jun 25, 2023 at 08:42:36PM +0800, Peng Fan (OSS) wrote:
> From: Han Xu <han.xu@nxp.com>
> 
> Add spi-nor support.
> - 8 bit mode for RX/TX.
> - Set the clock rate to 200MHz.
> - add default/sleep pinctrl.
> 
> Co-developed-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Han Xu <han.xu@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> index d66e31cf83fe..e459dc35e469 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> @@ -95,6 +95,23 @@ &cm33 {
>  	status = "okay";
>  };
>  
> +&flexspi2 {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_flexspi2_ptd>;
> +	pinctrl-1 = <&pinctrl_flexspi2_ptd>;
> +	status = "okay";
> +
> +	mx25uw51345gxdi00: flash@0 {
> +		reg = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "jedec,spi-nor";

We usually start the property list with 'compatible'.

Shawn

> +		spi-max-frequency = <200000000>;
> +		spi-tx-bus-width = <8>;
> +		spi-rx-bus-width = <8>;


> +	};
> +};
> +
>  &lpuart5 {
>  	/* console */
>  	pinctrl-names = "default", "sleep";
> @@ -159,6 +176,23 @@ MX8ULP_PAD_PTF10__ENET0_1588_CLKIN 0x43
>  		>;
>  	};
>  
> +	pinctrl_flexspi2_ptd: flexspi2ptdgrp {
> +		fsl,pins = <
> +
> +			MX8ULP_PAD_PTD12__FLEXSPI2_A_SS0_B	0x42
> +			MX8ULP_PAD_PTD13__FLEXSPI2_A_SCLK	0x42
> +			MX8ULP_PAD_PTD14__FLEXSPI2_A_DATA3	0x42
> +			MX8ULP_PAD_PTD15__FLEXSPI2_A_DATA2	0x42
> +			MX8ULP_PAD_PTD16__FLEXSPI2_A_DATA1	0x42
> +			MX8ULP_PAD_PTD17__FLEXSPI2_A_DATA0	0x42
> +			MX8ULP_PAD_PTD18__FLEXSPI2_A_DQS	0x42
> +			MX8ULP_PAD_PTD19__FLEXSPI2_A_DATA7	0x42
> +			MX8ULP_PAD_PTD20__FLEXSPI2_A_DATA6	0x42
> +			MX8ULP_PAD_PTD21__FLEXSPI2_A_DATA5	0x42
> +			MX8ULP_PAD_PTD22__FLEXSPI2_A_DATA4	0x42
> +		>;
> +	};
> +
>  	pinctrl_lpuart5: lpuart5grp {
>  		fsl,pins = <
>  			MX8ULP_PAD_PTF14__LPUART5_TX	0x3
> -- 
> 2.37.1
> 

  reply	other threads:[~2023-07-19  6:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-25 12:42 [PATCH 00/10] arm64: dts: imx8ulp: add more nodes Peng Fan (OSS)
2023-06-25 12:42 ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 01/10] arm64: dts: imx8ulp: add cm33 node Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 02/10] arm64: dts: imx8ulp: set default clock for SDHC Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 03/10] arm64: dts: imx8ulp: add thermal node Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-07-18  3:30   ` Shawn Guo
2023-07-18  3:30     ` Shawn Guo
2023-06-25 12:42 ` [PATCH 04/10] arm64: dts: imx8ulp: add cpuidle node Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 05/10] arm64: dts: imx8ulp: add flexspi node Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 06/10] arm64: dts: imx8ulp-evk: add reserved memory for cma Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 07/10] arm64: dts: imx8ulp-evk: enable CM33 node Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-06-25 12:42 ` [PATCH 08/10] arm64: dts: imx8ulp-evk: add spi-nor device support Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-07-18  3:29   ` Shawn Guo [this message]
2023-07-18  3:29     ` Shawn Guo
2023-06-25 12:42 ` [PATCH 09/10] arm64: dts: imx8ulp-evk: add 100MHz/200MHz pinctrl setting for eMMC Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)
2023-07-18  3:32   ` Shawn Guo
2023-07-18  3:32     ` Shawn Guo
2023-07-24  6:51     ` Bough Chen
2023-07-30  3:04       ` Shawn Guo
2023-07-30  3:04         ` Shawn Guo
2023-06-25 12:42 ` [PATCH 10/10] arm64: dts: imx8ulp-evk: enable lpi2c7 bus Peng Fan (OSS)
2023-06-25 12:42   ` Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718032934.GC9559@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.