From: Christoph Hellwig <hch@lst.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: linux-doc@vger.kernel.org, djwong@kernel.org,
linux-nvme@lists.infradead.org, dm-devel@redhat.com,
Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
gost.dev@samsung.com, nitheshshetty@gmail.com,
willy@infradead.org, Chaitanya Kulkarni <kch@nvidia.com>,
Anuj Gupta <anuj20.g@samsung.com>,
Mike Snitzer <snitzer@kernel.org>,
ming.lei@redhat.com, linux-block@vger.kernel.org,
dlemoal@kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Keith Busch <kbusch@kernel.org>,
bvanassche@acm.org, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Kanchan Joshi <joshi.k@samsung.com>,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v13 1/9] block: Introduce queue limits for copy-offload support
Date: Thu, 20 Jul 2023 09:06:12 +0200 [thread overview]
Message-ID: <20230720070612.GA4722@lst.de> (raw)
In-Reply-To: <20230627183629.26571-2-nj.shetty@samsung.com>
Just a little heads up: I think we need to properly solve the
hw vs user limit as the various ad-hoc mechanisms tend to be
broken and don't scale. I plan to start looking into that the
next days.
On Wed, Jun 28, 2023 at 12:06:15AM +0530, Nitesh Shetty wrote:
> Add device limits as sysfs entries,
> - copy_offload (RW)
> - copy_max_bytes (RW)
> - copy_max_bytes_hw (RO)
>
> Above limits help to split the copy payload in block layer.
> copy_offload: used for setting copy offload(1) or emulation(0).
> copy_max_bytes: maximum total length of copy in single payload.
> copy_max_bytes_hw: Reflects the device supported maximum limit.
Why do we need the separate copy_offload boolean vs just looking
at the max_bytes value?
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nitesh Shetty <nj.shetty@samsung.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
willy@infradead.org, hare@suse.de, djwong@kernel.org,
bvanassche@acm.org, ming.lei@redhat.com, dlemoal@kernel.org,
nitheshshetty@gmail.com, gost.dev@samsung.com,
Kanchan Joshi <joshi.k@samsung.com>,
Anuj Gupta <anuj20.g@samsung.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v13 1/9] block: Introduce queue limits for copy-offload support
Date: Thu, 20 Jul 2023 09:06:12 +0200 [thread overview]
Message-ID: <20230720070612.GA4722@lst.de> (raw)
In-Reply-To: <20230627183629.26571-2-nj.shetty@samsung.com>
Just a little heads up: I think we need to properly solve the
hw vs user limit as the various ad-hoc mechanisms tend to be
broken and don't scale. I plan to start looking into that the
next days.
On Wed, Jun 28, 2023 at 12:06:15AM +0530, Nitesh Shetty wrote:
> Add device limits as sysfs entries,
> - copy_offload (RW)
> - copy_max_bytes (RW)
> - copy_max_bytes_hw (RO)
>
> Above limits help to split the copy payload in block layer.
> copy_offload: used for setting copy offload(1) or emulation(0).
> copy_max_bytes: maximum total length of copy in single payload.
> copy_max_bytes_hw: Reflects the device supported maximum limit.
Why do we need the separate copy_offload boolean vs just looking
at the max_bytes value?
next prev parent reply other threads:[~2023-07-20 7:06 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230627183950epcas5p1b924785633509f612ffa5d9616bfe447@epcas5p1.samsung.com>
2023-06-27 18:36 ` [dm-devel] [PATCH v13 0/9] Implement copy offload support Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 1/9] block: Introduce queue limits for copy-offload support Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-28 6:40 ` [dm-devel] " Damien Le Moal
2023-06-28 6:40 ` Damien Le Moal
2023-06-28 15:35 ` [dm-devel] " Nitesh Shetty
2023-06-28 15:35 ` Nitesh Shetty
2023-07-20 7:06 ` Christoph Hellwig [this message]
2023-07-20 7:06 ` Christoph Hellwig
2023-07-20 7:58 ` [dm-devel] " Christoph Hellwig
2023-07-20 7:58 ` Christoph Hellwig
2023-06-27 18:36 ` [dm-devel] [PATCH v13 2/9] block: Add copy offload support infrastructure Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-28 6:45 ` [dm-devel] " Damien Le Moal
2023-06-28 6:45 ` Damien Le Moal
2023-06-28 16:03 ` [dm-devel] " Nitesh Shetty
2023-06-28 16:03 ` Nitesh Shetty
2023-07-20 7:42 ` [dm-devel] " Christoph Hellwig
2023-07-20 7:42 ` Christoph Hellwig
2023-07-27 10:29 ` [dm-devel] " Nitesh Shetty
2023-07-27 10:29 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 3/9] block: add emulation for copy Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-28 6:50 ` [dm-devel] " Damien Le Moal
2023-06-28 6:50 ` Damien Le Moal
2023-06-28 16:10 ` [dm-devel] " Nitesh Shetty
2023-06-28 16:10 ` Nitesh Shetty
2023-06-29 8:33 ` [dm-devel] " Ming Lei
2023-06-29 8:33 ` Ming Lei
2023-06-30 11:22 ` [dm-devel] " Nitesh Shetty
2023-06-30 11:22 ` Nitesh Shetty
2023-07-20 7:50 ` [dm-devel] " Christoph Hellwig
2023-07-20 7:50 ` Christoph Hellwig
2023-08-01 13:07 ` [dm-devel] " Nitesh Shetty
2023-08-01 13:07 ` Nitesh Shetty
2023-08-02 6:31 ` [dm-devel] " Kent Overstreet
2023-08-02 6:31 ` Kent Overstreet
2023-06-27 18:36 ` [dm-devel] [PATCH v13 4/9] fs, block: copy_file_range for def_blk_ops for direct block device Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-28 6:51 ` [dm-devel] " Damien Le Moal
2023-06-28 6:51 ` Damien Le Moal
2023-06-28 16:39 ` [dm-devel] " Nitesh Shetty
2023-06-28 16:39 ` Nitesh Shetty
2023-07-20 7:57 ` [dm-devel] " Christoph Hellwig
2023-07-20 7:57 ` Christoph Hellwig
2023-07-24 5:46 ` [dm-devel] " Nitesh Shetty
2023-07-24 5:46 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 5/9] nvme: add copy offload support Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-07-20 8:00 ` [dm-devel] " Christoph Hellwig
2023-07-20 8:00 ` Christoph Hellwig
2023-06-27 18:36 ` [dm-devel] [PATCH v13 6/9] nvmet: add copy command support for bdev and file ns Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 7/9] dm: Add support for copy offload Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 8/9] dm: Enable copy offload for dm-linear target Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-27 18:36 ` [dm-devel] [PATCH v13 9/9] null_blk: add support for copy offload Nitesh Shetty
2023-06-27 18:36 ` Nitesh Shetty
2023-06-28 12:11 ` [dm-devel] " kernel test robot
2023-06-28 12:11 ` kernel test robot
2023-06-28 12:52 ` [dm-devel] " kernel test robot
2023-06-28 12:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720070612.GA4722@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.