From: Daniel Thompson <daniel.thompson@linaro.org>
To: Ying Liu <victor.liu@nxp.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lee@kernel.org" <lee@kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"deller@gmx.de" <deller@gmx.de>,
"andy@kernel.org" <andy@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>
Subject: Re: [PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state
Date: Fri, 21 Jul 2023 09:42:51 +0100 [thread overview]
Message-ID: <20230721084251.GF2525277@aspen.lan> (raw)
In-Reply-To: <20230721073555.1377236-1-victor.liu@nxp.com>
On Fri, Jul 21, 2023 at 07:31:37AM +0000, Ying Liu wrote:
> If gpio pin is in input state but backlight is currently off due to
> default pull downs, then initial power state is set to FB_BLANK_UNBLANK
> in DT boot mode with phandle link and the backlight is effectively
> turned on in gpio_backlight_probe(), which is undesirable according to
> patch description of commit ec665b756e6f ("backlight: gpio-backlight:
> Correct initial power state handling").
>
> Quote:
> ---
> If in DT boot we have phandle link then leave the GPIO in a state which the
> bootloader left it and let the user of the backlight to configure it further.
> ---
>
> So, let's drop output gpio direction check and only check gpio value to set
> the initial power state.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Based on the discussion for v1 about 706dc68102bc ("backlight: gpio:
Explicitly set the direction of the GPIO"), I think there should
be a Fixes: tag here.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Ying Liu <victor.liu@nxp.com>
Cc: "andy@kernel.org" <andy@kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"deller@gmx.de" <deller@gmx.de>,
"lee@kernel.org" <lee@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"brgl@bgdev.pl" <brgl@bgdev.pl>
Subject: Re: [PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state
Date: Fri, 21 Jul 2023 09:42:51 +0100 [thread overview]
Message-ID: <20230721084251.GF2525277@aspen.lan> (raw)
In-Reply-To: <20230721073555.1377236-1-victor.liu@nxp.com>
On Fri, Jul 21, 2023 at 07:31:37AM +0000, Ying Liu wrote:
> If gpio pin is in input state but backlight is currently off due to
> default pull downs, then initial power state is set to FB_BLANK_UNBLANK
> in DT boot mode with phandle link and the backlight is effectively
> turned on in gpio_backlight_probe(), which is undesirable according to
> patch description of commit ec665b756e6f ("backlight: gpio-backlight:
> Correct initial power state handling").
>
> Quote:
> ---
> If in DT boot we have phandle link then leave the GPIO in a state which the
> bootloader left it and let the user of the backlight to configure it further.
> ---
>
> So, let's drop output gpio direction check and only check gpio value to set
> the initial power state.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Based on the discussion for v1 about 706dc68102bc ("backlight: gpio:
Explicitly set the direction of the GPIO"), I think there should
be a Fixes: tag here.
Daniel.
next prev parent reply other threads:[~2023-07-21 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 7:31 [PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state Ying Liu
2023-07-21 7:31 ` Ying Liu
2023-07-21 8:42 ` Daniel Thompson [this message]
2023-07-21 8:42 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721084251.GF2525277@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.