From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, stable@vger.kernel.org
Subject: Re: [PATCH stable 5.15.y] erofs: fix compact 4B support for 16k block size
Date: Fri, 21 Jul 2023 07:29:26 +0200 [thread overview]
Message-ID: <2023072115-problem-cleaver-9f4b@gregkh> (raw)
In-Reply-To: <20230721022221.23060-1-hsiangkao@linux.alibaba.com>
On Fri, Jul 21, 2023 at 10:22:21AM +0800, Gao Xiang wrote:
> commit 001b8ccd0650727e54ec16ef72bf1b8eeab7168e upstream.
>
> In compact 4B, two adjacent lclusters are packed together as a unit to
> form on-disk indexes for effective random access, as below:
>
> (amortized = 4, vcnt = 2)
> _____________________________________________
> |___@_____ encoded bits __________|_ blkaddr _|
> 0 . amortized * vcnt = 8
> . .
> . . amortized * vcnt - 4 = 4
> . .
> .____________________________.
> |_type (2 bits)_|_clusterofs_|
>
> Therefore, encoded bits for each pack are 32 bits (4 bytes). IOWs,
> since each lcluster can get 16 bits for its type and clusterofs, the
> maximum supported lclustersize for compact 4B format is 16k (14 bits).
>
> Fix this to enable compact 4B format for 16k lclusters (blocks), which
> is tested on an arm64 server with 16k page size.
>
> Fixes: 152a333a5895 ("staging: erofs: add compacted compression indexes support")
> Link: https://lore.kernel.org/r/20230601112341.56960-1-hsiangkao@linux.alibaba.com
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> resolve a trivial conflict.
All now queued up.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: stable@vger.kernel.org, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH stable 5.15.y] erofs: fix compact 4B support for 16k block size
Date: Fri, 21 Jul 2023 07:29:26 +0200 [thread overview]
Message-ID: <2023072115-problem-cleaver-9f4b@gregkh> (raw)
In-Reply-To: <20230721022221.23060-1-hsiangkao@linux.alibaba.com>
On Fri, Jul 21, 2023 at 10:22:21AM +0800, Gao Xiang wrote:
> commit 001b8ccd0650727e54ec16ef72bf1b8eeab7168e upstream.
>
> In compact 4B, two adjacent lclusters are packed together as a unit to
> form on-disk indexes for effective random access, as below:
>
> (amortized = 4, vcnt = 2)
> _____________________________________________
> |___@_____ encoded bits __________|_ blkaddr _|
> 0 . amortized * vcnt = 8
> . .
> . . amortized * vcnt - 4 = 4
> . .
> .____________________________.
> |_type (2 bits)_|_clusterofs_|
>
> Therefore, encoded bits for each pack are 32 bits (4 bytes). IOWs,
> since each lcluster can get 16 bits for its type and clusterofs, the
> maximum supported lclustersize for compact 4B format is 16k (14 bits).
>
> Fix this to enable compact 4B format for 16k lclusters (blocks), which
> is tested on an arm64 server with 16k page size.
>
> Fixes: 152a333a5895 ("staging: erofs: add compacted compression indexes support")
> Link: https://lore.kernel.org/r/20230601112341.56960-1-hsiangkao@linux.alibaba.com
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> resolve a trivial conflict.
All now queued up.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-21 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 2:22 [PATCH stable 5.15.y] erofs: fix compact 4B support for 16k block size Gao Xiang
2023-07-21 5:29 ` Greg Kroah-Hartman [this message]
2023-07-21 5:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072115-problem-cleaver-9f4b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.