* [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU
@ 2023-07-23 11:20 Cherniaev Andrei
2023-07-23 13:56 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Cherniaev Andrei @ 2023-07-23 11:20 UTC (permalink / raw)
To: buildroot; +Cc: Cherniaev Andrei, bagasdotme
Currently, there is no MMX support for modern GEODE processors in Buildroot.
Yet, some packages like ffmpeg can leverage it when the package is built.
Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
arch/Config.in.x86 | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
index c770ae3ffe..288d274b0e 100644
--- a/arch/Config.in.x86
+++ b/arch/Config.in.x86
@@ -521,11 +521,24 @@ config BR2_x86_steamroller
select BR2_X86_CPU_HAS_SSE4
select BR2_X86_CPU_HAS_SSE42
config BR2_x86_geode
- bool "geode"
- # Don't include MMX support because there several variant of geode
- # processor, some with MMX support, some without.
- # See: http://en.wikipedia.org/wiki/Geode_%28processor%29
+ bool "geode (no mmx)"
+ help
+ For several variant of geode which have not MMX support.
+ See
+ https://en.wikipedia.org/wiki/Geode_%28processor%29 to
+ determine if your particular Geode processor supports MMX or
+ not.
+ depends on !BR2_x86_64
+config BR2_x86_geode_mmx
+ bool "geode (with mmx)"
+ help
+ For several variant of geode which have MMX support.
+ See
+ https://en.wikipedia.org/wiki/Geode_%28processor%29 to
+ determine if your particular Geode processor supports MMX or
+ not.
depends on !BR2_x86_64
+ select BR2_X86_CPU_HAS_MMX
config BR2_x86_c3
bool "Via/Cyrix C3 (Samuel/Ezra cores)"
depends on !BR2_x86_64
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU
2023-07-23 11:20 [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU Cherniaev Andrei
@ 2023-07-23 13:56 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2023-07-23 13:56 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: bagasdotme, buildroot
Cherniaev Andrei, All,
On 2023-07-23 20:20 +0900, Cherniaev Andrei spake thusly:
> Currently, there is no MMX support for modern GEODE processors in Buildroot.
> Yet, some packages like ffmpeg can leverage it when the package is built.
>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
> ---
> arch/Config.in.x86 | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index c770ae3ffe..288d274b0e 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -521,11 +521,24 @@ config BR2_x86_steamroller
> select BR2_X86_CPU_HAS_SSE4
> select BR2_X86_CPU_HAS_SSE42
> config BR2_x86_geode
> - bool "geode"
> - # Don't include MMX support because there several variant of geode
> - # processor, some with MMX support, some without.
> - # See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> + bool "geode (no mmx)"
> + help
> + For several variant of geode which have not MMX support.
> + See
> + https://en.wikipedia.org/wiki/Geode_%28processor%29 to
> + determine if your particular Geode processor supports MMX or
> + not.
> + depends on !BR2_x86_64
> +config BR2_x86_geode_mmx
> + bool "geode (with mmx)"
> + help
> + For several variant of geode which have MMX support.
> + See
> + https://en.wikipedia.org/wiki/Geode_%28processor%29 to
> + determine if your particular Geode processor supports MMX or
> + not.
> depends on !BR2_x86_64
> + select BR2_X86_CPU_HAS_MMX
$ make check-package
arch/Config.in.x86:531: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
arch/Config.in.x86:531: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
arch/Config.in.x86:540: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
arch/Config.in.x86:540: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
arch/Config.in.x86:541: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
I've fixed that when applying (the help text errors are spurious, due to
the previous order issue; still I did reflow them too).
Applied to master with those fixes, thanks.
Regards,
Yann E. MORIN.
> config BR2_x86_c3
> bool "Via/Cyrix C3 (Samuel/Ezra cores)"
> depends on !BR2_x86_64
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU
@ 2023-07-16 11:00 Cherniaev Andrei
2023-07-18 20:37 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Cherniaev Andrei @ 2023-07-16 11:00 UTC (permalink / raw)
To: buildroot; +Cc: AndreiCherniaev, bagasdotme
From: AndreiCherniaev <dungeonlords789@naver.com>
Currently, there is no MMX support for modern GEODE processors in Buildroot.
Yet, some packages like ffmpeg can leverage it when the package is built.
Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
arch/Config.in.x86 | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
index c770ae3ffe..595db48d91 100644
--- a/arch/Config.in.x86
+++ b/arch/Config.in.x86
@@ -521,11 +521,10 @@ config BR2_x86_steamroller
select BR2_X86_CPU_HAS_SSE4
select BR2_X86_CPU_HAS_SSE42
config BR2_x86_geode
- bool "geode"
- # Don't include MMX support because there several variant of geode
- # processor, some with MMX support, some without.
- # See: http://en.wikipedia.org/wiki/Geode_%28processor%29
- depends on !BR2_x86_64
+ bool "geode"
+ depends on !BR2_x86_64
+ help
+ see also BR2_x86_geode_with_MMX
config BR2_x86_c3
bool "Via/Cyrix C3 (Samuel/Ezra cores)"
depends on !BR2_x86_64
@@ -633,5 +632,16 @@ config BR2_READELF_ARCH_NAME
default "Intel 80386" if BR2_i386
default "Advanced Micro Devices X86-64" if BR2_x86_64
+config BR2_x86_geode_with_MMX
+ bool "GEODE with MMX"
+ depends on BR2_x86_geode
+ default n
+ select BR2_X86_CPU_HAS_MMX
+ help
+ there several variant of geode processor,
+ some with MMX support, some without.
+ See: http://en.wikipedia.org/wiki/Geode_%28processor%29
+ And decide can you use MMX or not
+
# vim: ft=kconfig
# -*- mode:kconfig; -*-
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU
2023-07-16 11:00 Cherniaev Andrei
@ 2023-07-18 20:37 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-18 20:37 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: bagasdotme, buildroot
Hello Andrei,
Thanks for your patch! See some comments below.
On Sun, 16 Jul 2023 20:00:38 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:
> From: AndreiCherniaev <dungeonlords789@naver.com>
>
> Currently, there is no MMX support for modern GEODE processors in Buildroot.
> Yet, some packages like ffmpeg can leverage it when the package is built.
>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
Could you please adjust your git configuration so that the From: field
value and the Signed-off-by: field value are matching?
> ---
> arch/Config.in.x86 | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index c770ae3ffe..595db48d91 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -521,11 +521,10 @@ config BR2_x86_steamroller
> select BR2_X86_CPU_HAS_SSE4
> select BR2_X86_CPU_HAS_SSE42
> config BR2_x86_geode
> - bool "geode"
> - # Don't include MMX support because there several variant of geode
> - # processor, some with MMX support, some without.
> - # See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> - depends on !BR2_x86_64
> + bool "geode"
> + depends on !BR2_x86_64
> + help
> + see also BR2_x86_geode_with_MMX
Please don't change the indentation. Also, please keep the comment,
but adapt it to the new reality. The help text that you have added is
not very useful, just don't add a help text in this case.
> config BR2_x86_c3
> bool "Via/Cyrix C3 (Samuel/Ezra cores)"
> depends on !BR2_x86_64
> @@ -633,5 +632,16 @@ config BR2_READELF_ARCH_NAME
> default "Intel 80386" if BR2_i386
> default "Advanced Micro Devices X86-64" if BR2_x86_64
>
> +config BR2_x86_geode_with_MMX
This should go inside the choice...endchoice to select the CPU variant,
i.e it should be treated as another CPU variant.
Please name the option BR2_x86_geode_mmx
> + bool "GEODE with MMX"
bool "geode with MMX"
> + depends on BR2_x86_geode
Drop this, not relevant once it is part of the choice...endchoice of
CPU variants.
> + default n
Not needed, a boolean is already disabled by default.
> + select BR2_X86_CPU_HAS_MMX
> + help
> + there several variant of geode processor,
> + some with MMX support, some without.
> + See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> + And decide can you use MMX or not
Either convert that into a comment, or if it's a help text, there
should also be a help text for the Geode without MMX option, and it
should probably be something like this:
There are several variants of the Geode processors, some
supporting MMX instructions, some not. See
https://en.wikipedia.org/wiki/Geode_%28processor%29 to
determine if your particular Geode processor supports MMX or
not.
Could you adjust your patch according to those suggestions and send a
new iteration?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-23 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 11:20 [Buildroot] [PATCH 1/1] arch/Config.in.x86: add MMX instruction set capability for Geode CPU Cherniaev Andrei
2023-07-23 13:56 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2023-07-16 11:00 Cherniaev Andrei
2023-07-18 20:37 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.