From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: "Simon Glass" <sjg@chromium.org>,
"Leo Yu-Chi Liang" <ycliang@andestech.com>,
"Marek Vasut" <marex@denx.de>,
"Mayuresh Chitale" <mchitale@ventanamicro.com>,
"Pali Rohár" <pali@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
"Nikita Shubin" <n.shubin@yadro.com>,
"Roger Quadros" <rogerq@kernel.org>, "Stefan Roese" <sr@denx.de>,
"Michal Simek" <michal.simek@amd.com>,
"Mark Kettenis" <kettenis@openbsd.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI
Date: Mon, 24 Jul 2023 11:14:10 -0400 [thread overview]
Message-ID: <20230724151410.GU3630934@bill-the-cat> (raw)
In-Reply-To: <20230724070310.23790-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Mon, Jul 24, 2023 at 09:03:10AM +0200, Heinrich Schuchardt wrote:
> CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense.
>
> Move CONFIG_SPL_PCI_PNP to the SPL menu and add the missing dependency.
>
> Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> common/spl/Kconfig | 12 ++++++++++++
> drivers/pci/Kconfig | 11 -----------
> 2 files changed, 12 insertions(+), 11 deletions(-)
Lets not move this out of drivers/pci/Kconfig, just add the dependency.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-07-24 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 7:03 [PATCH] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI Heinrich Schuchardt
2023-07-24 7:51 ` Leo Liang
2023-07-24 14:53 ` Simon Glass
2023-07-24 15:14 ` Tom Rini [this message]
2023-07-24 17:46 ` Heinrich Schuchardt
2023-07-24 17:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724151410.GU3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=kettenis@openbsd.org \
--cc=marex@denx.de \
--cc=mchitale@ventanamicro.com \
--cc=michal.simek@amd.com \
--cc=n.shubin@yadro.com \
--cc=pali@kernel.org \
--cc=peng.fan@nxp.com \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.