All of lore.kernel.org
 help / color / mirror / Atom feed
* + acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch added to mm-unstable branch
@ 2023-07-24 18:00 Andrew Morton
  2023-07-25  0:43 ` Huang, Ying
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2023-07-24 18:00 UTC (permalink / raw)
  To: mm-commits, ying.huang, akpm, akpm


The patch titled
     Subject: acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
has been added to the -mm mm-unstable branch.  Its filename is
     acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
Date: Mon Jul 24 10:59:52 AM PDT 2023


WARNING: Avoid logging continuation uses where feasible
#54: FILE: drivers/acpi/numa/hmat.c:768:
+	pr_cont("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n",

WARNING: __meminitdata should be placed after hmat_adist_nb
#174: FILE: drivers/acpi/numa/hmat.c:888:
+static __meminitdata struct notifier_block hmat_adist_nb =

ERROR: that open brace { should be on the previous line
#175: FILE: drivers/acpi/numa/hmat.c:889:
+static __meminitdata struct notifier_block hmat_adist_nb =
+{

WARNING: From:/Signed-off-by: email name mismatch: 'From: Huang Ying <ying.huang@intel.com>' != 'Signed-off-by: "Huang, Ying" <ying.huang@intel.com>'

total: 1 errors, 3 warnings, 185 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/acpi-hmat-calculate-abstract-distance-with-hmat.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Huang, Ying" <ying.huang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/acpi/numa/hmat.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/acpi/numa/hmat.c~acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
+++ a/drivers/acpi/numa/hmat.c
@@ -885,8 +885,7 @@ static int hmat_calculate_adistance(stru
 	return NOTIFY_STOP;
 }
 
-static __meminitdata struct notifier_block hmat_adist_nb =
-{
+static __meminitdata struct notifier_block hmat_adist_nb = {
 	.notifier_call = hmat_calculate_adistance,
 	.priority = 100,
 };
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm-shmem-fix-race-in-shmem_undo_range-w-thp-fix.patch
swap-stop-add-to-avail-list-is-swap-is-full-checkpatch-fixes.patch
fs-buffer-clean-up-block_commit_write-fix.patch
mm-page_alloc-avoid-false-page-outside-zone-error-info-fix.patch
mm-make-pte_marker_swapin_error-more-general-fix.patch
selinux-use-vma_is_stack-and-vma_is_heap-fix.patch
mm-kfence-allocate-kfence_metadata-at-runtime-fix.patch
acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch
signal-print-comm-and-exe-name-on-fatal-signals-fix.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: + acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch added to mm-unstable branch
  2023-07-24 18:00 + acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch added to mm-unstable branch Andrew Morton
@ 2023-07-25  0:43 ` Huang, Ying
  0 siblings, 0 replies; 2+ messages in thread
From: Huang, Ying @ 2023-07-25  0:43 UTC (permalink / raw)
  To: Andrew Morton; +Cc: mm-commits

Andrew Morton <akpm@linux-foundation.org> writes:

> The patch titled
>      Subject: acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
> has been added to the -mm mm-unstable branch.  Its filename is
>      acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch
>
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch
>
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
> Date: Mon Jul 24 10:59:52 AM PDT 2023
>
>
> WARNING: Avoid logging continuation uses where feasible
> #54: FILE: drivers/acpi/numa/hmat.c:768:
> +	pr_cont("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n",
>
> WARNING: __meminitdata should be placed after hmat_adist_nb
> #174: FILE: drivers/acpi/numa/hmat.c:888:
> +static __meminitdata struct notifier_block hmat_adist_nb =
>
> ERROR: that open brace { should be on the previous line
> #175: FILE: drivers/acpi/numa/hmat.c:889:
> +static __meminitdata struct notifier_block hmat_adist_nb =
> +{
>
> WARNING: From:/Signed-off-by: email name mismatch: 'From: Huang Ying <ying.huang@intel.com>' != 'Signed-off-by: "Huang, Ying" <ying.huang@intel.com>'
>
> total: 1 errors, 3 warnings, 185 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> ./patches/acpi-hmat-calculate-abstract-distance-with-hmat.patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Please run checkpatch prior to sending patches

Sorry, should fix that before sending.  Will do that in the future.

--
Best Regards,
Huang, Ying

> Cc: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  drivers/acpi/numa/hmat.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/acpi/numa/hmat.c~acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
> +++ a/drivers/acpi/numa/hmat.c
> @@ -885,8 +885,7 @@ static int hmat_calculate_adistance(stru
>  	return NOTIFY_STOP;
>  }
>  
> -static __meminitdata struct notifier_block hmat_adist_nb =
> -{
> +static __meminitdata struct notifier_block hmat_adist_nb = {
>  	.notifier_call = hmat_calculate_adistance,
>  	.priority = 100,
>  };
> _
>
> Patches currently in -mm which might be from akpm@linux-foundation.org are
>
> mm-shmem-fix-race-in-shmem_undo_range-w-thp-fix.patch
> swap-stop-add-to-avail-list-is-swap-is-full-checkpatch-fixes.patch
> fs-buffer-clean-up-block_commit_write-fix.patch
> mm-page_alloc-avoid-false-page-outside-zone-error-info-fix.patch
> mm-make-pte_marker_swapin_error-more-general-fix.patch
> selinux-use-vma_is_stack-and-vma_is_heap-fix.patch
> mm-kfence-allocate-kfence_metadata-at-runtime-fix.patch
> acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch
> signal-print-comm-and-exe-name-on-fatal-signals-fix.patch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-25  0:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-24 18:00 + acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes.patch added to mm-unstable branch Andrew Morton
2023-07-25  0:43 ` Huang, Ying

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.