From: Jakub Kicinski <kuba@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@kernel.org>,
Simon Horman <simon.horman@corigine.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
<srk@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats
Date: Tue, 25 Jul 2023 20:50:14 -0700 [thread overview]
Message-ID: <20230725205014.04e4bba3@kernel.org> (raw)
In-Reply-To: <20230724112934.2637802-8-danishanwar@ti.com>
On Mon, 24 Jul 2023 16:59:31 +0530 MD Danish Anwar wrote:
> + /* Rx */
> + ICSSG_STATS(rx_packets, true),
> + ICSSG_STATS(rx_broadcast_frames, false),
> + ICSSG_STATS(rx_multicast_frames, false),
There is a standard stat for mcast.
> + ICSSG_STATS(rx_crc_errors, true),
> + ICSSG_STATS(rx_mii_error_frames, false),
> + ICSSG_STATS(rx_odd_nibble_frames, false),
> + ICSSG_STATS(rx_frame_max_size, false),
> + ICSSG_STATS(rx_max_size_error_frames, false),
> + ICSSG_STATS(rx_frame_min_size, false),
> + ICSSG_STATS(rx_min_size_error_frames, false),
> + ICSSG_STATS(rx_over_errors, true),
> + ICSSG_STATS(rx_class0_hits, false),
> + ICSSG_STATS(rx_class1_hits, false),
> + ICSSG_STATS(rx_class2_hits, false),
> + ICSSG_STATS(rx_class3_hits, false),
> + ICSSG_STATS(rx_class4_hits, false),
> + ICSSG_STATS(rx_class5_hits, false),
> + ICSSG_STATS(rx_class6_hits, false),
> + ICSSG_STATS(rx_class7_hits, false),
> + ICSSG_STATS(rx_class8_hits, false),
> + ICSSG_STATS(rx_class9_hits, false),
> + ICSSG_STATS(rx_class10_hits, false),
> + ICSSG_STATS(rx_class11_hits, false),
> + ICSSG_STATS(rx_class12_hits, false),
> + ICSSG_STATS(rx_class13_hits, false),
> + ICSSG_STATS(rx_class14_hits, false),
> + ICSSG_STATS(rx_class15_hits, false),
> + ICSSG_STATS(rx_smd_frags, false),
> + ICSSG_STATS(rx_bucket1_size, false),
> + ICSSG_STATS(rx_bucket2_size, false),
> + ICSSG_STATS(rx_bucket3_size, false),
> + ICSSG_STATS(rx_bucket4_size, false),
Are the bucket sizes configurable? Can we set the bucket sizes
to standard RMON ones and use ethtool RMON stats?
next prev parent reply other threads:[~2023-07-26 3:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 11:29 [PATCH v11 00/10] Introduce ICSSG based ethernet Driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 01/10] net: ti: icssg-prueth: Add Firmware Interface for ICSSG Ethernet driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 02/10] net: ti: icssg-prueth: Add mii helper apis and macros MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 03/10] net: ti: icssg-prueth: Add Firmware config and classification APIs MD Danish Anwar
2023-07-25 7:25 ` Simon Horman
2023-07-25 7:40 ` [EXTERNAL] " Md Danish Anwar
2023-07-25 7:44 ` Simon Horman
2023-07-25 7:58 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 7:42 ` Simon Horman
2023-07-26 15:40 ` Jakub Kicinski
2023-07-27 8:54 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 8:54 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 04/10] net: ti: icssg-prueth: Add icssg queues APIs and macros MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 05/10] dt-bindings: net: Add ICSSG Ethernet MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2023-07-26 4:09 ` Jakub Kicinski
2023-07-26 10:31 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 15:37 ` Jakub Kicinski
2023-07-27 9:12 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 9:12 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats MD Danish Anwar
2023-07-26 3:50 ` Jakub Kicinski [this message]
2023-07-26 10:36 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 15:39 ` Jakub Kicinski
2023-07-27 4:51 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 4:51 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 08/10] net: ti: icssg-prueth: Add Standard network staticstics MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 09/10] net: ti: icssg-prueth: Add ethtool ops for ICSSG Ethernet driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 10/10] net: ti: icssg-prueth: Add Power management support MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725205014.04e4bba3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=simon.horman@corigine.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.