From: Jakub Kicinski <kuba@kernel.org>
To: Md Danish Anwar <a0501179@ti.com>
Cc: MD Danish Anwar <danishanwar@ti.com>,
Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@kernel.org>,
Simon Horman <simon.horman@corigine.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
<srk@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXTERNAL] Re: [PATCH v11 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Wed, 26 Jul 2023 08:37:07 -0700 [thread overview]
Message-ID: <20230726083707.623da581@kernel.org> (raw)
In-Reply-To: <9b11e602-6503-863a-f825-b595effd5e1d@ti.com>
On Wed, 26 Jul 2023 16:01:23 +0530 Md Danish Anwar wrote:
> I think MAX_SKB_FRAGS is OK. If the available pool = MAX_SKB_FRAGS we should be
> able to wake the queue.
MAX_SKB_FRAGS only counts frags and you also need space to map the head, no?
In general we advise to wait until there's at least 2 * MAX_SKB_FRAGS
to avoid frequent sleep/wake cycles. But IDK how long your queue is,
maybe it's too much.
> No I don't think any lock is required here. emac_set_port_state() aquires lock
> before updating port status. Also emac_ndo_set_rx_mode_work() is scheduled by a
> singlethreaded workqueue.
if (netif_running()) outside of any locks is usually a red flag, but if
you're confident it's fine it's fine :)
next prev parent reply other threads:[~2023-07-26 15:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 11:29 [PATCH v11 00/10] Introduce ICSSG based ethernet Driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 01/10] net: ti: icssg-prueth: Add Firmware Interface for ICSSG Ethernet driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 02/10] net: ti: icssg-prueth: Add mii helper apis and macros MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 03/10] net: ti: icssg-prueth: Add Firmware config and classification APIs MD Danish Anwar
2023-07-25 7:25 ` Simon Horman
2023-07-25 7:40 ` [EXTERNAL] " Md Danish Anwar
2023-07-25 7:44 ` Simon Horman
2023-07-25 7:58 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 7:42 ` Simon Horman
2023-07-26 15:40 ` Jakub Kicinski
2023-07-27 8:54 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 8:54 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 04/10] net: ti: icssg-prueth: Add icssg queues APIs and macros MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 05/10] dt-bindings: net: Add ICSSG Ethernet MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2023-07-26 4:09 ` Jakub Kicinski
2023-07-26 10:31 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 15:37 ` Jakub Kicinski [this message]
2023-07-27 9:12 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 9:12 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 07/10] net: ti: icssg-prueth: Add ICSSG Stats MD Danish Anwar
2023-07-26 3:50 ` Jakub Kicinski
2023-07-26 10:36 ` [EXTERNAL] " Md Danish Anwar
2023-07-26 15:39 ` Jakub Kicinski
2023-07-27 4:51 ` [EXTERNAL] " Anwar, Md Danish
2023-07-27 4:51 ` Anwar, Md Danish
2023-07-24 11:29 ` [PATCH v11 08/10] net: ti: icssg-prueth: Add Standard network staticstics MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 09/10] net: ti: icssg-prueth: Add ethtool ops for ICSSG Ethernet driver MD Danish Anwar
2023-07-24 11:29 ` [PATCH v11 10/10] net: ti: icssg-prueth: Add Power management support MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726083707.623da581@kernel.org \
--to=kuba@kernel.org \
--cc=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=simon.horman@corigine.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.