From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Glenn Washburn <development@efficientek.com>
Subject: [PATCH] term/serial: Continue processing SPCR table even if revision is < 2
Date: Wed, 26 Jul 2023 16:02:36 -0500 [thread overview]
Message-ID: <20230726210236.1393757-1-development@efficientek.com> (raw)
According to commit 0231d00082 ("ACPI: SPCR: Make SPCR available to x86")
to the Linux kernel, "On x86, many systems have a valid SPCR table but the
table version is not 2 so the table version check must be a warning."
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
grub-core/term/ns8250-spcr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/grub-core/term/ns8250-spcr.c b/grub-core/term/ns8250-spcr.c
index d101bffb512d..d52b52c26561 100644
--- a/grub-core/term/ns8250-spcr.c
+++ b/grub-core/term/ns8250-spcr.c
@@ -18,6 +18,7 @@
#if !defined(GRUB_MACHINE_IEEE1275) && !defined(GRUB_MACHINE_QEMU)
+#include <grub/misc.h>
#include <grub/serial.h>
#include <grub/ns8250.h>
#include <grub/types.h>
@@ -34,7 +35,8 @@ grub_ns8250_spcr_init (void)
if (spcr == NULL)
return NULL;
if (spcr->hdr.revision < 2)
- return NULL;
+ grub_dprintf ("serial", "SPCR table revision %d < 2, continuing anyway\n",
+ (int) spcr->hdr.revision);
if (spcr->intf_type != GRUB_ACPI_SPCR_INTF_TYPE_16550 &&
spcr->intf_type != GRUB_ACPI_SPCR_INTF_TYPE_16550X)
return NULL;
--
2.34.1
next reply other threads:[~2023-07-26 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 21:02 Glenn Washburn [this message]
2023-07-27 1:55 ` [PATCH] term/serial: Continue processing SPCR table even if revision is < 2 Benjamin Herrenschmidt
2023-08-11 15:53 ` Daniel Kiper
2023-08-14 3:12 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726210236.1393757-1-development@efficientek.com \
--to=development@efficientek.com \
--cc=benh@kernel.crashing.org \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.