From: Greg KH <gregkh@linuxfoundation.org>
To: Alexon Oliveira <alexondunkan@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis
Date: Thu, 27 Jul 2023 10:03:19 +0200 [thread overview]
Message-ID: <2023072729-sensitive-spyglass-ec96@gregkh> (raw)
In-Reply-To: <ZKjeHx/zqrNIqaA6@alolivei-thinkpadt480s.gru.csb>
On Sat, Jul 08, 2023 at 12:55:11AM -0300, Alexon Oliveira wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> #132: FILE: drivers/staging/vme_user/vme_bridge.h:132
> #135: FILE: drivers/staging/vme_user/vme_bridge.h:135
> #139: FILE: drivers/staging/vme_user/vme_bridge.h:139
> #142: FILE: drivers/staging/vme_user/vme_bridge.h:142
> #144: FILE: drivers/staging/vme_user/vme_bridge.h:144
> #146: FILE: drivers/staging/vme_user/vme_bridge.h:146
> #148: FILE: drivers/staging/vme_user/vme_bridge.h:148
> #152: FILE: drivers/staging/vme_user/vme_bridge.h:152
> #163: FILE: drivers/staging/vme_user/vme_bridge.h:163
> #173: FILE: drivers/staging/vme_user/vme_bridge.h:173
> #175: FILE: drivers/staging/vme_user/vme_bridge.h:175
We don't need all of these lines.
> Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>
Please don't indent your signed-off-by line, that should be to the left.
>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 11df0a5e7f7b..a0d7a8db239d 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -128,28 +128,21 @@ struct vme_bridge {
> struct mutex irq_mtx;
>
> /* Slave Functions */
> - int (*slave_get)(struct vme_slave_resource *, int *,
> - unsigned long long *, unsigned long long *, dma_addr_t *,
> - u32 *, u32 *);
> - int (*slave_set)(struct vme_slave_resource *, int, unsigned long long,
> - unsigned long long, dma_addr_t, u32, u32);
> + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *,
> + unsigned long long *, dma_addr_t *, u32 *, u32 *);
> + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32);
Did you run your patch through checkpatch.pl after making this change?
I think you just added more warnings...
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-27 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 3:55 [PATCH] staging: vme_user: fix check alignment should match open parenthesis Alexon Oliveira
2023-07-27 8:03 ` Greg KH [this message]
2023-07-27 14:47 ` Alexon Oliveira
2023-07-27 15:05 ` Greg KH
2023-07-27 17:08 ` Alexon Oliveira
2023-07-27 17:21 ` Greg KH
2023-07-27 17:37 ` Alexon Oliveira
2023-07-28 5:24 ` Dan Carpenter
2023-07-28 17:43 ` Alexon Oliveira
2023-07-28 17:59 ` Dan Carpenter
2023-08-01 15:53 ` Alexon Oliveira
-- strict thread matches above, loose matches on Subject: below --
2023-08-04 21:20 Alexon Oliveira
2023-08-05 6:14 ` Greg KH
2023-08-07 15:13 ` Alexon Oliveira
2023-08-07 15:26 ` Greg KH
2023-08-07 20:30 ` Alexon Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072729-sensitive-spyglass-ec96@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexondunkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.