All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexon Oliveira <alexondunkan@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis
Date: Mon, 7 Aug 2023 17:26:04 +0200	[thread overview]
Message-ID: <2023080746-consonant-employed-030d@gregkh> (raw)
In-Reply-To: <ZNEKJH3mEoOwV6eF@alolivei-thinkpadt480s.gru.csb>

On Mon, Aug 07, 2023 at 12:13:40PM -0300, Alexon Oliveira wrote:
> On Sat, Aug 05, 2023 at 08:14:33AM +0200, Greg KH wrote:
> > On Fri, Aug 04, 2023 at 06:20:50PM -0300, Alexon Oliveira wrote:
> > > Fixed all CHECK: Alignment should match open parenthesis
> > > as reported by checkpatch to adhere to the Linux kernel
> > > coding-style guidelines.
> > 
> > This does not describe the changes you actually made in this patch :(
> > 
> Hi Greg,
> 
> Thank you for your feedback. Don't get me wrong, please, I'm just trying
> to understand it now, but honestly I don't know what is wrong with
> it this time. I described exactly what I did in the code: ran the
> checkpatch, which identified a lot of "CHECK: Alignment should match
> open parenthesis" messages, fixed them all according to the coding-style
> guidelines and comitted it.

But you did not change the alignment of the open parenthesis, right?
You deleted the trailing whitespace.

> 
> This is the same thing I did previously for the file
> drivers/staging/vme_user/vme_bridge.h in the commit
> 7d5ce25fb4c3cc91d16e27163dc141de0eba213b, but now is the file
> drivers/staging/vme_user/vme.c and commit
> a1f0b0a8ba9a496504c2e3d4b37cee388e78f0ea. Different files,
> different commits, similar fixes for the same warnings,
> and same description.
> 
> The only thing I found strange is because instead of starting a new
> email thread it ended up in the same email thread as the previous
> patch. Would that be the problem?

That would be a problem, and it seems you used the same subject line as
previous patches that were different?

Anyway, my comment was about the trailing whitespace change.

thanks,

greg k-h

  reply	other threads:[~2023-08-07 15:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 21:20 [PATCH] staging: vme_user: fix check alignment should match open parenthesis Alexon Oliveira
2023-08-05  6:14 ` Greg KH
2023-08-07 15:13   ` Alexon Oliveira
2023-08-07 15:26     ` Greg KH [this message]
2023-08-07 20:30       ` Alexon Oliveira
  -- strict thread matches above, loose matches on Subject: below --
2023-07-08  3:55 Alexon Oliveira
2023-07-27  8:03 ` Greg KH
2023-07-27 14:47   ` Alexon Oliveira
2023-07-27 15:05     ` Greg KH
2023-07-27 17:08       ` Alexon Oliveira
2023-07-27 17:21         ` Greg KH
2023-07-27 17:37           ` Alexon Oliveira
2023-07-28  5:24             ` Dan Carpenter
2023-07-28 17:43               ` Alexon Oliveira
2023-07-28 17:59                 ` Dan Carpenter
2023-08-01 15:53                   ` Alexon Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023080746-consonant-employed-030d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexondunkan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.