All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Thor Thayer <thor.thayer@linux.intel.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Tony Lindgren <tony@atomide.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
	linux-actions@lists.infradead.org,
	chrome-platform@lists.linux.dev, alsa-devel@alsa-project.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mfd: Explicitly include correct DT includes
Date: Fri, 28 Jul 2023 10:10:24 +0100	[thread overview]
Message-ID: <20230728091024.GE8175@google.com> (raw)
In-Reply-To: <20230714174731.4059811-1-robh@kernel.org>

On Fri, 14 Jul 2023, Rob Herring wrote:

> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/mfd/ab8500-core.c           | 1 -
>  drivers/mfd/acer-ec-a500.c          | 2 +-
>  drivers/mfd/act8945a.c              | 2 +-
>  drivers/mfd/altera-sysmgr.c         | 3 +--
>  drivers/mfd/arizona-core.c          | 1 -
>  drivers/mfd/atc260x-core.c          | 1 -
>  drivers/mfd/bcm590xx.c              | 1 -
>  drivers/mfd/cros_ec_dev.c           | 2 +-
>  drivers/mfd/da9052-i2c.c            | 5 +----
>  drivers/mfd/da9055-i2c.c            | 1 -
>  drivers/mfd/da9062-core.c           | 2 +-
>  drivers/mfd/hi655x-pmic.c           | 4 ++--
>  drivers/mfd/iqs62x.c                | 2 +-
>  drivers/mfd/lp873x.c                | 2 +-
>  drivers/mfd/madera-i2c.c            | 1 -
>  drivers/mfd/madera-spi.c            | 1 -
>  drivers/mfd/max77620.c              | 1 -
>  drivers/mfd/max77686.c              | 1 -
>  drivers/mfd/max77843.c              | 2 +-
>  drivers/mfd/max8907.c               | 1 -
>  drivers/mfd/max8925-core.c          | 1 -
>  drivers/mfd/max8997.c               | 1 -
>  drivers/mfd/max8998.c               | 1 -
>  drivers/mfd/mt6358-irq.c            | 5 ++---
>  drivers/mfd/mt6397-core.c           | 5 +++--
>  drivers/mfd/mt6397-irq.c            | 5 ++---
>  drivers/mfd/palmas.c                | 3 ++-
>  drivers/mfd/qcom-pm8008.c           | 2 +-
>  drivers/mfd/rave-sp.c               | 2 +-
>  drivers/mfd/rk8xx-core.c            | 2 +-
>  drivers/mfd/rohm-bd71828.c          | 2 +-
>  drivers/mfd/rohm-bd718x7.c          | 2 +-
>  drivers/mfd/rohm-bd9576.c           | 2 +-
>  drivers/mfd/rt5033.c                | 2 +-
>  drivers/mfd/rz-mtu3.c               | 4 +++-
>  drivers/mfd/sec-core.c              | 2 --
>  drivers/mfd/sprd-sc27xx-spi.c       | 2 +-
>  drivers/mfd/ssbi.c                  | 6 +++---
>  drivers/mfd/stm32-lptimer.c         | 1 +
>  drivers/mfd/stm32-timers.c          | 1 +
>  drivers/mfd/sun4i-gpadc.c           | 4 ++--
>  drivers/mfd/ti-lmu.c                | 1 -
>  drivers/mfd/ti_am335x_tscadc.c      | 2 +-
>  drivers/mfd/tps6507x.c              | 1 -
>  drivers/mfd/tps65090.c              | 1 -
>  drivers/mfd/tps65217.c              | 1 -
>  drivers/mfd/tps65218.c              | 1 -
>  drivers/mfd/tps6594-core.c          | 2 +-
>  drivers/mfd/twl6040.c               | 2 --
>  drivers/mfd/wm831x-core.c           | 3 +--
>  drivers/mtd/chips/cfi_cmdset_0002.c | 3 +--
>  51 files changed, 42 insertions(+), 66 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Thor Thayer <thor.thayer@linux.intel.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Tony Lindgren <tony@atomide.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
	linux-actions@lists.infradead.org,
	chrome-platform@lists.linux.dev, alsa-devel@alsa-project.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mfd: Explicitly include correct DT includes
Date: Fri, 28 Jul 2023 10:10:24 +0100	[thread overview]
Message-ID: <20230728091024.GE8175@google.com> (raw)
In-Reply-To: <20230714174731.4059811-1-robh@kernel.org>

On Fri, 14 Jul 2023, Rob Herring wrote:

> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/mfd/ab8500-core.c           | 1 -
>  drivers/mfd/acer-ec-a500.c          | 2 +-
>  drivers/mfd/act8945a.c              | 2 +-
>  drivers/mfd/altera-sysmgr.c         | 3 +--
>  drivers/mfd/arizona-core.c          | 1 -
>  drivers/mfd/atc260x-core.c          | 1 -
>  drivers/mfd/bcm590xx.c              | 1 -
>  drivers/mfd/cros_ec_dev.c           | 2 +-
>  drivers/mfd/da9052-i2c.c            | 5 +----
>  drivers/mfd/da9055-i2c.c            | 1 -
>  drivers/mfd/da9062-core.c           | 2 +-
>  drivers/mfd/hi655x-pmic.c           | 4 ++--
>  drivers/mfd/iqs62x.c                | 2 +-
>  drivers/mfd/lp873x.c                | 2 +-
>  drivers/mfd/madera-i2c.c            | 1 -
>  drivers/mfd/madera-spi.c            | 1 -
>  drivers/mfd/max77620.c              | 1 -
>  drivers/mfd/max77686.c              | 1 -
>  drivers/mfd/max77843.c              | 2 +-
>  drivers/mfd/max8907.c               | 1 -
>  drivers/mfd/max8925-core.c          | 1 -
>  drivers/mfd/max8997.c               | 1 -
>  drivers/mfd/max8998.c               | 1 -
>  drivers/mfd/mt6358-irq.c            | 5 ++---
>  drivers/mfd/mt6397-core.c           | 5 +++--
>  drivers/mfd/mt6397-irq.c            | 5 ++---
>  drivers/mfd/palmas.c                | 3 ++-
>  drivers/mfd/qcom-pm8008.c           | 2 +-
>  drivers/mfd/rave-sp.c               | 2 +-
>  drivers/mfd/rk8xx-core.c            | 2 +-
>  drivers/mfd/rohm-bd71828.c          | 2 +-
>  drivers/mfd/rohm-bd718x7.c          | 2 +-
>  drivers/mfd/rohm-bd9576.c           | 2 +-
>  drivers/mfd/rt5033.c                | 2 +-
>  drivers/mfd/rz-mtu3.c               | 4 +++-
>  drivers/mfd/sec-core.c              | 2 --
>  drivers/mfd/sprd-sc27xx-spi.c       | 2 +-
>  drivers/mfd/ssbi.c                  | 6 +++---
>  drivers/mfd/stm32-lptimer.c         | 1 +
>  drivers/mfd/stm32-timers.c          | 1 +
>  drivers/mfd/sun4i-gpadc.c           | 4 ++--
>  drivers/mfd/ti-lmu.c                | 1 -
>  drivers/mfd/ti_am335x_tscadc.c      | 2 +-
>  drivers/mfd/tps6507x.c              | 1 -
>  drivers/mfd/tps65090.c              | 1 -
>  drivers/mfd/tps65217.c              | 1 -
>  drivers/mfd/tps65218.c              | 1 -
>  drivers/mfd/tps6594-core.c          | 2 +-
>  drivers/mfd/twl6040.c               | 2 --
>  drivers/mfd/wm831x-core.c           | 3 +--
>  drivers/mtd/chips/cfi_cmdset_0002.c | 3 +--
>  51 files changed, 42 insertions(+), 66 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Thor Thayer <thor.thayer@linux.intel.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Tony Lindgren <tony@atomide.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
	linux-actions@lists.infradead.org,
	chrome-platform@lists.linux.dev, alsa-devel@alsa-project.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mfd: Explicitly include correct DT includes
Date: Fri, 28 Jul 2023 10:10:24 +0100	[thread overview]
Message-ID: <20230728091024.GE8175@google.com> (raw)
In-Reply-To: <20230714174731.4059811-1-robh@kernel.org>

On Fri, 14 Jul 2023, Rob Herring wrote:

> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/mfd/ab8500-core.c           | 1 -
>  drivers/mfd/acer-ec-a500.c          | 2 +-
>  drivers/mfd/act8945a.c              | 2 +-
>  drivers/mfd/altera-sysmgr.c         | 3 +--
>  drivers/mfd/arizona-core.c          | 1 -
>  drivers/mfd/atc260x-core.c          | 1 -
>  drivers/mfd/bcm590xx.c              | 1 -
>  drivers/mfd/cros_ec_dev.c           | 2 +-
>  drivers/mfd/da9052-i2c.c            | 5 +----
>  drivers/mfd/da9055-i2c.c            | 1 -
>  drivers/mfd/da9062-core.c           | 2 +-
>  drivers/mfd/hi655x-pmic.c           | 4 ++--
>  drivers/mfd/iqs62x.c                | 2 +-
>  drivers/mfd/lp873x.c                | 2 +-
>  drivers/mfd/madera-i2c.c            | 1 -
>  drivers/mfd/madera-spi.c            | 1 -
>  drivers/mfd/max77620.c              | 1 -
>  drivers/mfd/max77686.c              | 1 -
>  drivers/mfd/max77843.c              | 2 +-
>  drivers/mfd/max8907.c               | 1 -
>  drivers/mfd/max8925-core.c          | 1 -
>  drivers/mfd/max8997.c               | 1 -
>  drivers/mfd/max8998.c               | 1 -
>  drivers/mfd/mt6358-irq.c            | 5 ++---
>  drivers/mfd/mt6397-core.c           | 5 +++--
>  drivers/mfd/mt6397-irq.c            | 5 ++---
>  drivers/mfd/palmas.c                | 3 ++-
>  drivers/mfd/qcom-pm8008.c           | 2 +-
>  drivers/mfd/rave-sp.c               | 2 +-
>  drivers/mfd/rk8xx-core.c            | 2 +-
>  drivers/mfd/rohm-bd71828.c          | 2 +-
>  drivers/mfd/rohm-bd718x7.c          | 2 +-
>  drivers/mfd/rohm-bd9576.c           | 2 +-
>  drivers/mfd/rt5033.c                | 2 +-
>  drivers/mfd/rz-mtu3.c               | 4 +++-
>  drivers/mfd/sec-core.c              | 2 --
>  drivers/mfd/sprd-sc27xx-spi.c       | 2 +-
>  drivers/mfd/ssbi.c                  | 6 +++---
>  drivers/mfd/stm32-lptimer.c         | 1 +
>  drivers/mfd/stm32-timers.c          | 1 +
>  drivers/mfd/sun4i-gpadc.c           | 4 ++--
>  drivers/mfd/ti-lmu.c                | 1 -
>  drivers/mfd/ti_am335x_tscadc.c      | 2 +-
>  drivers/mfd/tps6507x.c              | 1 -
>  drivers/mfd/tps65090.c              | 1 -
>  drivers/mfd/tps65217.c              | 1 -
>  drivers/mfd/tps65218.c              | 1 -
>  drivers/mfd/tps6594-core.c          | 2 +-
>  drivers/mfd/twl6040.c               | 2 --
>  drivers/mfd/wm831x-core.c           | 3 +--
>  drivers/mtd/chips/cfi_cmdset_0002.c | 3 +--
>  51 files changed, 42 insertions(+), 66 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-07-28  9:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 17:47 [PATCH] mfd: Explicitly include correct DT includes Rob Herring
2023-07-14 17:47 ` Rob Herring
2023-07-14 17:47 ` Rob Herring
2023-07-28  9:10 ` Lee Jones [this message]
2023-07-28  9:10   ` Lee Jones
2023-07-28  9:10   ` Lee Jones
2023-09-11  4:31 ` patchwork-bot+chrome-platform
2023-09-11  4:31   ` patchwork-bot+chrome-platform
2023-09-11  4:31   ` patchwork-bot+chrome-platform
2023-09-11  4:49 ` patchwork-bot+chrome-platform
2023-09-11  4:49   ` patchwork-bot+chrome-platform
2023-09-11  4:49   ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728091024.GE8175@google.com \
    --to=lee@kernel.org \
    --cc=agross@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=cristian.ciocaltea@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=groeck@chromium.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mani@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=orsonzhai@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=support.opensource@diasemi.com \
    --cc=thor.thayer@linux.intel.com \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    --cc=wens@csie.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.