All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Pavel Machek <pavel@denx.de>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] mfd: rz-mtu3: Replace raw_spin_lock->spin_lock()
Date: Fri, 28 Jul 2023 11:29:31 +0100	[thread overview]
Message-ID: <20230728102931.GJ8175@google.com> (raw)
In-Reply-To: <20230719124729.270393-1-biju.das.jz@bp.renesas.com>

On Wed, 19 Jul 2023, Biju Das wrote:

> As per kernel documentation, use raw_spinlock_t only in real critical core
> code, low-level interrupt handling, and places where disabling preemption
> or interrupts is required. Here the lock is for concurrent register access
> from different drivers, hence spin_lock() is sufficient.
> 
> Reported-by: Pavel Machek <pavel@denx.de>
> Closes: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230717120333.165219-1-biju.das.jz@bp.renesas.com/
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> This patch depend upon [1]
> [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230717120333.165219-1-biju.das.jz@bp.renesas.com/
> ---
>  drivers/mfd/rz-mtu3.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Doesn't apply.  Please rebase and resend

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2023-07-28 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 12:47 [PATCH] mfd: rz-mtu3: Replace raw_spin_lock->spin_lock() Biju Das
2023-07-28 10:29 ` Lee Jones [this message]
2023-08-01  6:20   ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728102931.GJ8175@google.com \
    --to=lee@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=pavel@denx.de \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.