All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Roger Quadros <rogerq@kernel.org>,
	Simon Horman <simon.horman@corigine.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Richard Cochran <richardcochran@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
	<srk@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v12 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Fri, 28 Jul 2023 17:25:43 -0700	[thread overview]
Message-ID: <20230728172543.2d5f5660@kernel.org> (raw)
In-Reply-To: <20230727112827.3977534-7-danishanwar@ti.com>

On Thu, 27 Jul 2023 16:58:23 +0530 MD Danish Anwar wrote:
> +/* Classifier helpers */
> +void icssg_class_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac);
> +void icssg_class_set_host_mac_addr(struct regmap *miig_rt, const u8 *mac);
> +void icssg_class_disable(struct regmap *miig_rt, int slice);
> +void icssg_class_default(struct regmap *miig_rt, int slice, bool allmulti);
> +void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr);
> +
> +/* Buffer queue helpers */
> +int icssg_queue_pop(struct prueth *prueth, u8 queue);
> +void icssg_queue_push(struct prueth *prueth, int queue, u16 addr);
> +u32 icssg_queue_level(struct prueth *prueth, int queue);

If you create the prototypes when the functions are added there will 
be less need for __maybe_unused. Compiler only cares about prototypes
existing, not whether actual callers are in place.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Roger Quadros <rogerq@kernel.org>,
	Simon Horman <simon.horman@corigine.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Richard Cochran <richardcochran@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
	<srk@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v12 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Fri, 28 Jul 2023 17:25:43 -0700	[thread overview]
Message-ID: <20230728172543.2d5f5660@kernel.org> (raw)
In-Reply-To: <20230727112827.3977534-7-danishanwar@ti.com>

On Thu, 27 Jul 2023 16:58:23 +0530 MD Danish Anwar wrote:
> +/* Classifier helpers */
> +void icssg_class_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac);
> +void icssg_class_set_host_mac_addr(struct regmap *miig_rt, const u8 *mac);
> +void icssg_class_disable(struct regmap *miig_rt, int slice);
> +void icssg_class_default(struct regmap *miig_rt, int slice, bool allmulti);
> +void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr);
> +
> +/* Buffer queue helpers */
> +int icssg_queue_pop(struct prueth *prueth, u8 queue);
> +void icssg_queue_push(struct prueth *prueth, int queue, u16 addr);
> +u32 icssg_queue_level(struct prueth *prueth, int queue);

If you create the prototypes when the functions are added there will 
be less need for __maybe_unused. Compiler only cares about prototypes
existing, not whether actual callers are in place.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-07-29  0:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 11:28 [PATCH v12 00/10] Introduce ICSSG based ethernet Driver MD Danish Anwar
2023-07-27 11:28 ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 01/10] net: ti: icssg-prueth: Add Firmware Interface for ICSSG Ethernet driver MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 02/10] net: ti: icssg-prueth: Add mii helper apis and macros MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 03/10] net: ti: icssg-prueth: Add Firmware config and classification APIs MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 04/10] net: ti: icssg-prueth: Add icssg queues APIs and macros MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 05/10] dt-bindings: net: Add ICSSG Ethernet MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 06/10] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-29  0:24   ` Jakub Kicinski
2023-07-29  0:24     ` Jakub Kicinski
2023-07-31  4:57     ` [EXTERNAL] " Md Danish Anwar
2023-07-31  4:57       ` Md Danish Anwar
2023-07-31 11:19     ` Md Danish Anwar
2023-07-31 11:19       ` Md Danish Anwar
2023-07-31 16:51       ` Jakub Kicinski
2023-07-31 16:51         ` Jakub Kicinski
2023-07-29  0:25   ` Jakub Kicinski [this message]
2023-07-29  0:25     ` Jakub Kicinski
2023-07-31  9:43     ` [EXTERNAL] " Md Danish Anwar
2023-07-31  9:43       ` Md Danish Anwar
2023-07-27 11:28 ` [PATCH v12 07/10] net: ti: icssg-prueth: Add ICSSG Stats MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 08/10] net: ti: icssg-prueth: Add Standard network staticstics MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 09/10] net: ti: icssg-prueth: Add ethtool ops for ICSSG Ethernet driver MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar
2023-07-27 11:28 ` [PATCH v12 10/10] net: ti: icssg-prueth: Add Power management support MD Danish Anwar
2023-07-27 11:28   ` MD Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728172543.2d5f5660@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=danishanwar@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=simon.horman@corigine.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.