From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories
Date: Fri, 28 Jul 2023 21:51:56 -0700 [thread overview]
Message-ID: <20230729045156.GD4171@sol.localdomain> (raw)
In-Reply-To: <20230727172843.20542-4-krisman@suse.de>
On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote:
> dentry->d_name is only checked by the case-insensitive d_revalidate hook
> in the LOOKUP_CREATE/LOOKUP_RENAME_TARGET case since, for these cases,
> d_revalidate is always called with the parent inode read-locked, and
> therefore the name cannot change from under us.
"at least read-locked"? Or do you actually mean write-locked?
> +static inline int generic_ci_d_revalidate(struct dentry *dentry,
> + const struct qstr *name,
> + unsigned int flags)
No need for inline here.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: brauner@kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories
Date: Fri, 28 Jul 2023 21:51:56 -0700 [thread overview]
Message-ID: <20230729045156.GD4171@sol.localdomain> (raw)
In-Reply-To: <20230727172843.20542-4-krisman@suse.de>
On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote:
> dentry->d_name is only checked by the case-insensitive d_revalidate hook
> in the LOOKUP_CREATE/LOOKUP_RENAME_TARGET case since, for these cases,
> d_revalidate is always called with the parent inode read-locked, and
> therefore the name cannot change from under us.
"at least read-locked"? Or do you actually mean write-locked?
> +static inline int generic_ci_d_revalidate(struct dentry *dentry,
> + const struct qstr *name,
> + unsigned int flags)
No need for inline here.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-07-29 4:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 17:28 [PATCH v4 0/7] Support negative dentries on case-insensitive ext4 and f2fs Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 1/7] fs: Expose name under lookup to d_revalidate hook Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-28 14:00 ` Christian Brauner
2023-07-28 14:00 ` [f2fs-dev] " Christian Brauner
2023-07-28 15:49 ` Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 2/7] fs: Add DCACHE_CASEFOLDED_NAME flag Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-29 4:34 ` Eric Biggers
2023-07-29 4:34 ` [f2fs-dev] " Eric Biggers
2023-07-27 17:28 ` [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-28 13:06 ` Christian Brauner
2023-07-28 13:06 ` [f2fs-dev] " Christian Brauner
2023-07-28 15:09 ` Gabriel Krisman Bertazi
2023-07-29 4:18 ` Eric Biggers
2023-07-29 4:18 ` [f2fs-dev] " Eric Biggers
2023-07-29 4:20 ` Eric Biggers
2023-07-29 4:20 ` [f2fs-dev] " Eric Biggers
2023-08-03 17:37 ` Gabriel Krisman Bertazi
2023-08-03 17:37 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-08-04 4:41 ` Eric Biggers
2023-08-04 4:41 ` [f2fs-dev] " Eric Biggers
2023-08-08 1:33 ` Gabriel Krisman Bertazi
2023-08-08 1:33 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-29 4:51 ` Eric Biggers [this message]
2023-07-29 4:51 ` Eric Biggers
2023-08-03 16:56 ` Gabriel Krisman Bertazi
2023-08-03 16:56 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 4/7] libfs: Chain encryption checks after case-insensitive revalidation Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 5/7] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 6/7] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [PATCH v4 7/7] f2fs: " Gabriel Krisman Bertazi
2023-07-27 17:28 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 18:13 ` [PATCH v4 0/7] Support negative dentries on case-insensitive ext4 and f2fs Theodore Ts'o
2023-07-27 18:13 ` [f2fs-dev] " Theodore Ts'o
2023-07-27 18:39 ` Gabriel Krisman Bertazi
2023-07-27 18:39 ` [f2fs-dev] " Gabriel Krisman Bertazi
2023-07-27 19:41 ` Theodore Ts'o
2023-07-27 19:41 ` [f2fs-dev] " Theodore Ts'o
2023-07-28 7:45 ` Christian Brauner
2023-07-28 7:45 ` [f2fs-dev] " Christian Brauner
2023-07-28 11:21 ` Christian Brauner
2023-07-28 11:21 ` [f2fs-dev] " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729045156.GD4171@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=brauner@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=krisman@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.