All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Stefan Mayrhofer <stefan@familie-mayrhofer.net>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets
Date: Sat, 29 Jul 2023 10:53:25 +0200	[thread overview]
Message-ID: <20230729105325.18f803bf@windsurf> (raw)
In-Reply-To: <20230524165506.692213-1-stefan@familie-mayrhofer.net>

Hello Stefan,

Sorry for the slow feedback!

On Wed, 24 May 2023 18:55:06 +0200
Stefan Mayrhofer <stefan@familie-mayrhofer.net> wrote:

> Add aarch64 to BR2_PACKAGE_MONO_ARCH_SUPPORTS to allow building for aarch64 targets.
> 
> I have tested that this compiles successfully and runs on the actual target (imx8mp based board)
> 
> Signed-off-by: Stefan Mayrhofer <stefan@familie-mayrhofer.net>

Thanks, I've applied, after doing some very small tweaks:

- Commit title prefix changed from "package: mono:" to "package/mono:"
  which is the standard in Buildroot

- Wrapped lines of the commit logs to a reasonable length

- Reworded to avoid first person sentences ("I have tested ...")

- Modified the Config.in file to preserve alphabetic ordering of
  supported architectures.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-07-29  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 16:55 [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets Stefan Mayrhofer
2023-07-29  8:53 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230729105325.18f803bf@windsurf \
    --to=buildroot@buildroot.org \
    --cc=angelo.compagnucci@gmail.com \
    --cc=stefan@familie-mayrhofer.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.