All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets
@ 2023-05-24 16:55 Stefan Mayrhofer
  2023-07-29  8:53 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Mayrhofer @ 2023-05-24 16:55 UTC (permalink / raw)
  To: buildroot; +Cc: Angelo Compagnucci, Stefan Mayrhofer

Add aarch64 to BR2_PACKAGE_MONO_ARCH_SUPPORTS to allow building for aarch64 targets.

I have tested that this compiles successfully and runs on the actual target (imx8mp based board)

Signed-off-by: Stefan Mayrhofer <stefan@familie-mayrhofer.net>
---
 package/mono/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mono/Config.in b/package/mono/Config.in
index 76178bcf9b..640c6fb42a 100644
--- a/package/mono/Config.in
+++ b/package/mono/Config.in
@@ -6,7 +6,7 @@ config BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
 config BR2_PACKAGE_MONO_ARCH_SUPPORTS
 	bool
 	default y if (BR2_arm || BR2_armeb || BR2_i386 || \
-		      BR2_powerpc || BR2_x86_64)
+		      BR2_powerpc || BR2_x86_64 || BR2_aarch64)
 	depends on BR2_PACKAGE_HOST_MONO_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS
 
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets
  2023-05-24 16:55 [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets Stefan Mayrhofer
@ 2023-07-29  8:53 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-29  8:53 UTC (permalink / raw)
  To: Stefan Mayrhofer; +Cc: Angelo Compagnucci, buildroot

Hello Stefan,

Sorry for the slow feedback!

On Wed, 24 May 2023 18:55:06 +0200
Stefan Mayrhofer <stefan@familie-mayrhofer.net> wrote:

> Add aarch64 to BR2_PACKAGE_MONO_ARCH_SUPPORTS to allow building for aarch64 targets.
> 
> I have tested that this compiles successfully and runs on the actual target (imx8mp based board)
> 
> Signed-off-by: Stefan Mayrhofer <stefan@familie-mayrhofer.net>

Thanks, I've applied, after doing some very small tweaks:

- Commit title prefix changed from "package: mono:" to "package/mono:"
  which is the standard in Buildroot

- Wrapped lines of the commit logs to a reasonable length

- Reworded to avoid first person sentences ("I have tested ...")

- Modified the Config.in file to preserve alphabetic ordering of
  supported architectures.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-29  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 16:55 [Buildroot] [PATCH 1/1] package: mono: allow building for aarch64 targets Stefan Mayrhofer
2023-07-29  8:53 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.