* [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build
@ 2023-03-25 17:58 Raphael Pavlidis
2023-03-26 12:18 ` Thomas Petazzoni via buildroot
2023-07-29 22:15 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 6+ messages in thread
From: Raphael Pavlidis @ 2023-03-25 17:58 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine, Raphael Pavlidis
Add a patch to fix the build if only yescrypt is enabled.
Fixes:
- http://autobuild.buildroot.net/results/df6a16a55bf02cf2d7377f9636913f0b3bca574f
- http://autobuild.buildroot.net/results/758d4fd297fbd77ef846d3a3d4c207021f866752
Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
---
...-sflg-for-USE_YESCRYPT-in-newusers.c.patch | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
diff --git a/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
new file mode 100644
index 0000000000..6c2a15d898
--- /dev/null
+++ b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
@@ -0,0 +1,29 @@
+From 8f7d5e8adae3aa16c0e3a4cb5db34d6764aa0495 Mon Sep 17 00:00:00 2001
+From: Raphael Pavlidis <raphael.pavlidis@gmail.com>
+Date: Thu, 23 Mar 2023 19:16:12 +0100
+Subject: [PATCH v1 1/1] Define sflg for USE_YESCRYPT in newusers.c
+
+If only yescrypt is used then the boolean sflg is not defined, but it is
+access. Therefore, it causes a build error.
+
+Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
+---
+ src/newusers.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/newusers.c b/src/newusers.c
+index dd6b4421..9c2a626a 100644
+--- a/src/newusers.c
++++ b/src/newusers.c
+@@ -60,7 +60,7 @@ static bool rflg = false; /* create a system account */
+ #ifndef USE_PAM
+ static /*@null@*//*@observer@*/char *crypt_method = NULL;
+ #define cflg (NULL != crypt_method)
+-#if defined(USE_SHA_CRYPT) || defined(USE_BCRYPT)
++#if defined(USE_SHA_CRYPT) || defined(USE_BCRYPT) || defined(USE_YESCRYPT)
+ static bool sflg = false;
+ #endif
+ #ifdef USE_SHA_CRYPT
+--
+2.39.2
+
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build
2023-03-25 17:58 [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build Raphael Pavlidis
@ 2023-03-26 12:18 ` Thomas Petazzoni via buildroot
2023-04-04 18:31 ` Raphael Pavlidis
2023-07-29 22:15 ` Thomas Petazzoni via buildroot
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-03-26 12:18 UTC (permalink / raw)
To: Raphael Pavlidis; +Cc: Fabrice Fontaine, buildroot
On Sat, 25 Mar 2023 18:58:15 +0100
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:
> Add a patch to fix the build if only yescrypt is enabled.
>
> Fixes:
> - http://autobuild.buildroot.net/results/df6a16a55bf02cf2d7377f9636913f0b3bca574f
> - http://autobuild.buildroot.net/results/758d4fd297fbd77ef846d3a3d4c207021f866752
> Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> ---
> ...-sflg-for-USE_YESCRYPT-in-newusers.c.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
>
> diff --git a/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
> new file mode 100644
> index 0000000000..6c2a15d898
> --- /dev/null
> +++ b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
> @@ -0,0 +1,29 @@
> +From 8f7d5e8adae3aa16c0e3a4cb5db34d6764aa0495 Mon Sep 17 00:00:00 2001
> +From: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> +Date: Thu, 23 Mar 2023 19:16:12 +0100
> +Subject: [PATCH v1 1/1] Define sflg for USE_YESCRYPT in newusers.c
> +
> +If only yescrypt is used then the boolean sflg is not defined, but it is
> +access. Therefore, it causes a build error.
> +
> +Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
Thanks for fixing this! Has this patch been submitted to the upstream
shadow project?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build
2023-03-25 17:58 [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build Raphael Pavlidis
2023-03-26 12:18 ` Thomas Petazzoni via buildroot
@ 2023-07-29 22:15 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-29 22:15 UTC (permalink / raw)
To: Raphael Pavlidis; +Cc: Fabrice Fontaine, buildroot
On Sat, 25 Mar 2023 18:58:15 +0100
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:
> Add a patch to fix the build if only yescrypt is enabled.
>
> Fixes:
> - http://autobuild.buildroot.net/results/df6a16a55bf02cf2d7377f9636913f0b3bca574f
> - http://autobuild.buildroot.net/results/758d4fd297fbd77ef846d3a3d4c207021f866752
> Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> ---
> ...-sflg-for-USE_YESCRYPT-in-newusers.c.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
I have applied Bernd's patch instead, which has been accepted upstream.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-29 22:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-25 17:58 [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build Raphael Pavlidis
2023-03-26 12:18 ` Thomas Petazzoni via buildroot
2023-04-04 18:31 ` Raphael Pavlidis
2023-05-26 19:16 ` Raphael Pavlidis
[not found] ` <eb8cf642-62ed-3f32-a32e-f7d28fd6998f__26834.4457073667$1685128600$gmane$org@gmail.com>
2023-07-14 16:54 ` Bernd Kuhls
2023-07-29 22:15 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.