From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 5/6] RISC-V: KVM: use EBUSY when !vcpu->arch.ran_atleast_once
Date: Mon, 31 Jul 2023 09:04:19 -0300 [thread overview]
Message-ID: <20230731120420.91007-6-dbarboza@ventanamicro.com> (raw)
In-Reply-To: <20230731120420.91007-1-dbarboza@ventanamicro.com>
vcpu_set_reg_config() and vcpu_set_reg_isa_ext() is throwing an
EOPNOTSUPP error when !vcpu->arch.ran_atleast_once. In similar cases
we're throwing an EBUSY error, like in mvendorid/marchid/mimpid
set_reg().
EOPNOTSUPP has a conotation of finality. EBUSY is more adequate in this
case since its a condition/error related to the vcpu lifecycle.
Change these EOPNOTSUPP instances to EBUSY.
Suggested-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
arch/riscv/kvm/vcpu_onereg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
index 42bf01ab6a8f..07ce747620f9 100644
--- a/arch/riscv/kvm/vcpu_onereg.c
+++ b/arch/riscv/kvm/vcpu_onereg.c
@@ -209,7 +209,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
vcpu->arch.isa[0] = reg_val;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
break;
case KVM_REG_RISCV_CONFIG_REG(zicbom_block_size):
@@ -477,7 +477,7 @@ static int riscv_vcpu_set_isa_ext_single(struct kvm_vcpu *vcpu,
return -EINVAL;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
return 0;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org
Cc: anup@brainfault.org, atishp@atishpatra.org,
ajones@ventanamicro.com,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Subject: [PATCH 5/6] RISC-V: KVM: use EBUSY when !vcpu->arch.ran_atleast_once
Date: Mon, 31 Jul 2023 09:04:19 -0300 [thread overview]
Message-ID: <20230731120420.91007-6-dbarboza@ventanamicro.com> (raw)
In-Reply-To: <20230731120420.91007-1-dbarboza@ventanamicro.com>
vcpu_set_reg_config() and vcpu_set_reg_isa_ext() is throwing an
EOPNOTSUPP error when !vcpu->arch.ran_atleast_once. In similar cases
we're throwing an EBUSY error, like in mvendorid/marchid/mimpid
set_reg().
EOPNOTSUPP has a conotation of finality. EBUSY is more adequate in this
case since its a condition/error related to the vcpu lifecycle.
Change these EOPNOTSUPP instances to EBUSY.
Suggested-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
arch/riscv/kvm/vcpu_onereg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
index 42bf01ab6a8f..07ce747620f9 100644
--- a/arch/riscv/kvm/vcpu_onereg.c
+++ b/arch/riscv/kvm/vcpu_onereg.c
@@ -209,7 +209,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
vcpu->arch.isa[0] = reg_val;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
break;
case KVM_REG_RISCV_CONFIG_REG(zicbom_block_size):
@@ -477,7 +477,7 @@ static int riscv_vcpu_set_isa_ext_single(struct kvm_vcpu *vcpu,
return -EINVAL;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
return 0;
--
2.41.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
kvm@vger.kernel.org
Cc: anup@brainfault.org, atishp@atishpatra.org,
ajones@ventanamicro.com,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Subject: [PATCH 5/6] RISC-V: KVM: use EBUSY when !vcpu->arch.ran_atleast_once
Date: Mon, 31 Jul 2023 09:04:19 -0300 [thread overview]
Message-ID: <20230731120420.91007-6-dbarboza@ventanamicro.com> (raw)
In-Reply-To: <20230731120420.91007-1-dbarboza@ventanamicro.com>
vcpu_set_reg_config() and vcpu_set_reg_isa_ext() is throwing an
EOPNOTSUPP error when !vcpu->arch.ran_atleast_once. In similar cases
we're throwing an EBUSY error, like in mvendorid/marchid/mimpid
set_reg().
EOPNOTSUPP has a conotation of finality. EBUSY is more adequate in this
case since its a condition/error related to the vcpu lifecycle.
Change these EOPNOTSUPP instances to EBUSY.
Suggested-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
arch/riscv/kvm/vcpu_onereg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
index 42bf01ab6a8f..07ce747620f9 100644
--- a/arch/riscv/kvm/vcpu_onereg.c
+++ b/arch/riscv/kvm/vcpu_onereg.c
@@ -209,7 +209,7 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
vcpu->arch.isa[0] = reg_val;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
break;
case KVM_REG_RISCV_CONFIG_REG(zicbom_block_size):
@@ -477,7 +477,7 @@ static int riscv_vcpu_set_isa_ext_single(struct kvm_vcpu *vcpu,
return -EINVAL;
kvm_riscv_vcpu_fp_reset(vcpu);
} else {
- return -EOPNOTSUPP;
+ return -EBUSY;
}
return 0;
--
2.41.0
next prev parent reply other threads:[~2023-07-31 12:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:04 [PATCH 0/6] RISC-V: KVM: change get_reg/set_reg error codes Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` [PATCH 1/6] RISC-V: KVM: return ENOENT in *_one_reg() when reg is unknown Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-11-09 9:37 ` Andreas Schwab
2023-11-09 9:37 ` Andreas Schwab
2023-11-09 9:37 ` Andreas Schwab
2023-11-09 19:33 ` Daniel Henrique Barboza
2023-11-09 19:33 ` Daniel Henrique Barboza
2023-11-09 19:33 ` Daniel Henrique Barboza
2023-11-13 8:30 ` Andreas Schwab
2023-11-13 8:30 ` Andreas Schwab
2023-11-13 8:30 ` Andreas Schwab
2023-11-13 10:27 ` Daniel Henrique Barboza
2023-11-13 10:27 ` Daniel Henrique Barboza
2023-11-13 10:27 ` Daniel Henrique Barboza
2023-07-31 12:04 ` [PATCH 2/6] RISC-V: KVM: use ENOENT in *_one_reg() when extension is unavailable Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` [PATCH 3/6] RISC-V: KVM: do not EOPNOTSUPP in set_one_reg() zicbo(m|z) Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` [PATCH 4/6] RISC-V: KVM: do not EOPNOTSUPP in set KVM_REG_RISCV_TIMER_REG Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza [this message]
2023-07-31 12:04 ` [PATCH 5/6] RISC-V: KVM: use EBUSY when !vcpu->arch.ran_atleast_once Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:57 ` Andrew Jones
2023-07-31 12:57 ` Andrew Jones
2023-07-31 12:57 ` Andrew Jones
2023-07-31 12:04 ` [PATCH 6/6] docs: kvm: riscv: document EBUSY in KVM_SET_ONE_REG Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:04 ` Daniel Henrique Barboza
2023-07-31 12:36 ` [PATCH 0/6] RISC-V: KVM: change get_reg/set_reg error codes Andrew Jones
2023-07-31 12:36 ` Andrew Jones
2023-07-31 12:36 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731120420.91007-6-dbarboza@ventanamicro.com \
--to=dbarboza@ventanamicro.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.