[meta-arago][kirkstone/master][PATCH 0/5] Packagegroup cleaning and a new proposal

[meta-arago][kirkstone/master][PATCH 0/5] Packagegroup cleaning and a new proposal

[rs]

From: Randolph Sapp <rs@ti.com>

Clean up some package groups, introduce a new group for all-around
useful tools that all images should inherit, and drop some unnecessary
logic in the irqbalance append.

We'll have to talk a little more about what to do with the sysvinit
images. I see no reason why we can't inherit the configuration
mechanisms poky uses for multiple init systems, aside from having to
fragment the package feeds accordingly.

Randolph Sapp (5):
  packagegroup-arago-bootstrap: fix RDEPENDS notation
  packagegroup-arago-base: edit the summary to describe current use
  irqbalance: remove append to install systemd script
  packagegroup-arago-boot: add a new group for all-around useful
    packages
  arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL

 .../recipes-core/images/arago-image.inc         |  1 +
 .../recipes-core/images/arago-tiny-image.inc    |  1 +
 .../packagegroups/packagegroup-arago-base.bb    |  2 +-
 .../packagegroups/packagegroup-arago-boot.bb    | 17 +++++++++++++++++
 .../packagegroup-arago-bootstrap.bb             |  2 +-
 .../packagegroup-arago-tisdk-addons.bb          |  1 -
 .../irqbalance/irqbalance_git.bbappend          |  6 +-----
 7 files changed, 22 insertions(+), 8 deletions(-)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb

-- 
2.41.0

[meta-arago][kirkstone/master][PATCH 1/5] packagegroup-arago-bootstrap: fix RDEPENDS notation

[rs]

From: Randolph Sapp <rs@ti.com>

The RDEPENDS for this packagegroup was still using the legacy format so
it was being evaluated as a do-nothing group. Enable it.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
index b0ec64b0..50f759be 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
@@ -47,6 +47,6 @@ UTILS:append:k3 = " \
     k3conf \
 "
 
-RDEPENDS_${PN} = "\
+RDEPENDS:${PN} = "\
     ${UTILS} \
 "
-- 
2.41.0

Re: [meta-arago][kirkstone/master][PATCH 1/5] packagegroup-arago-bootstrap: fix RDEPENDS notation

[Denys Dmytriyenko]

On Thu, Jul 27, 2023 at 07:20:28PM -0500, rs@ti.com wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> The RDEPENDS for this packagegroup was still using the legacy format so
> it was being evaluated as a do-nothing group. Enable it.

Good catch!


> Signed-off-by: Randolph Sapp <rs@ti.com>

Acked-by: Denys Dmytriyenko <denys@konsulko.com>


> ---
>  .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
> index b0ec64b0..50f759be 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb
> @@ -47,6 +47,6 @@ UTILS:append:k3 = " \
>      k3conf \
>  "
>  
> -RDEPENDS_${PN} = "\
> +RDEPENDS:${PN} = "\
>      ${UTILS} \
>  "
> -- 
> 2.41.0

[meta-arago][kirkstone/master][PATCH 2/5] packagegroup-arago-base: edit the summary to describe current use

[rs]

From: Randolph Sapp <rs@ti.com>

Edit the summary of this packagegroup to more accurately describe it's
current use in this dependency web.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-core/packagegroups/packagegroup-arago-base.bb       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
index ff32112a..d3c1997e 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
@@ -1,4 +1,4 @@
-DESCRIPTION = "Basic task to get a device booting"
+DESCRIPTION = "Base tools that are recommended for most images"
 LICENSE = "MIT"
 PR = "r9"
 
-- 
2.41.0

Re: [meta-arago][kirkstone/master][PATCH 2/5] packagegroup-arago-base: edit the summary to describe current use

[Denys Dmytriyenko]

On Thu, Jul 27, 2023 at 07:20:29PM -0500, rs@ti.com wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Edit the summary of this packagegroup to more accurately describe it's
> current use in this dependency web.

May be worth to convert to SUMMARY as well...


> Signed-off-by: Randolph Sapp <rs@ti.com>

Acked-by: Denys Dmytriyenko <denys@konsulko.com>


> ---
>  .../recipes-core/packagegroups/packagegroup-arago-base.bb       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> index ff32112a..d3c1997e 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> @@ -1,4 +1,4 @@
> -DESCRIPTION = "Basic task to get a device booting"
> +DESCRIPTION = "Base tools that are recommended for most images"
>  LICENSE = "MIT"
>  PR = "r9"

[meta-arago][kirkstone/master][PATCH 3/5] irqbalance: remove append to install systemd script

[rs]

From: Randolph Sapp <rs@ti.com>

The source recipe that this file appends to already has the
corresponding logic to install both the systemd and sysvinit service and
set them to load on start. No reason to override them.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-extended/irqbalance/irqbalance_git.bbappend     | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend b/meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend
index ff504150..7c289fc1 100644
--- a/meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend
+++ b/meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend
@@ -1,8 +1,4 @@
 SRCREV = "c24ed221e9e82faf1ad22de133c3c97a0117c5d7"
-PV = "1.9.2"
-
-do_install:append () {
-         install -m 0644 ${S}/misc/irqbalance.service ${D}${systemd_unitdir}/system/irqbalanced.service
-}
+PV = "1.9.2+git${SRCPV}"
 
 PR:append = ".arago3"
-- 
2.41.0

[meta-arago][kirkstone/master][PATCH 4/5] packagegroup-arago-boot: add a new group for all-around useful packages

[rs]

From: Randolph Sapp <rs@ti.com>

Add a new package group for performance or QoL tools that all images
should inherit and add the first example of a package that should belong
here.

Irqbalance is a good example. It helps reduce irq response delays on
most if not all of our platforms and is only problematic for users
attempting to reduce jitter specifically through the use of irq pinning,
in which case it can be easily disabled.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-core/images/arago-image.inc         |  1 +
 .../packagegroups/packagegroup-arago-boot.bb    | 17 +++++++++++++++++
 .../packagegroup-arago-tisdk-addons.bb          |  1 -
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb

diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
index d00c1f70..0421dca3 100644
--- a/meta-arago-distro/recipes-core/images/arago-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-image.inc
@@ -11,6 +11,7 @@ EXTRA_IMAGECMD:ext2.gz += "-i 4096"
 
 IMAGE_INSTALL = " \
 	packagegroup-core-boot \
+	packagegroup-arago-boot \
 	${VIRTUAL-RUNTIME_initramfs} \
 	${CORE_IMAGE_EXTRA_INSTALL} \
 "
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
new file mode 100644
index 00000000..c9b87a45
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
@@ -0,0 +1,17 @@
+SUMMARY = "Tools or utilities that all images should inherit"
+DESCRIPTION = "These are packages that lead to general performance or QoL improvements on our platforms that should be inherited by all images. The idea is to keep this group as small as possible moving forward for compatibility with things like the tisdk-tiny-image build target."
+LICENSE = "MIT"
+PR = "r0"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+# packages that lead to general performance improvements
+PERFORMANCE_UTILS = " \
+    irqbalance \
+"
+
+RDEPENDS:${PN} = "\
+    ${PERFORMANCE_UTILS} \
+"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
index c678460d..a9b71fd1 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
@@ -50,7 +50,6 @@ UTILS:append:omap-a15 = " mmc-utils \
 
 UTILS:append:k3 = " mmc-utils \
                     switch-config \
-                    irqbalance \
                     ti-rpmsg-char \
                     ti-rpmsg-char-examples \
                     statcol \
-- 
2.41.0

Re: [meta-arago][kirkstone/master][PATCH 4/5] packagegroup-arago-boot: add a new group for all-around useful packages

[Denys Dmytriyenko]

"boot" packagegroup is usually used to list mandatory components required to 
boot the target.

"base" is where you list a minimal set of additional components that are often 
useful, but the target can still boot without.

And one can argue that performance util like irqbalance doesn't fit either of 
the above. While is probably fine to be included in all default images except 
tiny. Come to think of it, "addons" was a perfect place for it...


On Thu, Jul 27, 2023 at 07:20:31PM -0500, Randolph Sapp via lists.yoctoproject.org wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Add a new package group for performance or QoL tools that all images
> should inherit and add the first example of a package that should belong
> here.
> 
> Irqbalance is a good example. It helps reduce irq response delays on
> most if not all of our platforms and is only problematic for users
> attempting to reduce jitter specifically through the use of irq pinning,
> in which case it can be easily disabled.
> 
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>  .../recipes-core/images/arago-image.inc         |  1 +
>  .../packagegroups/packagegroup-arago-boot.bb    | 17 +++++++++++++++++
>  .../packagegroup-arago-tisdk-addons.bb          |  1 -
>  3 files changed, 18 insertions(+), 1 deletion(-)
>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
> index d00c1f70..0421dca3 100644
> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -11,6 +11,7 @@ EXTRA_IMAGECMD:ext2.gz += "-i 4096"
>  
>  IMAGE_INSTALL = " \
>  	packagegroup-core-boot \
> +	packagegroup-arago-boot \
>  	${VIRTUAL-RUNTIME_initramfs} \
>  	${CORE_IMAGE_EXTRA_INSTALL} \
>  "
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
> new file mode 100644
> index 00000000..c9b87a45
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
> @@ -0,0 +1,17 @@
> +SUMMARY = "Tools or utilities that all images should inherit"
> +DESCRIPTION = "These are packages that lead to general performance or QoL improvements on our platforms that should be inherited by all images. The idea is to keep this group as small as possible moving forward for compatibility with things like the tisdk-tiny-image build target."
> +LICENSE = "MIT"
> +PR = "r0"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +# packages that lead to general performance improvements
> +PERFORMANCE_UTILS = " \
> +    irqbalance \
> +"
> +
> +RDEPENDS:${PN} = "\
> +    ${PERFORMANCE_UTILS} \
> +"
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> index c678460d..a9b71fd1 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> @@ -50,7 +50,6 @@ UTILS:append:omap-a15 = " mmc-utils \
>  
>  UTILS:append:k3 = " mmc-utils \
>                      switch-config \
> -                    irqbalance \
>                      ti-rpmsg-char \
>                      ti-rpmsg-char-examples \
>                      statcol \
> -- 
> 2.41.0

[meta-arago][kirkstone/master][PATCH 5/5] arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL

[rs]

From: Randolph Sapp <rs@ti.com>

This image install override is interesting. Perhaps we should move to
the separate build target distro configs like pokey uses [1] to avoid
configuration collisions while still allowing for some base image
templating through include files like arago-image.inc

[1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
index 242e763c..77ee9ea2 100644
--- a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
@@ -6,4 +6,5 @@ IMAGE_FEATURES:remove = "splash"
 
 IMAGE_INSTALL = " \
 	packagegroup-arago-sysvinit-boot \
+	packagegroup-arago-boot \
 "
-- 
2.41.0

Re: [meta-arago][kirkstone/master][PATCH 5/5] arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL

[Denys Dmytriyenko]

On Thu, Jul 27, 2023 at 07:20:32PM -0500, Randolph Sapp via lists.yoctoproject.org wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> This image install override is interesting. Perhaps we should move to
> the separate build target distro configs like pokey uses [1] to avoid

What's "pokey"? It's Poky - https://elinux.org/Poky


> configuration collisions while still allowing for some base image
> templating through include files like arago-image.inc
> 
> [1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone

Either way, the above commit log doesn't seem to have anything to do with the 
actual change...


> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>  meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> index 242e763c..77ee9ea2 100644
> --- a/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-tiny-image.inc
> @@ -6,4 +6,5 @@ IMAGE_FEATURES:remove = "splash"
>  
>  IMAGE_INSTALL = " \
>  	packagegroup-arago-sysvinit-boot \
> +	packagegroup-arago-boot \

This include file is shared among tiny and bootstrap images. While addind 
irqbalance and/or other tools might be useful for bootstrapping (?) it is not 
so clear for the tiny image. It was meant to be the very bare minimum and also 
used as initramfs and jailhouse cells.