From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Date: Tue, 1 Aug 2023 09:51:29 +0200 [thread overview]
Message-ID: <20230801075129.GA23838@lst.de> (raw)
In-Reply-To: <20230801014737.28614-1-hsiangkao@linux.alibaba.com>
On Tue, Aug 01, 2023 at 09:47:37AM +0800, Gao Xiang wrote:
> Previously, .kill_sb() will be called only after fill_super fails.
> It will be changed [1].
>
> Besides, checking for s_magic in erofs_kill_sb() is unnecessary from
> any point of view. Let's get rid of it now.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Date: Tue, 1 Aug 2023 09:51:29 +0200 [thread overview]
Message-ID: <20230801075129.GA23838@lst.de> (raw)
In-Reply-To: <20230801014737.28614-1-hsiangkao@linux.alibaba.com>
On Tue, Aug 01, 2023 at 09:47:37AM +0800, Gao Xiang wrote:
> Previously, .kill_sb() will be called only after fill_super fails.
> It will be changed [1].
>
> Besides, checking for s_magic in erofs_kill_sb() is unnecessary from
> any point of view. Let's get rid of it now.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-08-01 7:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 7:57 [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb syzbot
2023-07-31 9:37 ` Christoph Hellwig
2023-07-31 9:37 ` Christoph Hellwig
2023-07-31 10:58 ` Gao Xiang
2023-07-31 10:58 ` Gao Xiang
2023-07-31 11:16 ` Christoph Hellwig
2023-07-31 11:16 ` Christoph Hellwig
2023-07-31 12:43 ` Christian Brauner
2023-07-31 12:43 ` Christian Brauner
2023-07-31 13:22 ` Christian Brauner
2023-07-31 13:22 ` Christian Brauner
2023-07-31 13:53 ` Christoph Hellwig
2023-07-31 13:53 ` Christoph Hellwig
2023-07-31 13:57 ` Christian Brauner
2023-07-31 13:57 ` Christian Brauner
2023-07-31 16:32 ` Christian Brauner
2023-07-31 16:32 ` Christian Brauner
2023-08-01 1:47 ` [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb() Gao Xiang
2023-08-01 1:47 ` Gao Xiang
2023-08-01 7:19 ` Christian Brauner
2023-08-01 7:19 ` Christian Brauner
2023-08-01 7:51 ` Christoph Hellwig [this message]
2023-08-01 7:51 ` Christoph Hellwig
2023-07-31 13:29 ` [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb Gao Xiang
2023-07-31 13:29 ` Gao Xiang
2023-08-29 3:40 ` Gao Xiang
2023-08-29 4:14 ` [syzbot] [erofs?] " syzbot
2023-08-29 5:32 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801075129.GA23838@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.