From: Stephen Hemminger <stephen@networkplumber.org>
To: Dengdui Huang <huangdengdui@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>,
<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
<anatoly.burakov@intel.com>, <liuyonglong@huawei.com>
Subject: Re: [PATCH] app/testpmd: add flush multicast MAC address command
Date: Tue, 1 Aug 2023 08:18:21 -0700 [thread overview]
Message-ID: <20230801081821.0fcbf4d1@hermes.local> (raw)
In-Reply-To: <20230801024304.2187484-1-huangdengdui@huawei.com>
On Tue, 1 Aug 2023 10:43:04 +0800
Dengdui Huang <huangdengdui@huawei.com> wrote:
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 0d0723f659..2d9d925776 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
> " Remove a MAC address from port_id.\n\n"
>
> + "mcast_addr flush (port_id)\n"
> + " To flush the set of multicast addresses.\n\n"
> +
> "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
> " Set the default MAC address for port_id.\n\n"
Why out this in middle of the mac_addr commands? better to be in logical or alpha order.
next prev parent reply other threads:[~2023-08-01 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 2:43 [PATCH] app/testpmd: add flush multicast MAC address command Dengdui Huang
2023-08-01 15:18 ` Stephen Hemminger [this message]
2023-08-02 1:28 ` huangdengdui
2023-08-02 2:41 ` huangdengdui
2023-08-02 4:16 ` Stephen Hemminger
2023-08-02 6:11 ` huangdengdui
2023-08-02 6:23 ` [PATCH v2] " Dengdui Huang
2023-09-28 17:23 ` Ferruh Yigit
2023-10-07 8:18 ` huangdengdui
2023-10-08 1:56 ` [PATCH v3 0/2] fix help string and add a new command Dengdui Huang
2023-10-08 1:56 ` [PATCH v3 1/2] app/testpmd: fix help string Dengdui Huang
2023-10-08 2:47 ` fengchengwen
2023-10-08 6:46 ` huangdengdui
2023-10-08 1:56 ` [PATCH v3 2/2] app/testpmd: add flush all multicast MAC address command Dengdui Huang
2023-10-08 2:50 ` fengchengwen
2023-10-08 6:46 ` [PATCH v3 0/2] fix help string and add a new command Dengdui Huang
2023-10-08 6:46 ` [PATCH v4 1/2] app/testpmd: fix help string Dengdui Huang
2023-10-08 6:46 ` [PATCH v4 2/2] app/testpmd: add flush all multicast MAC address command Dengdui Huang
2023-10-09 9:39 ` [PATCH v3 0/2] fix help string and add a new command Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801081821.0fcbf4d1@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=huangdengdui@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.